From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp1.axis.com (smtp1.axis.com [195.60.68.17]) by sourceware.org (Postfix) with ESMTPS id 66AED3858C52; Sat, 4 Feb 2023 03:19:42 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 66AED3858C52 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=axis.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=axis.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=axis.com; q=dns/txt; s=axis-central1; t=1675480782; x=1707016782; h=from:to:subject:mime-version:content-transfer-encoding: message-id:date; bh=2S49GOwVH5FSc/KCiLWpGRYliHXNOfV+os8/ns/KvZY=; b=cv4VBlrQiAm7vqw469g9+AM0GTpvHC3D19BZLS1VxkHjmn9+2iKeTs2H Nxakzg9sgpH6my4/5UUy74COjBHBfHScy41hJ7oiKw1q8oX76B33i+NsX llnGZ9QAElYD9HTSU7julufaBrByJjlxStY7+XeXrvYOreb+BQIlpPSPC YF6qj1greD2uuvJKIwojDoIkq9tfRjUIC6AeaPycpiPHDLl4W1g14a7qA GKXErmOh7DMdprCLXciNmCoG+X/BKlTwwijEf23oOKnj67vLTAM88d76X tUZ44qVjgrfarThdDWzWfXDTVybKCcmGoPgUA3q/5ZD14fi7pwA7s2L0z g==; From: Hans-Peter Nilsson To: , Subject: [PATCH] libstdc++: Avoid use of naked int32_t in unseq_backend_simd.h, PR108672 MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 8BIT Message-ID: <20230204031940.A747420426@pchp3.se.axis.com> Date: Sat, 4 Feb 2023 04:19:40 +0100 X-Spam-Status: No, score=-10.6 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,KAM_NUMSUBJECT,SPF_HELO_PASS,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Tested cris-elf and native x86_64-pc-linux-gnu. Ok to commit? ---- 8< ---- The use of a "naked" int32_t (i.e. without a fitting #include: stdint.h or cstdint or inttypes.h or an equivalent internal header), in libstdc++-v3/include/pstl/unseq_backend_simd.h, caused an error for cris-elf and apparently pru-elf and I guess all "newlib targets". (Unfortunately, there's a lack of other *-elf targets in recent months of gcc-testresults archives.) This does not manifest on e.g. native x86_64-pc-linux-gnu, because there, a definition is included as an effect of including stdlib.h in cstdlib (following the trace in native xtreme-header-2_a.ii with glibc-2.31-13+deb11u5). Maybe better than chasing the right #includes is to directly use the built-in type, like so: libstdc++-v3: PR libstdc++/108672 * include/pstl/unseq_backend_simd.h (__simd_or): Use __INT32_TYPE__ instead of int32_t. --- libstdc++-v3/include/pstl/unseq_backend_simd.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libstdc++-v3/include/pstl/unseq_backend_simd.h b/libstdc++-v3/include/pstl/unseq_backend_simd.h index a05de39f7576..f6265f5c16e5 100644 --- a/libstdc++-v3/include/pstl/unseq_backend_simd.h +++ b/libstdc++-v3/include/pstl/unseq_backend_simd.h @@ -74,7 +74,7 @@ __simd_or(_Index __first, _DifferenceType __n, _Pred __pred) noexcept const _Index __last = __first + __n; while (__last != __first) { - int32_t __flag = 1; + __INT32_TYPE__ __flag = 1; _PSTL_PRAGMA_SIMD_REDUCTION(& : __flag) for (_DifferenceType __i = 0; __i < __block_size; ++__i) if (__pred(*(__first + __i))) -- 2.30.2