public inbox for libstdc++@gcc.gnu.org
 help / color / mirror / Atom feed
From: Kefu Chai <tchaikov@gmail.com>
To: libstdc++@gcc.gnu.org
Cc: Kefu Chai <tchaikov@gmail.com>
Subject: [PATCH v1 0/1] Set _M_string_length before calling _M_dispose()
Date: Mon,  1 May 2023 15:06:21 +0800	[thread overview]
Message-ID: <20230501070622.847749-1-tchaikov@gmail.com> (raw)

This patch fixes the false alarm when performing the check introduced by
bf78b43873b0b7e8f9a430df38749b8b61f9c9b8 . A minimal reproducer can be
found at https://godbolt.org/z/7q4nG68xn

I am pasting the reproducer here just in case:

#include <cstring>
#include <string>
#include <sstream>

int main() {
    unsigned char buf[sizeof(std::string)] ;
    std::memset(buf, 0xff, sizeof(buf));
    const char s[] = "1234567890abcdefg";
    std::istringstream in{s};
    std::istreambuf_iterator<char> it{in}, end;
    auto* p = new (buf) std::string(it, end);
    return 0;
}

Tested on x86_64-pc-linux-gnu, with "make check-target-libstdc++-v3".
Would be great if this change can be included in thunk, 13.2 and 12
branches.

Kefu Chai (1):
  libstdc++: Set _M_string_length before calling _M_dispose()

 libstdc++-v3/include/bits/basic_string.tcc | 1 +
 1 file changed, 1 insertion(+)

-- 
2.40.1


             reply	other threads:[~2023-05-01  7:06 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-05-01  7:06 Kefu Chai [this message]
2023-05-01  7:06 ` [PATCH v1 1/1] libstdc++: " Kefu Chai
2023-05-02 14:06   ` Jonathan Wakely
2023-05-03  2:17   ` [PATCH v2 0/1] " Kefu Chai
2023-05-03  2:17     ` [PATCH v2 1/1] libstdc++: Set _M_string_length before calling _M_dispose() [PR109703] Kefu Chai
2023-05-03 12:22     ` [PATCH v2 0/1] Set _M_string_length before calling _M_dispose() Jonathan Wakely
2023-05-03 12:30       ` kefu chai
2023-05-01 20:04 ` [PATCH v1 " Jonathan Wakely
2023-05-01 20:05   ` Jonathan Wakely

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230501070622.847749-1-tchaikov@gmail.com \
    --to=tchaikov@gmail.com \
    --cc=libstdc++@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).