From: Kefu Chai <tchaikov@gmail.com>
To: libstdc++@gcc.gnu.org
Cc: gcc-patches@gcc.gnu.org, Kefu Chai <tchaikov@gmail.com>
Subject: [PATCH v2 0/1] Set _M_string_length before calling _M_dispose()
Date: Wed, 3 May 2023 10:17:12 +0800 [thread overview]
Message-ID: <20230503021713.1146069-1-tchaikov@gmail.com> (raw)
In-Reply-To: <20230501070622.847749-2-tchaikov@gmail.com>
Hi Jonathan,
Thank you for your review and suggestion. The change looks great!
Assigning a value with an immediate zero is indeed much faster.
in v2:
* revised the commit message a little bit, I found it a little bit
difficult to parse when re-reading it.
* associated the commit with PR/libstdc++/109703. as I just filed
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=109706, which turns out
to be a dup of https://gcc.gnu.org/bugzilla/show_bug.cgi?id=109703
The rest of the v2 patch is identical to the one attached in your reply.
Would you please taking another look?
Kefu Chai (1):
libstdc++: Set _M_string_length before calling _M_dispose() [PR109703]
libstdc++-v3/include/bits/basic_string.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--
2.40.1
next prev parent reply other threads:[~2023-05-03 2:17 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-01 7:06 [PATCH v1 " Kefu Chai
2023-05-01 7:06 ` [PATCH v1 1/1] libstdc++: " Kefu Chai
2023-05-02 14:06 ` Jonathan Wakely
2023-05-03 2:17 ` Kefu Chai [this message]
2023-05-03 2:17 ` [PATCH v2 1/1] libstdc++: Set _M_string_length before calling _M_dispose() [PR109703] Kefu Chai
2023-05-03 12:22 ` [PATCH v2 0/1] Set _M_string_length before calling _M_dispose() Jonathan Wakely
2023-05-03 12:30 ` kefu chai
2023-05-01 20:04 ` [PATCH v1 " Jonathan Wakely
2023-05-01 20:05 ` Jonathan Wakely
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230503021713.1146069-1-tchaikov@gmail.com \
--to=tchaikov@gmail.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=libstdc++@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).