public inbox for
 help / color / mirror / Atom feed
* [committed] libstdc++: Fix PSTL test that fails in C++20
@ 2023-06-01 15:56 Jonathan Wakely
  0 siblings, 0 replies; only message in thread
From: Jonathan Wakely @ 2023-06-01 15:56 UTC (permalink / raw)
  To: libstdc++, gcc-patches; +Cc: Thomas Rodgers

Tested x86_64-linux. Pushed to trunk, will backport too.

Tom, this will require rebasing your PSTL rebase patch, but it should be

-- >8 --

This test fails in C++20 and later due to a warning:

warning: C++20 says that these are ambiguous, even though the second is reversed:
note: candidate 1: 'bool MyClass::operator==(const MyClass&)'
note: candidate 2: 'bool MyClass::operator==(const MyClass&)' (reversed)
note: try making the operator a 'const' member function
FAIL: 26_numerics/pstl/numeric_ops/ (test for excess errors)


	* testsuite/26_numerics/pstl/numeric_ops/
	Add const to equality operator.
 .../testsuite/26_numerics/pstl/numeric_ops/  | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/libstdc++-v3/testsuite/26_numerics/pstl/numeric_ops/ b/libstdc++-v3/testsuite/26_numerics/pstl/numeric_ops/
index ec020b42bbb..bec1c141278 100644
--- a/libstdc++-v3/testsuite/26_numerics/pstl/numeric_ops/
+++ b/libstdc++-v3/testsuite/26_numerics/pstl/numeric_ops/
@@ -68,7 +68,7 @@ class MyClass
     friend MyClass operator*(const MyClass& x, const MyClass& y) { return MyClass(x.my_field * y.my_field); }
-    operator==(const MyClass& in)
+    operator==(const MyClass& in) const
         return my_field == in.my_field;

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2023-06-01 15:56 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-06-01 15:56 [committed] libstdc++: Fix PSTL test that fails in C++20 Jonathan Wakely

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).