From: Jonathan Wakely <jwakely@redhat.com>
To: libstdc++@gcc.gnu.org, gcc-patches@gcc.gnu.org
Cc: Jason Merrill <jason@redhat.com>
Subject: [committed] [gcc-12] libstdc++: avoid bogus -Wrestrict [PR105651]
Date: Wed, 21 Jun 2023 13:22:07 +0100 [thread overview]
Message-ID: <20230621122207.302494-1-jwakely@redhat.com> (raw)
I've pushed Jason's patch from https://gcc.gnu.org/PR105651#c17 to the
gcc-12 branch, because Jakub's fix on gcc-13 isn't possible to backport.
Tested x86_64-linux, pushed to gcc-12.
-- >8 --
PR tree-optimization/105651
libstdc++-v3/ChangeLog:
* include/bits/basic_string.tcc (_M_replace): Add an assert
to avoid -Wrestrict false positive.
---
libstdc++-v3/include/bits/basic_string.tcc | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/libstdc++-v3/include/bits/basic_string.tcc b/libstdc++-v3/include/bits/basic_string.tcc
index 0696b96604c..48fa28e6466 100644
--- a/libstdc++-v3/include/bits/basic_string.tcc
+++ b/libstdc++-v3/include/bits/basic_string.tcc
@@ -529,6 +529,10 @@ _GLIBCXX_BEGIN_NAMESPACE_VERSION
{
const size_type __nleft = (__p + __len1) - __s;
this->_S_move(__p, __s, __nleft);
+ // Tell the middle-end that the copy can't overlap
+ // (PR105651).
+ if (__len2 < __nleft)
+ __builtin_unreachable();
this->_S_copy(__p + __nleft, __p + __len2,
__len2 - __nleft);
}
--
2.40.1
reply other threads:[~2023-06-21 12:22 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230621122207.302494-1-jwakely@redhat.com \
--to=jwakely@redhat.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=jason@redhat.com \
--cc=libstdc++@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).