From: Hans-Peter Nilsson <hp@axis.com>
To: Thomas Rodgers <trodgers@redhat.com>
Cc: <jwakely@redhat.com>, <libstdc++@gcc.gnu.org>, <gcc-patches@gcc.gnu.org>
Subject: PR108672 re-fixed after [PATCH] libstdc++: Synchronize PSTL with upstream
Date: Fri, 30 Jun 2023 05:48:47 +0200 [thread overview]
Message-ID: <20230630034847.0D200203F8@pchp3.se.axis.com> (raw)
In-Reply-To: <CAMmuTO_wLbsjUdPL6Oxc-TkwxLQSh+=vmE3=NzwkavGXAyQ7qg@mail.gmail.com> (message from Thomas Rodgers via Gcc-patches on Mon, 26 Jun 2023 11:57:49 -0700)
> Date: Mon, 26 Jun 2023 11:57:49 -0700
> From: Thomas Rodgers via Gcc-patches <gcc-patches@gcc.gnu.org>
> On Wed, May 17, 2023 at 12:32 PM Jonathan Wakely <jwakely@redhat.com> wrote:
> > All the actual code changes look good.
Unfortunately, this overwrote the fix for PR108672. I take
it there's a step missing from the synchronization process;
a check that no local commits are overwritten? Sounds like
something that can be fully scripted (not volunteering) or
already available (like, "list all commits affecting
contents touched by/between two named commits").
I did *not* check whether any other local commits were also
overwritten. Also, not sure about whether better try to get
this upstreamed: __INT32_TYPE__ seems gcc-specific.
Anyway, r13-5702-g72058eea9d407e was "re-committed" per
below as obvious after regtesting cris-elf.
brgds, H-P
-- >8 --
Subject: libstdc++: Re-apply PR108672 fix (avoid use of naked int32_t in unseq_backend_simd.h)
The fix was overwritten by r14-2109-g3162ca09dbdc2e "libstdc++:
Synchronize PSTL with upstream".
libstdc++-v3:
PR libstdc++/108672
* include/pstl/unseq_backend_simd.h (__simd_or): Re-apply using
__INT32_TYPE__ instead of int32_t.
---
libstdc++-v3/include/pstl/unseq_backend_simd.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/libstdc++-v3/include/pstl/unseq_backend_simd.h b/libstdc++-v3/include/pstl/unseq_backend_simd.h
index 69784bcdbe66..f3c38fbbbc2a 100644
--- a/libstdc++-v3/include/pstl/unseq_backend_simd.h
+++ b/libstdc++-v3/include/pstl/unseq_backend_simd.h
@@ -74,7 +74,7 @@ __simd_or(_Index __first, _DifferenceType __n, _Pred __pred) noexcept
const _Index __last = __first + __n;
while (__last != __first)
{
- int32_t __flag = 1;
+ __INT32_TYPE__ __flag = 1;
_PSTL_PRAGMA_SIMD_REDUCTION(& : __flag)
for (_DifferenceType __i = 0; __i < __block_size; ++__i)
if (__pred(*(__first + __i)))
--
2.30.2
next prev parent reply other threads:[~2023-06-30 3:48 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-20 3:39 Thomas Rodgers
2023-05-17 19:31 ` Jonathan Wakely
2023-06-26 18:57 ` Thomas Rodgers
2023-06-30 3:48 ` Hans-Peter Nilsson [this message]
2023-06-30 8:42 ` PR108672 re-fixed after " Jonathan Wakely
2023-06-30 9:57 ` Jonathan Wakely
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230630034847.0D200203F8@pchp3.se.axis.com \
--to=hp@axis.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=jwakely@redhat.com \
--cc=libstdc++@gcc.gnu.org \
--cc=trodgers@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).