public inbox for libstdc++@gcc.gnu.org
 help / color / mirror / Atom feed
From: Ken Matsui <kmatsui@gcc.gnu.org>
To: gcc-patches@gcc.gnu.org
Cc: libstdc++@gcc.gnu.org, Ken Matsui <kmatsui@gcc.gnu.org>
Subject: [PATCH v5 2/2] libstdc++: Use new built-in trait __is_pointer
Date: Wed, 12 Jul 2023 20:19:01 -0700	[thread overview]
Message-ID: <20230713031901.18162-2-kmatsui@gcc.gnu.org> (raw)
In-Reply-To: <20230713031901.18162-1-kmatsui@gcc.gnu.org>

This patch lets libstdc++ use new built-in trait __is_pointer.

libstdc++-v3/ChangeLog:

	* include/bits/cpp_type_traits.h (__is_ptr): Use __is_pointer
	built-in trait.
	* include/std/type_traits (is_pointer): Likewise. Optimize its
	implementation.
	(is_pointer_v): Likewise.

Signed-off-by: Ken Matsui <kmatsui@gcc.gnu.org>
---
 libstdc++-v3/include/bits/cpp_type_traits.h |  8 ++++
 libstdc++-v3/include/std/type_traits        | 44 +++++++++++++++++----
 2 files changed, 44 insertions(+), 8 deletions(-)

diff --git a/libstdc++-v3/include/bits/cpp_type_traits.h b/libstdc++-v3/include/bits/cpp_type_traits.h
index 3711e4be526..4da1e7c407c 100644
--- a/libstdc++-v3/include/bits/cpp_type_traits.h
+++ b/libstdc++-v3/include/bits/cpp_type_traits.h
@@ -363,6 +363,13 @@ __INT_N(__GLIBCXX_TYPE_INT_N_3)
   //
   // Pointer types
   //
+#if __has_builtin(__is_pointer)
+  template<typename _Tp>
+    struct __is_ptr : __truth_type<__is_pointer(_Tp)>
+    {
+      enum { __value = __is_pointer(_Tp) };
+    };
+#else
   template<typename _Tp>
     struct __is_ptr
     {
@@ -376,6 +383,7 @@ __INT_N(__GLIBCXX_TYPE_INT_N_3)
       enum { __value = 1 };
       typedef __true_type __type;
     };
+#endif
 
   //
   // An arithmetic type is an integer type or a floating point type
diff --git a/libstdc++-v3/include/std/type_traits b/libstdc++-v3/include/std/type_traits
index 0e7a9c9c7f3..16b2f6de536 100644
--- a/libstdc++-v3/include/std/type_traits
+++ b/libstdc++-v3/include/std/type_traits
@@ -515,19 +515,33 @@ _GLIBCXX_BEGIN_NAMESPACE_VERSION
     struct is_array<_Tp[]>
     : public true_type { };
 
-  template<typename>
-    struct __is_pointer_helper
+  /// is_pointer
+#if __has_builtin(__is_pointer)
+  template<typename _Tp>
+    struct is_pointer
+    : public __bool_constant<__is_pointer(_Tp)>
+    { };
+#else
+  template<typename _Tp>
+    struct is_pointer
     : public false_type { };
 
   template<typename _Tp>
-    struct __is_pointer_helper<_Tp*>
+    struct is_pointer<_Tp*>
     : public true_type { };
 
-  /// is_pointer
   template<typename _Tp>
-    struct is_pointer
-    : public __is_pointer_helper<__remove_cv_t<_Tp>>::type
-    { };
+    struct is_pointer<_Tp* const>
+    : public true_type { };
+
+  template<typename _Tp>
+    struct is_pointer<_Tp* volatile>
+    : public true_type { };
+
+  template<typename _Tp>
+    struct is_pointer<_Tp* const volatile>
+    : public true_type { };
+#endif
 
   /// is_lvalue_reference
   template<typename>
@@ -3168,8 +3182,22 @@ template <typename _Tp>
 template <typename _Tp, size_t _Num>
   inline constexpr bool is_array_v<_Tp[_Num]> = true;
 
+#if __has_builtin(__is_pointer)
+template <typename _Tp>
+  inline constexpr bool is_pointer_v = __is_pointer(_Tp);
+#else
 template <typename _Tp>
-  inline constexpr bool is_pointer_v = is_pointer<_Tp>::value;
+  inline constexpr bool is_pointer_v = false;
+template <typename _Tp>
+  inline constexpr bool is_pointer_v<_Tp*> = true;
+template <typename _Tp>
+  inline constexpr bool is_pointer_v<_Tp* const> = true;
+template <typename _Tp>
+  inline constexpr bool is_pointer_v<_Tp* volatile> = true;
+template <typename _Tp>
+  inline constexpr bool is_pointer_v<_Tp* const volatile> = true;
+#endif
+
 template <typename _Tp>
   inline constexpr bool is_lvalue_reference_v = false;
 template <typename _Tp>
-- 
2.41.0


  reply	other threads:[~2023-07-13  3:20 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-07-10  5:23 [PATCH 1/2] c++, libstdc++: implement __is_pointer built-in trait Ken Matsui
2023-07-10  5:23 ` [PATCH 2/2] libstdc++: use new built-in trait __is_pointer Ken Matsui
2023-07-10  5:32   ` Daniel Krügler
2023-07-10  5:34     ` Ken Matsui
2023-07-10  5:38 ` [PATCH v2 1/2] c++, libstdc++: implement __is_pointer built-in trait Ken Matsui
2023-07-10  5:38   ` [PATCH v2 2/2] libstdc++: use new built-in trait __is_pointer Ken Matsui
2023-07-10  5:50   ` [PATCH v2 1/2] c++, libstdc++: implement __is_pointer built-in trait Ken Matsui
2023-07-12 10:01     ` Jonathan Wakely
2023-07-12 20:42       ` Ken Matsui
2023-07-13  1:11         ` [PATCH v3 1/2] c++, libstdc++: Implement " Ken Matsui
2023-07-13  1:11           ` [PATCH v3 2/2] libstdc++: Use new built-in trait __is_pointer Ken Matsui
2023-07-13  1:13           ` [PATCH v3 1/2] c++, libstdc++: Implement __is_pointer built-in trait Ken Matsui
2023-07-13  1:15             ` Ken Matsui
2023-07-13  3:16           ` [PATCH v4 " Ken Matsui
2023-07-13  3:16             ` [PATCH v4 2/2] libstdc++: Use new built-in trait __is_pointer Ken Matsui
2023-07-13  3:19             ` [PATCH v5 1/2] c++, libstdc++: Implement __is_pointer built-in trait Ken Matsui
2023-07-13  3:19               ` Ken Matsui [this message]
2023-07-13 20:48                 ` [PATCH v6 " Ken Matsui
2023-07-13 20:48                   ` [PATCH v6 2/2] libstdc++: Use new built-in trait __is_pointer Ken Matsui
2023-09-01 13:00                     ` [PING][PATCH " Ken Matsui
2023-07-13  9:21         ` [PATCH v2 1/2] c++, libstdc++: implement __is_pointer built-in trait Jonathan Wakely
2023-07-13 20:04           ` Ken Matsui
2023-07-14 10:48             ` Jonathan Wakely
2023-07-14 10:49               ` Jonathan Wakely
2023-07-14 19:55                 ` Ken Matsui
2023-07-12  4:40 ` [PATCH " François Dumont
2023-07-12  9:47   ` Jonathan Wakely
2023-07-12  9:48 ` Jonathan Wakely

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230713031901.18162-2-kmatsui@gcc.gnu.org \
    --to=kmatsui@gcc.gnu.org \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=libstdc++@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).