From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp1.axis.com (smtp1.axis.com [195.60.68.17]) by sourceware.org (Postfix) with ESMTPS id ABDCC3858296; Thu, 17 Aug 2023 23:19:34 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org ABDCC3858296 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=axis.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=axis.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=axis.com; q=dns/txt; s=axis-central1; t=1692314374; x=1723850374; h=from:to:cc:in-reply-to:subject:mime-version: content-transfer-encoding:references:message-id:date; bh=s+wb83BoAm78O7i5EdtNoEIbzVICl1OlDTgbRZkQJYI=; b=UHP71mx7U4QyOmpjMRKTvNO2+3FSMWhOjM21/PEJ8vLuA9Du52uX8AQ/ 2wyUD5OuSNFx6T8/A5bwpkyqga06MjfMhGYFuwLtVj6thvZXMASzbufeB Juy0r9wsOdd/fKTV2yEnYA7ht9402ZgSDnF17rlxKU5F6aqCk2Azn/t3i KY+lZe7TD4uGi1fnID7AA5EG+ZkdjVm28P4RHr2nIF80a+hFwGkjHMB/d zjsv2UzhcCT1Isa1tq7/aw/tVyUf2pGPkUOtuBZwF0Oa849h8/x1vmbIn /9frHoP8i+0WkKlY3HM4FL3FnPVioPrxSHGyxXPJ/DxL+Exbmbpxxpcf3 A==; From: Hans-Peter Nilsson To: Jonathan Wakely CC: , In-Reply-To: <20230817203237.1131595-1-jwakely@redhat.com> (message from Jonathan Wakely via Gcc-patches on Thu, 17 Aug 2023 21:32:29 +0100) Subject: Re: [committed] libstdc++: Reuse double overload of __convert_to_v if possible MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 8BIT References: <20230817203237.1131595-1-jwakely@redhat.com> Message-ID: <20230817231932.EEB372041D@pchp3.se.axis.com> Date: Fri, 18 Aug 2023 01:19:32 +0200 X-Spam-Status: No, score=-5.3 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_PASS,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: > Date: Thu, 17 Aug 2023 21:32:29 +0100 > From: Jonathan Wakely via Gcc-patches > Tested x86_64-linux. Pushed to trunk. Does the below typo imply that for x86_64-linux, "__DBL_MANT_DIG__ == __LDBL_MANT_DIG__" is false and the code is actually untested? > libstdc++-v3/ChangeLog: > > * config/locale/generic/c_locale.cc (__convert_to_v): Reuse > double overload for long double if possible. Breakage for cris-elf: libtool: compile: /auto/cris-elf/gccobj/./gcc/xgcc -shared-libgcc -B/auto/cris-elf/gccobj/./gcc -nostdinc++ -L/auto/cris-elf/gccobj/cris-elf/libstdc++-v3/src -L/auto/cris-elf/gccobj/cris-elf/libstdc++-v3/src/.libs -L/auto/cris-elf/gccobj/cris-elf/libstdc++-v3/libsupc++/.libs -nostdinc -B/auto/cris-elf/gccobj/cris-elf/newlib/ -isystem /auto/cris-elf/gccobj/cris-elf/newlib/targ-include -isystem /auto/gcc/newlib/libc/include -B/auto/cris-elf/gccobj/cris-elf/libgloss/cris -L/auto/cris-elf/gccobj/cris-elf/libgloss/libnosys -L/auto/gcc/libgloss/cris -B/auto/cris-elf/pre/cris-elf/bin/ -B/auto/cris-elf/pre/cris-elf/lib/ -isystem /auto/cris-elf/pre/cris-elf/include -isystem /auto/cris-elf/pre/cris-elf/sys-include -I/auto/gcc/libstdc++-v3/../libgcc -I/auto/cris-elf/gccobj/cris-elf/libstdc++-v3/include/cris-elf -I/auto/cris-elf/gccobj/cris-elf/libstdc++-v3/include -I/auto/gcc/libstdc++-v3/libsupc++ -std=gnu++98 -fno-implicit-templates -Wall -Wextra -Wwrite-strings -Wcast-qual -Wabi=2 -fdiagnos tics-show-location=once -ffunction-sections -fdata-sections -frandom-seed=c++locale.lo -g -O2 -fimplicit-templates -c c++locale.cc -o c++locale.o c++locale.cc: In function 'void std::__convert_to_v(const char*, _Tp&, ios_base::iostate&, int* const&) [with _Tp = long double; ios_base::iostate = ios_base::iostate; __c_locale = int*]': c++locale.cc:192:49: error: expected primary-expression before ')' token 192 | __convert_to_v(__s, __d, __err, __c_locale); | ^ make[5]: *** [Makefile:881: c++locale.lo] Error 1 make[5]: Leaving directory '/auto/cris-elf/gccobj/cris-elf/libstdc++-v3/src/c++98' (Formally, a commit in the range ee40bdbfb07c..aad83d61d2e9 but this one seems pretty clear.) In the context: __convert_to_v(const char* __s, long double& __v, ios_base::iostate& __err, const __c_locale&) throw() So, __c_locale" appears to be the type(def) and you're missing a parameter name. :) brgds, H-P