From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp2.axis.com (smtp2.axis.com [195.60.68.18]) by sourceware.org (Postfix) with ESMTPS id B99163858C66; Wed, 6 Sep 2023 23:09:19 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org B99163858C66 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=axis.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=axis.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=axis.com; q=dns/txt; s=axis-central1; t=1694041760; x=1725577760; h=from:to:cc:in-reply-to:subject:mime-version: content-transfer-encoding:references:message-id:date; bh=2WwWRxn7Wblp2uqVgF75do4ckjwnXihVr02+6tGTFns=; b=HqQeZWxD2/8nR+4jr0KYV7NRqbFkKAEpVX544q+6WMCtGxttuVogAhTY 1QDyZW8ibtaeBfbK4xK56ExTPwsicoBU53EeGy1Ng5bQzLeDcjUjJf894 yj1ypbn1HIuhd4IynWApn3K3LBQbYM+2m9FswfBmjamphQbU6Rf9ZZHe9 3Tzbde+AIXCoGkbOg/ihFlR0MNqfAD4rWiK31urJSokSaAcQhaJWhQKtW 6JLmauQqhV+EV0WBwqsWCNaA+VcrSuzQQWbxZauQQZXyj9tkHozKDtlAS BOTJBYax2D9us03eztBRqtIocrdsqUnzKCd2QyVy2viEHSEaLXYuHNcmR w==; From: Hans-Peter Nilsson To: Jonathan Wakely CC: , , In-Reply-To: (message from Jonathan Wakely on Wed, 6 Sep 2023 23:30:08 +0100) Subject: Re: [RFC] libstdc++: Make --enable-libstdcxx-backtrace=auto default to yes MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 8BIT References: <20230823160322.237140-1-jwakely@redhat.com> <20230904164617.F1DFA20427@pchp3.se.axis.com> Message-ID: <20230906230915.9A9EF2042A@pchp3.se.axis.com> Date: Thu, 7 Sep 2023 01:09:15 +0200 X-Spam-Status: No, score=-5.4 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: > From: Jonathan Wakely > Date: Wed, 6 Sep 2023 23:30:08 +0100 > On Mon, 4 Sept 2023 at 17:49, Jonathan Wakely wrote: > > > > On Mon, 4 Sept 2023 at 17:47, Hans-Peter Nilsson via Libstdc++ > > wrote: > > > > > > > Date: Fri, 1 Sep 2023 12:16:40 +0100 > > > > Reply-To: Jonathan Wakely > > > > > > > > On Wed, 23 Aug 2023 at 17:03, Jonathan Wakely via Libstdc++ > > > > wrote: > > > > > > > > > > Any objections to this? It's a C++23 feture, so should be enabled by > > > > > default. > > > > > > > > I've pushed this to trunk, so let's see what breaks! > > > > > > > > > > > > > > > > > > -- >8 -- > > > > > > > > > > This causes libstdc++_libbacktrace.a to be built by default. This might > > > > > fail on some targets, in which case we can make the 'auto' choice expand > > > > > to either 'yes' or 'no' depending on the target. > > > > > > > > > > libstdc++-v3/ChangeLog: > > > > > > > > > > * acinclude.m4 (GLIBCXX_ENABLE_BACKTRACE): Default to yes. > > > > > * configure: Regenerate. > > > > > > Incidentally, should check_effective_target_stacktrace in > > > libstdc++.exp also be adjusted to match; removing the > > > _GLIBCXX_HOSTED condition? > > > > No, it should still depend on is_hosted. The acinclude.m4 macro should > > check that. > > Done in r14-3761-g6de5f5a4fe85bd Aha, that's what you meant. I thought you meant that just check_effective_target_stacktrace should be gated on $is_hosted. Yeah, it makes sense not to have backtrace enabled by default for ! $is_hosted. On the other hand, bare-iron targets like cris-elf apparently *are* hosted, according to "#if __STDC_HOSTED__". I guess I'll have to dig into what the definition of "hosted" is, because I don't agree by the layman obvious definition. Maybe there's a bug to fix. There sure are many yaks to shave these days. brgds, H-P