From: Patrick Palka <ppalka@redhat.com>
To: gcc-patches@gcc.gnu.org
Cc: libstdc++@gcc.gnu.org, Patrick Palka <ppalka@redhat.com>
Subject: [PATCH 1/3] libstdc++: Remove std::bind_front specialization for no bound args
Date: Mon, 11 Sep 2023 21:08:50 -0400 [thread overview]
Message-ID: <20230912010852.1027184-1-ppalka@redhat.com> (raw)
This specialization for the case of no bound args, added by
r13-4214-gcbd05ca5ab1231, seems to be mostly obsoleted by
r13-5033-ge2eab3c4edb6aa which added [[no_unique_address]] to the
main template's data members. And the compile time advantage of
avoiding an empty tuple and index_sequence seems minimal. Removing this
specialization also means we don't have to fix the PR111327 bug in
another place.
PR libstdc++/111327
libstdc++-v3/ChangeLog:
* include/std/functional (_Bind_front0): Remove.
(_Bind_front_t): Adjust.
---
libstdc++-v3/include/std/functional | 63 +----------------------------
1 file changed, 1 insertion(+), 62 deletions(-)
diff --git a/libstdc++-v3/include/std/functional b/libstdc++-v3/include/std/functional
index 60d4d1f3dd2..7d1b890bb4e 100644
--- a/libstdc++-v3/include/std/functional
+++ b/libstdc++-v3/include/std/functional
@@ -996,69 +996,8 @@ _GLIBCXX_BEGIN_NAMESPACE_VERSION
[[no_unique_address]] std::tuple<_BoundArgs...> _M_bound_args;
};
- // Avoid the overhead of an empty tuple<> if there are no bound args.
- template<typename _Fd>
- struct _Bind_front0
- {
- static_assert(is_move_constructible_v<_Fd>);
-
- // First parameter is to ensure this constructor is never used
- // instead of the copy/move constructor.
- template<typename _Fn>
- explicit constexpr
- _Bind_front0(int, _Fn&& __fn)
- noexcept(is_nothrow_constructible_v<_Fd, _Fn>)
- : _M_fd(std::forward<_Fn>(__fn))
- { }
-
- _Bind_front0(const _Bind_front0&) = default;
- _Bind_front0(_Bind_front0&&) = default;
- _Bind_front0& operator=(const _Bind_front0&) = default;
- _Bind_front0& operator=(_Bind_front0&&) = default;
- ~_Bind_front0() = default;
-
- template<typename... _CallArgs>
- constexpr
- invoke_result_t<_Fd&, _CallArgs...>
- operator()(_CallArgs&&... __call_args) &
- noexcept(is_nothrow_invocable_v<_Fd&, _CallArgs...>)
- { return std::invoke(_M_fd, std::forward<_CallArgs>(__call_args)...); }
-
- template<typename... _CallArgs>
- constexpr
- invoke_result_t<const _Fd&, _CallArgs...>
- operator()(_CallArgs&&... __call_args) const &
- noexcept(is_nothrow_invocable_v<const _Fd&, _CallArgs...>)
- { return std::invoke(_M_fd, std::forward<_CallArgs>(__call_args)...); }
-
- template<typename... _CallArgs>
- constexpr
- invoke_result_t<_Fd, _CallArgs...>
- operator()(_CallArgs&&... __call_args) &&
- noexcept(is_nothrow_invocable_v<_Fd, _CallArgs...>)
- {
- return std::invoke(std::move(_M_fd),
- std::forward<_CallArgs>(__call_args)...);
- }
-
- template<typename... _CallArgs>
- constexpr
- invoke_result_t<const _Fd, _CallArgs...>
- operator()(_CallArgs&&... __call_args) const &&
- noexcept(is_nothrow_invocable_v<const _Fd, _CallArgs...>)
- {
- return std::invoke(std::move(_M_fd),
- std::forward<_CallArgs>(__call_args)...);
- }
-
- private:
- [[no_unique_address]] _Fd _M_fd;
- };
-
template<typename _Fn, typename... _Args>
- using _Bind_front_t
- = __conditional_t<sizeof...(_Args) == 0, _Bind_front0<decay_t<_Fn>>,
- _Bind_front<decay_t<_Fn>, decay_t<_Args>...>>;
+ using _Bind_front_t = _Bind_front<decay_t<_Fn>, decay_t<_Args>...>;
/** Create call wrapper by partial application of arguments to function.
*
--
2.42.0.158.g94e83dcf5b
next reply other threads:[~2023-09-12 1:08 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-12 1:08 Patrick Palka [this message]
2023-09-12 1:08 ` [PATCH 2/3] libstdc++: Fix std::bind_front perfect forwarding [PR111327] Patrick Palka
2023-09-12 13:16 ` Jonathan Wakely
2023-09-12 1:08 ` [PATCH 3/3] libstdc++: Fix std::not_fn " Patrick Palka
2023-09-12 13:16 ` Jonathan Wakely
2023-09-12 12:46 ` [PATCH 1/3] libstdc++: Remove std::bind_front specialization for no bound args Patrick Palka
2023-09-12 13:15 ` Jonathan Wakely
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230912010852.1027184-1-ppalka@redhat.com \
--to=ppalka@redhat.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=libstdc++@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).