From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx0b-00641c01.pphosted.com (mx0b-00641c01.pphosted.com [205.220.177.146]) by sourceware.org (Postfix) with ESMTPS id 920693858C56; Thu, 7 Dec 2023 05:15:50 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 920693858C56 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=gcc.gnu.org Authentication-Results: sourceware.org; spf=fail smtp.mailfrom=gcc.gnu.org ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 920693858C56 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=205.220.177.146 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1701926155; cv=none; b=fkanvAyCysRqCsOWVPSDs5m5QRlgkvALHafUKEoNISJmQCPaZ4z9KwEisNa7cnuuL63/P9XaOcIAO13tKgcybmk7vL64Yt6UyvrNsJiq/+UN9Zptw1ufhnE2HJ7yT3qF81VGkYKC62TiBtSq9ds8m13vFz1CesV8P1Pmup3pHtQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1701926155; c=relaxed/simple; bh=TnW1LW9fqFuYYcjhidPznaEiBWu5sVQ3mt0rB/i230A=; h=From:To:Subject:Date:Message-ID:MIME-Version; b=WsCnqb+YOnV4OYbZuWxJj5ePyu+XFq7TmuzQGFZAO8gKZz+QTAV7foh+Vz+pQ51bo6yIYUrWme64xU9oRUr07hvsEHsmOGUea3FogC9unE3dIB3f7luMb70MU39largfjr5R3/Axyw8q1znx4FUxY6eDpRKEPQx7hULqagO3ZL0= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from pps.filterd (m0247480.ppops.net [127.0.0.1]) by mx0a-00641c01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 3B7534Ol013520; Thu, 7 Dec 2023 05:15:50 GMT Received: from mxout22.s.uw.edu (mxout22.s.uw.edu [128.95.242.222]) by mx0a-00641c01.pphosted.com (PPS) with ESMTPS id 3uu17atvrj-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 07 Dec 2023 05:15:49 +0000 Received: from smtp.washington.edu (smtp.washington.edu [140.142.234.157]) by mxout22.s.uw.edu (8.14.4+UW20.07/8.14.4+UW22.04) with ESMTP id 3B75FHpM010550 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 6 Dec 2023 21:15:17 -0800 X-Auth-Received: from kmatsui-ThinkPad-X1-Carbon-Gen-9.dhcp4.washington.edu ([10.154.75.142]) (authenticated authid=kmatsui) by smtp.washington.edu (8.16.1+UW21.10/8.14.4+UW19.10) with ESMTPSA id 3B75FHQd024916 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 6 Dec 2023 21:15:17 -0800 X-UW-Orig-Sender: kmatsui@smtp.washington.edu From: Ken Matsui To: gcc-patches@gcc.gnu.org Cc: libstdc++@gcc.gnu.org, Ken Matsui Subject: [PATCH v26 00/23] Optimize type traits compilation performance Date: Wed, 6 Dec 2023 21:11:04 -0800 Message-ID: <20231207051513.969952-1-kmatsui@gcc.gnu.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20231024020424.699427-1-kmatsui@gcc.gnu.org> References: <20231024020424.699427-1-kmatsui@gcc.gnu.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Proofpoint-GUID: i0r_jLrJZOjKipuZDQBbKOWSpch30zAW X-Proofpoint-ORIG-GUID: i0r_jLrJZOjKipuZDQBbKOWSpch30zAW X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.272,Aquarius:18.0.997,Hydra:6.0.619,FMLib:17.11.176.26 definitions=2023-12-06_20,2023-12-06_01,2023-05-22_02 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 malwarescore=0 priorityscore=1501 clxscore=1034 suspectscore=0 bulkscore=0 spamscore=0 mlxscore=0 impostorscore=0 phishscore=0 adultscore=0 mlxlogscore=850 lowpriorityscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2311290000 definitions=main-2312060160 X-Spam-Status: No, score=-7.2 required=5.0 tests=BAYES_00,JMQ_SPF_NEUTRAL,KAM_DMARC_STATUS,RCVD_IN_DNSWL_LOW,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NEUTRAL,TXREP,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: This patch series optimizes type traits compilation performance by implementing built-in type traits and using them in libstdc++. Changes in v26: * Rebased on top of trunk. * Moved is_function_v under is_const_v. * Isolated patches for is_const, is_volatile, is_pointer, and is_unbounded_array, which contain performance regression, from this patch series since they are not ready for review yet. Changes in v25: * Optimized the __is_pointer implementation in cpp_type_traits.h. * Fix compilation error in cpp_type_traits.h with Clang 16. * Wrapped commit messages at 75 columns. * Used & instead of && for the new IDENTIFIER_TRAIT_P macro. * Made cp_lexer_peek_trait not to take cp_token. * Fixed indentation error in cp_lexer_peek_trait. Changes in v24: * Fixed the way to handle an incomplete type error from __is_invocable in the test cases so that we can correctly test both the use of built-in and vice-versa. Changes in v23: * Improved the comment in cp-tree.h. * Moved the definition of cp_traits to lex.cc from parser.cc. * Implemented __is_invocable built-in trait. Changes in v22: * Included a missing patch in v21. Changes in v21: * Used _GLIBCXX_USE_BUILTIN_TRAIT instead of __has_builtin in cpp_type_traits.h. * Added const char* name to struct cp_trait, and loop over cp_traits in init_cp_traits to get the name. * Isolated patches for integral-related built-in traits from this patch series since they are not ready for review yet. * Implemented __is_object built-in trait. Changes in v20: * Used identifier node instead of gperf to look up built-in traits. Changes in v19: * Fixed a typo. * Rebased on top of trunk. * Improved clarity of the commit message. Changes in v18: * Removed all RID values for built-in traits and used cik_trait instead. * Improved to handle the use of non-function-like built-in trait identifiers. * Reverted all changes to conflicted identifiers with new built-ins in the existing code base. Changes in v17: * Rebased on top of trunk. * Improved clarity of the commit message. * Simplified Make-lang.in. * Made ridpointers for RID_TRAIT_EXPR and RID_TRAIT_TYPE empty. Changes in v16: * Rebased on top of trunk. * Improved clarity of the commit message. * Simplified Make-lang.in and gperf struct. * Supply -k option to gperf to support older versions than 2.8. Changes in v15: * Rebased on top of trunk. * Use gperf to look up traits instead of enum rid. Changes in v14: * Added padding calculation to the commit message. Changes in v13: * Fixed ambiguous commit message and comment. Changes in v12: * Evaluated all paddings affected by the enum rid change. Changes in v11: * Merged all patches into one patch series. * Rebased on top of trunk. * Unified commit message style. * Used _GLIBCXX_USE_BUILTIN_TRAIT. Ken Matsui (23): c++: Sort built-in traits alphabetically c-family, c++: Look up built-in traits via identifier node c++: Accept the use of built-in trait identifiers c++: Implement __is_array built-in trait libstdc++: Optimize std::is_array compilation performance c++: Implement __is_bounded_array built-in trait libstdc++: Optimize std::is_bounded_array compilation performance c++: Implement __is_scoped_enum built-in trait libstdc++: Optimize std::is_scoped_enum compilation performance c++: Implement __is_member_pointer built-in trait libstdc++: Optimize std::is_member_pointer compilation performance c++: Implement __is_member_function_pointer built-in trait libstdc++: Optimize std::is_member_function_pointer compilation performance c++: Implement __is_member_object_pointer built-in trait libstdc++: Optimize std::is_member_object_pointer compilation performance c++: Implement __is_reference built-in trait libstdc++: Optimize std::is_reference compilation performance c++: Implement __is_function built-in trait libstdc++: Optimize std::is_function compilation performance c++: Implement __is_object built-in trait libstdc++: Optimize std::is_object compilation performance c++: Implement __remove_pointer built-in trait libstdc++: Optimize std::remove_pointer compilation performance gcc/c-family/c-common.cc | 7 - gcc/c-family/c-common.h | 5 - gcc/cp/constraint.cc | 95 +++++++----- gcc/cp/cp-objcp-common.cc | 8 +- gcc/cp/cp-trait.def | 20 ++- gcc/cp/cp-tree.h | 32 +++-- gcc/cp/lex.cc | 34 +++++ gcc/cp/parser.cc | 120 ++++++++++------ gcc/cp/semantics.cc | 135 ++++++++++++------ gcc/testsuite/g++.dg/ext/has-builtin-1.C | 100 ++++++++----- gcc/testsuite/g++.dg/ext/is_array.C | 28 ++++ gcc/testsuite/g++.dg/ext/is_bounded_array.C | 38 +++++ gcc/testsuite/g++.dg/ext/is_function.C | 58 ++++++++ .../g++.dg/ext/is_member_function_pointer.C | 31 ++++ .../g++.dg/ext/is_member_object_pointer.C | 30 ++++ gcc/testsuite/g++.dg/ext/is_member_pointer.C | 30 ++++ gcc/testsuite/g++.dg/ext/is_object.C | 29 ++++ gcc/testsuite/g++.dg/ext/is_reference.C | 34 +++++ gcc/testsuite/g++.dg/ext/is_scoped_enum.C | 67 +++++++++ gcc/testsuite/g++.dg/ext/remove_pointer.C | 51 +++++++ libstdc++-v3/include/std/type_traits | 135 +++++++++++++++++- 21 files changed, 898 insertions(+), 189 deletions(-) create mode 100644 gcc/testsuite/g++.dg/ext/is_array.C create mode 100644 gcc/testsuite/g++.dg/ext/is_bounded_array.C create mode 100644 gcc/testsuite/g++.dg/ext/is_function.C create mode 100644 gcc/testsuite/g++.dg/ext/is_member_function_pointer.C create mode 100644 gcc/testsuite/g++.dg/ext/is_member_object_pointer.C create mode 100644 gcc/testsuite/g++.dg/ext/is_member_pointer.C create mode 100644 gcc/testsuite/g++.dg/ext/is_object.C create mode 100644 gcc/testsuite/g++.dg/ext/is_reference.C create mode 100644 gcc/testsuite/g++.dg/ext/is_scoped_enum.C create mode 100644 gcc/testsuite/g++.dg/ext/remove_pointer.C -- 2.43.0