From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx0a-00641c01.pphosted.com (mx0a-00641c01.pphosted.com [205.220.165.146]) by sourceware.org (Postfix) with ESMTPS id B1AA9385840A; Thu, 2 May 2024 16:16:33 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org B1AA9385840A Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=gcc.gnu.org Authentication-Results: sourceware.org; spf=fail smtp.mailfrom=gcc.gnu.org ARC-Filter: OpenARC Filter v1.0.0 sourceware.org B1AA9385840A Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=205.220.165.146 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1714666597; cv=none; b=NJ6Hcbfq8srSWkYBNgdxMQebFfHIHl3M6X9nXDICBLKbcqwWyjGTJURC2rF6R9WEYpiEBX+DgQwiXx5GvBevhEhsVPYodpWU3K6X3BXrV8juR8QQ7Wm4ACqDx64AGS/XuQyxPB5ols6XA8ldMiIZQDUv4dxdXIzVQFwUD0eEKxg= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1714666597; c=relaxed/simple; bh=/WXKRZPJPj5TjFNjP2pz6Ipq4+0rSugKmLH4fBMsYKI=; h=From:To:Subject:Date:Message-ID:MIME-Version; b=ghX8b8xXeGgdeAQAlwoiYW3HNgBbH4Ocxe4gSZX/ZcuDw5KsIxQwu3HEfYJWxqKFdkNNjJ1AZl2oLRCnm93G3KJ+PzDeVoAYYuPHVzEGw6oWrZCF0NLsJsa+dYWY0jhRsaXbadqL9cggmMjYolYQlcuieQfmBfpHSeb+SC+V9RQ= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from pps.filterd (m0247473.ppops.net [127.0.0.1]) by mx0a-00641c01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 442GBmmP017725; Thu, 2 May 2024 16:16:32 GMT Received: from mxout22.s.uw.edu (mxout22.s.uw.edu [128.95.242.222]) by mx0a-00641c01.pphosted.com (PPS) with ESMTPS id 3xv4e2bp6w-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 02 May 2024 16:16:32 +0000 (GMT) Received: from smtp.washington.edu (smtp.washington.edu [128.208.60.54]) by mxout22.s.uw.edu (8.14.4+UW20.07/8.14.4+UW24.02) with ESMTP id 442GGGxv003505 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 2 May 2024 09:16:16 -0700 X-Auth-Received: from ken-20xw00qgus.dhcp4.washington.edu ([10.154.75.239]) (authenticated authid=kmatsui) by smtp.washington.edu (8.16.1+UW21.10/8.14.4+UW24.02) with ESMTPSA id 442GGFok023119 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 2 May 2024 09:16:16 -0700 X-UW-Orig-Sender: kmatsui@smtp.washington.edu From: Ken Matsui To: gcc-patches@gcc.gnu.org Cc: libstdc++@gcc.gnu.org, jason@redhat.com, Ken Matsui Subject: [PATCH v16 07/26] c++: Implement __builtin_is_unbounded_array trait Date: Thu, 2 May 2024 09:13:33 -0700 Message-ID: <20240502161614.3705912-8-kmatsui@gcc.gnu.org> X-Mailer: git-send-email 2.44.0 In-Reply-To: <20240502161614.3705912-1-kmatsui@gcc.gnu.org> References: <20240228192843.188979-1-kmatsui@gcc.gnu.org> <20240502161614.3705912-1-kmatsui@gcc.gnu.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Proofpoint-GUID: 01opouMX0wwMXBUwYWG101RhEK3qmeO9 X-Proofpoint-ORIG-GUID: 01opouMX0wwMXBUwYWG101RhEK3qmeO9 X-outbound-smtp: 1 x-header: uw-relay-non-domains X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1011,Hydra:6.0.650,FMLib:17.11.176.26 definitions=2024-05-02_08,2024-05-02_03,2023-05-22_02 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 mlxscore=0 malwarescore=0 lowpriorityscore=0 spamscore=0 suspectscore=0 clxscore=1034 mlxlogscore=622 adultscore=0 impostorscore=0 phishscore=0 priorityscore=1501 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.19.0-2404010003 definitions=main-2405020106 X-Spam-Status: No, score=-12.9 required=5.0 tests=BAYES_00,GIT_PATCH_0,JMQ_SPF_NEUTRAL,KAM_DMARC_STATUS,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NEUTRAL,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: This patch implements built-in trait for std::is_unbounded_array. gcc/cp/ChangeLog: * cp-trait.def: Define __builtin_is_unbounded_array. * constraint.cc (diagnose_trait_expr): Handle CPTK_IS_UNBOUNDED_ARRAY. * semantics.cc (trait_expr_value): Likewise. (finish_trait_expr): Likewise. gcc/testsuite/ChangeLog: * g++.dg/ext/has-builtin-1.C: Test existence of __builtin_is_unbounded_array. * g++.dg/ext/is_unbounded_array.C: New test. Signed-off-by: Ken Matsui --- gcc/cp/constraint.cc | 3 ++ gcc/cp/cp-trait.def | 1 + gcc/cp/semantics.cc | 4 ++ gcc/testsuite/g++.dg/ext/has-builtin-1.C | 3 ++ gcc/testsuite/g++.dg/ext/is_unbounded_array.C | 37 +++++++++++++++++++ 5 files changed, 48 insertions(+) create mode 100644 gcc/testsuite/g++.dg/ext/is_unbounded_array.C diff --git a/gcc/cp/constraint.cc b/gcc/cp/constraint.cc index 5a8aaa70fa6..d4cc8850486 100644 --- a/gcc/cp/constraint.cc +++ b/gcc/cp/constraint.cc @@ -3862,6 +3862,9 @@ diagnose_trait_expr (tree expr, tree args) case CPTK_IS_TRIVIALLY_COPYABLE: inform (loc, " %qT is not trivially copyable", t1); break; + case CPTK_IS_UNBOUNDED_ARRAY: + inform (loc, " %qT is not an unbounded array", t1); + break; case CPTK_IS_UNION: inform (loc, " %qT is not a union", t1); break; diff --git a/gcc/cp/cp-trait.def b/gcc/cp/cp-trait.def index a6a3c195529..7a3cbbebde6 100644 --- a/gcc/cp/cp-trait.def +++ b/gcc/cp/cp-trait.def @@ -92,6 +92,7 @@ DEFTRAIT_EXPR (IS_TRIVIAL, "__is_trivial", 1) DEFTRAIT_EXPR (IS_TRIVIALLY_ASSIGNABLE, "__is_trivially_assignable", 2) DEFTRAIT_EXPR (IS_TRIVIALLY_CONSTRUCTIBLE, "__is_trivially_constructible", -1) DEFTRAIT_EXPR (IS_TRIVIALLY_COPYABLE, "__is_trivially_copyable", 1) +DEFTRAIT_EXPR (IS_UNBOUNDED_ARRAY, "__builtin_is_unbounded_array", 1) DEFTRAIT_EXPR (IS_UNION, "__is_union", 1) DEFTRAIT_EXPR (IS_VOLATILE, "__builtin_is_volatile", 1) DEFTRAIT_EXPR (REF_CONSTRUCTS_FROM_TEMPORARY, "__reference_constructs_from_temporary", 2) diff --git a/gcc/cp/semantics.cc b/gcc/cp/semantics.cc index 86372ea0aba..138b180d9fb 100644 --- a/gcc/cp/semantics.cc +++ b/gcc/cp/semantics.cc @@ -12616,6 +12616,9 @@ trait_expr_value (cp_trait_kind kind, tree type1, tree type2) case CPTK_IS_TRIVIALLY_COPYABLE: return trivially_copyable_p (type1); + case CPTK_IS_UNBOUNDED_ARRAY: + return array_of_unknown_bound_p (type1); + case CPTK_IS_UNION: return type_code1 == UNION_TYPE; @@ -12832,6 +12835,7 @@ finish_trait_expr (location_t loc, cp_trait_kind kind, tree type1, tree type2) case CPTK_IS_REFERENCE: case CPTK_IS_SAME: case CPTK_IS_SCOPED_ENUM: + case CPTK_IS_UNBOUNDED_ARRAY: case CPTK_IS_UNION: case CPTK_IS_VOLATILE: break; diff --git a/gcc/testsuite/g++.dg/ext/has-builtin-1.C b/gcc/testsuite/g++.dg/ext/has-builtin-1.C index 7954b42df97..7eb341a8068 100644 --- a/gcc/testsuite/g++.dg/ext/has-builtin-1.C +++ b/gcc/testsuite/g++.dg/ext/has-builtin-1.C @@ -23,6 +23,9 @@ #if !__has_builtin (__builtin_is_pointer_interconvertible_with_class) # error "__has_builtin (__builtin_is_pointer_interconvertible_with_class) failed" #endif +#if !__has_builtin (__builtin_is_unbounded_array) +# error "__has_builtin (__builtin_is_unbounded_array) failed" +#endif #if !__has_builtin (__builtin_is_volatile) # error "__has_builtin (__builtin_is_volatile) failed" #endif diff --git a/gcc/testsuite/g++.dg/ext/is_unbounded_array.C b/gcc/testsuite/g++.dg/ext/is_unbounded_array.C new file mode 100644 index 00000000000..ac593b99aa7 --- /dev/null +++ b/gcc/testsuite/g++.dg/ext/is_unbounded_array.C @@ -0,0 +1,37 @@ +// { dg-do compile { target c++11 } } + +#define SA(X) static_assert((X),#X) + +#define SA_TEST_CATEGORY(TRAIT, TYPE, EXPECT) \ + SA(TRAIT(TYPE) == EXPECT); \ + SA(TRAIT(const TYPE) == EXPECT); \ + SA(TRAIT(volatile TYPE) == EXPECT); \ + SA(TRAIT(const volatile TYPE) == EXPECT) + +class ClassType { }; +class IncompleteClass; +union IncompleteUnion; + +SA_TEST_CATEGORY(__builtin_is_unbounded_array, int[2], false); +SA_TEST_CATEGORY(__builtin_is_unbounded_array, int[], true); +SA_TEST_CATEGORY(__builtin_is_unbounded_array, int[2][3], false); +SA_TEST_CATEGORY(__builtin_is_unbounded_array, int[][3], true); +SA_TEST_CATEGORY(__builtin_is_unbounded_array, float*[2], false); +SA_TEST_CATEGORY(__builtin_is_unbounded_array, float*[], true); +SA_TEST_CATEGORY(__builtin_is_unbounded_array, float*[2][3], false); +SA_TEST_CATEGORY(__builtin_is_unbounded_array, float*[][3], true); +SA_TEST_CATEGORY(__builtin_is_unbounded_array, ClassType[2], false); +SA_TEST_CATEGORY(__builtin_is_unbounded_array, ClassType[], true); +SA_TEST_CATEGORY(__builtin_is_unbounded_array, ClassType[2][3], false); +SA_TEST_CATEGORY(__builtin_is_unbounded_array, ClassType[][3], true); +SA_TEST_CATEGORY(__builtin_is_unbounded_array, IncompleteClass[2][3], false); +SA_TEST_CATEGORY(__builtin_is_unbounded_array, IncompleteClass[][3], true); +SA_TEST_CATEGORY(__builtin_is_unbounded_array, int(*)[2], false); +SA_TEST_CATEGORY(__builtin_is_unbounded_array, int(*)[], false); +SA_TEST_CATEGORY(__builtin_is_unbounded_array, int(&)[2], false); +SA_TEST_CATEGORY(__builtin_is_unbounded_array, int(&)[], false); + +// Sanity check. +SA_TEST_CATEGORY(__builtin_is_unbounded_array, ClassType, false); +SA_TEST_CATEGORY(__builtin_is_unbounded_array, IncompleteClass, false); +SA_TEST_CATEGORY(__builtin_is_unbounded_array, IncompleteUnion, false); -- 2.44.0