From: "François Dumont" <frs.dumont@gmail.com>
To: "Daniel Krügler" <daniel.kruegler@gmail.com>
Cc: "libstdc++@gcc.gnu.org" <libstdc++@gcc.gnu.org>,
gcc-patches <gcc-patches@gcc.gnu.org>
Subject: Re: [PATCH][Hashtable 6/6] PR 68303 small size optimization
Date: Tue, 21 Dec 2021 18:55:31 +0100 [thread overview]
Message-ID: <22461d18-d2a0-d906-4b20-6b95cf036bde@gmail.com> (raw)
In-Reply-To: <CAGNvRgCrQubXyqzuL6NtsHegcvHgugTUAhhWb+A2qZrCLXuLyw@mail.gmail.com>
On 21/12/21 7:28 am, Daniel Krügler wrote:
> Am Di., 21. Dez. 2021 um 07:08 Uhr schrieb François Dumont via
> Libstdc++ <libstdc++@gcc.gnu.org>:
>> Hi
>>
>> Is there a chance for this patch to be integrated for next gcc
>> release ?
>>
>> François
>>
> No counterargument for the acceptance, but: Shouldn't
> __small_size_threshold() be a noexcept function?
>
> - Daniel
Could it enhance code generation ? I could make it depends on
_Hashtable_hash_traits<>::__small_size_threshold() noexcept
qualification if so. But I was hoping that the compiler to detect all
that itself.
Otherwise no, it do not have to be noexcept as it is used to avoid
hasher invocation in some situations and hasher is not noexcept
constraint. At least I do not need to static_assert this.
next prev parent reply other threads:[~2021-12-21 17:55 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-17 21:31 François Dumont
2020-07-17 12:58 ` Jonathan Wakely
2021-08-16 19:03 ` François Dumont
2021-09-23 4:36 ` François Dumont
2021-12-21 6:07 ` François Dumont
2021-12-21 6:28 ` Daniel Krügler
2021-12-21 17:55 ` François Dumont [this message]
2021-12-23 12:43 ` Jonathan Wakely
[not found] ` <YcRzoSSc534Lg+/F@redhat.com>
2021-12-25 21:39 ` François Dumont
2022-01-05 17:07 ` Jonathan Wakely
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=22461d18-d2a0-d906-4b20-6b95cf036bde@gmail.com \
--to=frs.dumont@gmail.com \
--cc=daniel.kruegler@gmail.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=libstdc++@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).