From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id 180B83858D38 for ; Tue, 30 Apr 2024 20:59:55 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 180B83858D38 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 180B83858D38 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=170.10.129.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1714510796; cv=none; b=WidazTtsUvIhUs/xFdPpvrFmeHMW7KwBQdgEVcEcqbzi9IwlgXfXjS1LmJ5i787oG/scnTrjNPnxfSunXyGrBsyn3Izj1cnr8I34fZ0hrzeraxD7SNR3bMLPUKQdY5nab6pa0Ir23hi66dB81eUWQWw/ozT+N7D6AdA1OAZXxi4= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1714510796; c=relaxed/simple; bh=PHaFj0oQP8N5OV+ef7x8ASUpRw72aNPjaVKSpd7+Lt8=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=q6QyDF6byzPLmjVpbWu2b3vqt+6+Y+YhYCc4MX7/6dZU2QQyTCmaLte+Nfq/PW1ChN1sJwaDQ6kAcRu14+1sOT94XKdG7mZvq8aBQYBXOq+DyF54uirM3w+nx5tbvhr2rj7lDYCj4TNdqYQs9hszI1iZXrPqflsOC3803aP/Jw8= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1714510794; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=AyAvvWMyGNWrxPU78WrKrLj24ijSxP5BJ/4Aoyy8fbY=; b=K9ZwOEKuLDMjWvOt+orbMCBApClT1tj6bBw5eKWfQQC+4PgCjCpEqTbj/KlN0vjKyyTiSG 8gionH6fHusqe01dH7x7sO5Jj8iGG0FJdss4RcR2pJfdJOBm4C0odk3+jdeMejqFh9BUPR B701iKFEcPawR3A8tsaGGv0VlX0imKk= Received: from mail-qk1-f200.google.com (mail-qk1-f200.google.com [209.85.222.200]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-257--VViWidDO9yJELVFMKbehg-1; Tue, 30 Apr 2024 16:59:53 -0400 X-MC-Unique: -VViWidDO9yJELVFMKbehg-1 Received: by mail-qk1-f200.google.com with SMTP id af79cd13be357-790f793e1d9so40603785a.0 for ; Tue, 30 Apr 2024 13:59:53 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1714510792; x=1715115592; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=AyAvvWMyGNWrxPU78WrKrLj24ijSxP5BJ/4Aoyy8fbY=; b=ZJbDZ4VM4+hOuCcUWj9kVFg9c+fzob5SZH4YSGIbjcXAKwX6KcNwd+txlLF5256uOI DaLqd3sAfrqALUqsEDt+7Htk56v2KJxloEitA4I2+QOSWfDZnh446BQgXzeh+D6f5rlV uXYvzZ6ojv2lewFB0nXdteI8rMzrXF0s/XuSeAAOBT0w7K7iJiVKHOYMWqDazSH3F9Uv WcWc7C5puVrwHnsBHvaCj4E57vIoswR3B+UjS74i2SEatW9aZXvGd5C7Ki52n+OtwHjz hj4wrOEMuxHeE5rWV61YK4789GzEf7ZYO0hngLI4ROGecwsaDiOPq3XHjLM+sPvK+0UU ccFw== X-Gm-Message-State: AOJu0Yw1Z6B8Aj5fJvd1S589tVlYOUnLp6IjmFudocmKM4oG9j1F99lb c1POufxWU2WsKXjzoO0erZ6L6Dtcz866mNokOt+vshsWPi638cx6wf/Lq6VGNE4ocCjhVsTcBIQ qMxDmu5K5ld2bSgZAMvY9z5Z3feZn+YCcmh7eiMWGSxOCv+Pd8VaBI6T5grk/ X-Received: by 2002:a05:620a:d8d:b0:790:ee01:ee37 with SMTP id q13-20020a05620a0d8d00b00790ee01ee37mr6080833qkl.28.1714510792327; Tue, 30 Apr 2024 13:59:52 -0700 (PDT) X-Google-Smtp-Source: AGHT+IESbURgXil4wuFRGCbCJW8Qjqwni8x2TUdhkLIdFXLmAxhhHH8as5FYm7zrLx+nl3z5CswCkg== X-Received: by 2002:a05:620a:d8d:b0:790:ee01:ee37 with SMTP id q13-20020a05620a0d8d00b00790ee01ee37mr6080808qkl.28.1714510791999; Tue, 30 Apr 2024 13:59:51 -0700 (PDT) Received: from [192.168.1.130] (130-44-146-16.s12558.c3-0.arl-cbr1.sbo-arl.ma.cable.rcncustomer.com. [130.44.146.16]) by smtp.gmail.com with ESMTPSA id i19-20020a05620a0a1300b00790f72d03c7sm2028472qka.126.2024.04.30.13.59.51 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 30 Apr 2024 13:59:51 -0700 (PDT) Message-ID: <25c2cef8-d800-4e3a-b58f-3322ce64671e@redhat.com> Date: Tue, 30 Apr 2024 16:59:50 -0400 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v14 11/26] c++: Implement __remove_extent built-in trait To: Ken Matsui , gcc-patches@gcc.gnu.org Cc: libstdc++@gcc.gnu.org References: <20240221093616.4001742-1-kmatsui@gcc.gnu.org> <20240228192843.188979-1-kmatsui@gcc.gnu.org> <20240228192843.188979-12-kmatsui@gcc.gnu.org> From: Jason Merrill In-Reply-To: <20240228192843.188979-12-kmatsui@gcc.gnu.org> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-12.7 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H4,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 2/28/24 11:26, Ken Matsui wrote: > This patch implements built-in trait for std::remove_extent. OK. > gcc/cp/ChangeLog: > > * cp-trait.def: Define __remove_extent. > * semantics.cc (finish_trait_type): Handle CPTK_REMOVE_EXTENT. > > gcc/testsuite/ChangeLog: > > * g++.dg/ext/has-builtin-1.C: Test existence of __remove_extent. > * g++.dg/ext/remove_extent.C: New test. > > Signed-off-by: Ken Matsui > --- > gcc/cp/cp-trait.def | 1 + > gcc/cp/semantics.cc | 5 +++++ > gcc/testsuite/g++.dg/ext/has-builtin-1.C | 3 +++ > gcc/testsuite/g++.dg/ext/remove_extent.C | 16 ++++++++++++++++ > 4 files changed, 25 insertions(+) > create mode 100644 gcc/testsuite/g++.dg/ext/remove_extent.C > > diff --git a/gcc/cp/cp-trait.def b/gcc/cp/cp-trait.def > index 63f879287ce..577c96d579b 100644 > --- a/gcc/cp/cp-trait.def > +++ b/gcc/cp/cp-trait.def > @@ -100,6 +100,7 @@ DEFTRAIT_EXPR (REF_CONSTRUCTS_FROM_TEMPORARY, "__reference_constructs_from_tempo > DEFTRAIT_EXPR (REF_CONVERTS_FROM_TEMPORARY, "__reference_converts_from_temporary", 2) > DEFTRAIT_TYPE (REMOVE_CV, "__remove_cv", 1) > DEFTRAIT_TYPE (REMOVE_CVREF, "__remove_cvref", 1) > +DEFTRAIT_TYPE (REMOVE_EXTENT, "__remove_extent", 1) > DEFTRAIT_TYPE (REMOVE_POINTER, "__remove_pointer", 1) > DEFTRAIT_TYPE (REMOVE_REFERENCE, "__remove_reference", 1) > DEFTRAIT_TYPE (TYPE_PACK_ELEMENT, "__type_pack_element", -1) > diff --git a/gcc/cp/semantics.cc b/gcc/cp/semantics.cc > index 635441a7a90..58696225fc4 100644 > --- a/gcc/cp/semantics.cc > +++ b/gcc/cp/semantics.cc > @@ -12793,6 +12793,11 @@ finish_trait_type (cp_trait_kind kind, tree type1, tree type2, > type1 = TREE_TYPE (type1); > return cv_unqualified (type1); > > + case CPTK_REMOVE_EXTENT: > + if (TREE_CODE (type1) == ARRAY_TYPE) > + type1 = TREE_TYPE (type1); > + return type1; > + > case CPTK_REMOVE_POINTER: > if (TYPE_PTR_P (type1)) > type1 = TREE_TYPE (type1); > diff --git a/gcc/testsuite/g++.dg/ext/has-builtin-1.C b/gcc/testsuite/g++.dg/ext/has-builtin-1.C > index 9d861398bae..5d5cbe3b019 100644 > --- a/gcc/testsuite/g++.dg/ext/has-builtin-1.C > +++ b/gcc/testsuite/g++.dg/ext/has-builtin-1.C > @@ -182,6 +182,9 @@ > #if !__has_builtin (__remove_cvref) > # error "__has_builtin (__remove_cvref) failed" > #endif > +#if !__has_builtin (__remove_extent) > +# error "__has_builtin (__remove_extent) failed" > +#endif > #if !__has_builtin (__remove_pointer) > # error "__has_builtin (__remove_pointer) failed" > #endif > diff --git a/gcc/testsuite/g++.dg/ext/remove_extent.C b/gcc/testsuite/g++.dg/ext/remove_extent.C > new file mode 100644 > index 00000000000..6183aca5a48 > --- /dev/null > +++ b/gcc/testsuite/g++.dg/ext/remove_extent.C > @@ -0,0 +1,16 @@ > +// { dg-do compile { target c++11 } } > + > +#define SA(X) static_assert((X),#X) > + > +class ClassType { }; > + > +SA(__is_same(__remove_extent(int), int)); > +SA(__is_same(__remove_extent(int[2]), int)); > +SA(__is_same(__remove_extent(int[2][3]), int[3])); > +SA(__is_same(__remove_extent(int[][3]), int[3])); > +SA(__is_same(__remove_extent(const int[2]), const int)); > +SA(__is_same(__remove_extent(ClassType), ClassType)); > +SA(__is_same(__remove_extent(ClassType[2]), ClassType)); > +SA(__is_same(__remove_extent(ClassType[2][3]), ClassType[3])); > +SA(__is_same(__remove_extent(ClassType[][3]), ClassType[3])); > +SA(__is_same(__remove_extent(const ClassType[2]), const ClassType));