From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id E3F043858C5F for ; Tue, 30 Apr 2024 21:03:26 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org E3F043858C5F Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org E3F043858C5F Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=170.10.129.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1714511008; cv=none; b=XMzi5elu489RVoUH5StPlTbb2oHzAJb498YjXtx1WgrU/TDaOqPD2UbKJU0z8ZHdrSe+18yF6TeBlCdGiwuiww/3RkMza3xVti1ft0Yq+xzpmom43auXBRCOrXF2rbkuARn7itpBpoMUSmQ4x1ct0YEOfzVlyOiHIeDiSPmp9xs= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1714511008; c=relaxed/simple; bh=l/CzJbjBxkMgb2Q+5u2AO4xO9qIRGBXA4t3nTA6rv9E=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=sni7HdbjJ0tpiq1ObrjUEUXnr2sqrGWDcIfHNTcAoeT0y4kM6KqRFyDMdDwOuPDo6rTTYZVLHgyB+VmlRO44RXUNW56xgIq46fP8oEgfx2pnRR9iGj8a3y6H6z+2pCwqX9KJEzEdA0cpWCxwfEsMZFXD6MJ6jlNGn3FYTT79M18= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1714511006; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=S9FtqVbCvaJhixQ6YKJQWE8wLizaOi8BQS13EbJJ6G8=; b=HVuxcWffJoMsDuOHI1gKYcIyC9UTucqaxn1oJx5Pn287NBCmTFj2QS+VQXAOpmh0gwHsHc gyC6/Skd/j63BFFjNrlCrfgnBXQdtSdfzEgPz5lqhHQyuhnn2oP2HLyjnhrf7GxCE8/WMe StDtI46YbYASxf7wGasvv4Ug6z0LHtE= Received: from mail-qk1-f197.google.com (mail-qk1-f197.google.com [209.85.222.197]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-439-2J6O9u8iOl-7lzbT1vpoxA-1; Tue, 30 Apr 2024 17:03:25 -0400 X-MC-Unique: 2J6O9u8iOl-7lzbT1vpoxA-1 Received: by mail-qk1-f197.google.com with SMTP id af79cd13be357-7906f4fc84bso941957285a.2 for ; Tue, 30 Apr 2024 14:03:25 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1714511004; x=1715115804; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=S9FtqVbCvaJhixQ6YKJQWE8wLizaOi8BQS13EbJJ6G8=; b=mvFhBl/ivuwo2WqBHzQEP+K3uPSNZUZeePiyyNSPCiS75Xg+ij6bpY3pEIvQTDCvlB S4pbHuNIwwfc5OMVTjUjb4yt0pS+d7/uS3YRboulbrtQMmT4vH3EAXZBomHMWwfUh0lZ rForA1kfo9l/ns0zWiE6T754uD8pXzLY8D10gISvBYQMRX/vujQkpCTAHMcn9pVxyqcA mrqdUmIQNT8Zxpgd5B5vbJ2OD6bqAPpGyFwqSo6fc9ok5JjLCCQLifNVN0obh4gUhdZZ c4ExVyiSj4en7hMxy5VrWd414uGXuY1cn3CZQu33bVPoL4gi6vI+XneQ3KUFbQIqXZri EZ3Q== X-Gm-Message-State: AOJu0YwV+8t7Y3ghji+9HdaZxWI9CdY6deahV6BRKH4QLBoTxcMMbFY8 2i/UbrqlV07cWj2VTKEoqDLmnBwDWKsJSx6n7MRDArggDoFJhLNMSaUh9+WKevgUgGZnzPwe8Fh wHmCfzxbAW4n+K+lYcYuzVWodp3z9e8wkm/8RVSWD53k4ddnbTAlM X-Received: by 2002:a05:620a:70d5:b0:790:fbaa:6c1d with SMTP id vk21-20020a05620a70d500b00790fbaa6c1dmr484153qkn.24.1714511004660; Tue, 30 Apr 2024 14:03:24 -0700 (PDT) X-Google-Smtp-Source: AGHT+IH72IPSYif1GkSR8utOOpexiKiHY5YpiVI/FOey3ZI9xulRa4FW8l9zmprlLBHN30sqc2TsrQ== X-Received: by 2002:a05:620a:70d5:b0:790:fbaa:6c1d with SMTP id vk21-20020a05620a70d500b00790fbaa6c1dmr484139qkn.24.1714511004372; Tue, 30 Apr 2024 14:03:24 -0700 (PDT) Received: from [192.168.1.130] (130-44-146-16.s12558.c3-0.arl-cbr1.sbo-arl.ma.cable.rcncustomer.com. [130.44.146.16]) by smtp.gmail.com with ESMTPSA id q6-20020a05620a0c8600b007907d4bbeccsm7594142qki.43.2024.04.30.14.03.23 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 30 Apr 2024 14:03:23 -0700 (PDT) Message-ID: <278430a0-1026-43b6-98a4-c66b9b5b1753@redhat.com> Date: Tue, 30 Apr 2024 17:03:23 -0400 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v14 19/26] c++: Implement __decay built-in trait To: Ken Matsui , gcc-patches@gcc.gnu.org Cc: libstdc++@gcc.gnu.org References: <20240221093616.4001742-1-kmatsui@gcc.gnu.org> <20240228192843.188979-1-kmatsui@gcc.gnu.org> <20240228192843.188979-20-kmatsui@gcc.gnu.org> From: Jason Merrill In-Reply-To: <20240228192843.188979-20-kmatsui@gcc.gnu.org> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-12.7 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H4,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 2/28/24 11:26, Ken Matsui wrote: > This patch implements built-in trait for std::decay. OK. > gcc/cp/ChangeLog: > > * cp-trait.def: Define __decay. > * semantics.cc (finish_trait_type): Handle CPTK_DECAY. > > gcc/testsuite/ChangeLog: > > * g++.dg/ext/has-builtin-1.C: Test existence of __decay. > * g++.dg/ext/decay.C: New test. > > Signed-off-by: Ken Matsui > --- > gcc/cp/cp-trait.def | 1 + > gcc/cp/semantics.cc | 12 ++++++++++++ > gcc/testsuite/g++.dg/ext/decay.C | 22 ++++++++++++++++++++++ > gcc/testsuite/g++.dg/ext/has-builtin-1.C | 3 +++ > 4 files changed, 38 insertions(+) > create mode 100644 gcc/testsuite/g++.dg/ext/decay.C > > diff --git a/gcc/cp/cp-trait.def b/gcc/cp/cp-trait.def > index 173818adf79..2d1cb7c227c 100644 > --- a/gcc/cp/cp-trait.def > +++ b/gcc/cp/cp-trait.def > @@ -51,6 +51,7 @@ > DEFTRAIT_TYPE (ADD_LVALUE_REFERENCE, "__add_lvalue_reference", 1) > DEFTRAIT_TYPE (ADD_POINTER, "__add_pointer", 1) > DEFTRAIT_TYPE (ADD_RVALUE_REFERENCE, "__add_rvalue_reference", 1) > +DEFTRAIT_TYPE (DECAY, "__decay", 1) > DEFTRAIT_EXPR (HAS_NOTHROW_ASSIGN, "__has_nothrow_assign", 1) > DEFTRAIT_EXPR (HAS_NOTHROW_CONSTRUCTOR, "__has_nothrow_constructor", 1) > DEFTRAIT_EXPR (HAS_NOTHROW_COPY, "__has_nothrow_copy", 1) > diff --git a/gcc/cp/semantics.cc b/gcc/cp/semantics.cc > index 19d6f87a9ea..45dc509855a 100644 > --- a/gcc/cp/semantics.cc > +++ b/gcc/cp/semantics.cc > @@ -12801,6 +12801,18 @@ finish_trait_type (cp_trait_kind kind, tree type1, tree type2, > return type1; > return cp_build_reference_type (type1, /*rval=*/true); > > + case CPTK_DECAY: > + if (TYPE_REF_P (type1)) > + type1 = TREE_TYPE (type1); > + > + if (TREE_CODE (type1) == ARRAY_TYPE) > + return finish_trait_type (CPTK_ADD_POINTER, TREE_TYPE (type1), type2, > + complain); > + else if (TREE_CODE (type1) == FUNCTION_TYPE) > + return finish_trait_type (CPTK_ADD_POINTER, type1, type2, complain); > + else > + return cv_unqualified (type1); > + > case CPTK_REMOVE_ALL_EXTENTS: > return strip_array_types (type1); > > diff --git a/gcc/testsuite/g++.dg/ext/decay.C b/gcc/testsuite/g++.dg/ext/decay.C > new file mode 100644 > index 00000000000..8adedfeefe6 > --- /dev/null > +++ b/gcc/testsuite/g++.dg/ext/decay.C > @@ -0,0 +1,22 @@ > +// { dg-do compile { target c++11 } } > + > +#define SA(X) static_assert((X),#X) > + > +// Positive tests. > +using test1_type = __decay(bool); > +SA(__is_same(test1_type, bool)); > + > +// NB: DR 705. > +using test2_type = __decay(const int); > +SA(__is_same(test2_type, int)); > + > +using test3_type = __decay(int[4]); > +SA(__is_same(test3_type, __remove_extent(int[4])*)); > + > +using fn_type = void (); > +using test4_type = __decay(fn_type); > +SA(__is_same(test4_type, __add_pointer(fn_type))); > + > +using cfn_type = void () const; > +using test5_type = __decay(cfn_type); > +SA(__is_same(test5_type, cfn_type)); > diff --git a/gcc/testsuite/g++.dg/ext/has-builtin-1.C b/gcc/testsuite/g++.dg/ext/has-builtin-1.C > index c2503c5d82b..3aca273aad6 100644 > --- a/gcc/testsuite/g++.dg/ext/has-builtin-1.C > +++ b/gcc/testsuite/g++.dg/ext/has-builtin-1.C > @@ -11,6 +11,9 @@ > #if !__has_builtin (__add_rvalue_reference) > # error "__has_builtin (__add_rvalue_reference) failed" > #endif > +#if !__has_builtin (__decay) > +# error "__has_builtin (__decay) failed" > +#endif > #if !__has_builtin (__builtin_addressof) > # error "__has_builtin (__builtin_addressof) failed" > #endif