From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wr1-x431.google.com (mail-wr1-x431.google.com [IPv6:2a00:1450:4864:20::431]) by sourceware.org (Postfix) with ESMTPS id 7EC903858CDA; Tue, 16 Aug 2022 18:54:12 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 7EC903858CDA Received: by mail-wr1-x431.google.com with SMTP id p10so13685141wru.8; Tue, 16 Aug 2022 11:54:12 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=subject:from:cc:to:content-language:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc; bh=5G+4i9JjWc5xqvidHpC754N8x4tc7+z8UE9r8FjbM68=; b=ogw0si5DughqBSNELSPI0fwd+Baps7wHEVmxQkhlLGM90I/uISKrLKb5lAc2tCrj7f 2GOSqcyz1BLvvdDfUkO+jUCkEpCopcTd5QLChbSs4qaYb2gXqk8jFr7Z6VPsPb44Pg26 4gXQmC5/Ue3WmlC/Tm4tCNq/ffkrIAmTeAG2vVP4CW9IObnBVmVAqc8YqryZHwuAOuFU 7iNd2FqhW4+okBtX2LWaAF9G47yoSvL7W7YSKFmgonYIeDhQWEYepLjWXFSdOTsZmQOo NpbeNkv5ZjrzHxuCHR3KUzZ2Q8FRKnbAMuj2lCcXnORWeOjuP/cpB/w1uFrYmBsEihXr 0WoQ== X-Gm-Message-State: ACgBeo0RQvZqKPCsJzoqBU35f6YnoZBp9urena5Cgolx8JuYRhPKed3B DMPZm/2LNhcptIax+Dc9xQlJomn4D3A= X-Google-Smtp-Source: AA6agR71ZZ1CRKj+JJDNykkLKkJjmsQexee4wefT87gLE7zrJPdnkFRfNos56S2SI1j3rD0B7yiT/Q== X-Received: by 2002:a05:6000:783:b0:223:93d0:3286 with SMTP id bu3-20020a056000078300b0022393d03286mr12146495wrb.347.1660676050849; Tue, 16 Aug 2022 11:54:10 -0700 (PDT) Received: from ?IPV6:2a01:e0a:1dc:b1c0:8c9f:c361:c656:11e8? ([2a01:e0a:1dc:b1c0:8c9f:c361:c656:11e8]) by smtp.googlemail.com with ESMTPSA id m17-20020a05600c3b1100b003a319b67f64sm5505768wms.0.2022.08.16.11.54.09 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 16 Aug 2022 11:54:10 -0700 (PDT) Content-Type: multipart/mixed; boundary="------------1f0Hq0bzp0dBfCXHXWcmBVUy" Message-ID: <285077ef-de58-6050-bba8-e59f01009c8b@gmail.com> Date: Tue, 16 Aug 2022 20:54:09 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Content-Language: fr To: "libstdc++@gcc.gnu.org" Cc: gcc-patches From: =?UTF-8?Q?Fran=c3=a7ois_Dumont?= Subject: [PATCH][_GLIBCXX_ASSERTIONS] Activate __glibcxx_requires_string/__glibcxx_requires_string_len X-Spam-Status: No, score=-9.6 required=5.0 tests=BAYES_00, BODY_8BITS, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, GIT_PATCH_0, KAM_SHORT, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: libstdc++@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libstdc++ mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 16 Aug 2022 18:54:14 -0000 This is a multi-part message in MIME format. --------------1f0Hq0bzp0dBfCXHXWcmBVUy Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Following my remark about tests XFAIL-ing when running 'make check' I'd like to propose this to avoid this situation.     libstdc++: [_GLIBCXX_ASSERTIONS] Activate basic _GLIBCXX_DEBUB_PEDANTIC checks     Activate __glibcxx_requires_string/__glibcxx_requires_string_len in basic _GLIBCXX_ASSERTIONS     mode which is then considering _GLIBCXX_DEBUG_PEDANTIC for this purpose.     Thanks to this change add _GLIBCXX_ASSERTIONS to some tests that are otherwise XFAIL-ing on     segmentation fault rather than on a proper __glibcxx_assert call.     libstdc++-v3/ChangeLog:             * include/debug/debug.h (__glibcxx_requires_string, __glibcxx_requires_string_len): Move             definitions...             * include/debug/assertions.h: ... here. Definition now depends on _GLIBCXX_ASSERTIONS rather             than _GLIBCXX_DEBUG.             * testsuite/21_strings/basic_string/operations/ends_with/char_neg.cc: Add _GLIBCXX_ASSERTIONS             define.             * testsuite/21_strings/basic_string/operations/ends_with/wchar_t_neg.cc: Likewise.             * testsuite/21_strings/basic_string/operations/starts_with/char_neg.cc: Likewise.             * testsuite/21_strings/basic_string/operations/starts_with/wchar_t_neg.cc: Likewise. Tested under Linux x86_64. Ok to commit ? François --------------1f0Hq0bzp0dBfCXHXWcmBVUy Content-Type: text/x-patch; charset=UTF-8; name="string_assertions.patch" Content-Disposition: attachment; filename="string_assertions.patch" Content-Transfer-Encoding: base64 ZGlmZiAtLWdpdCBhL2xpYnN0ZGMrKy12My9pbmNsdWRlL2RlYnVnL2Fzc2VydGlvbnMuaCBi L2xpYnN0ZGMrKy12My9pbmNsdWRlL2RlYnVnL2Fzc2VydGlvbnMuaAppbmRleCA1N2MwYWIy YzNjZi4uZmNjOTEwYzczOTYgMTAwNjQ0Ci0tLSBhL2xpYnN0ZGMrKy12My9pbmNsdWRlL2Rl YnVnL2Fzc2VydGlvbnMuaAorKysgYi9saWJzdGRjKystdjMvaW5jbHVkZS9kZWJ1Zy9hc3Nl cnRpb25zLmgKQEAgLTQzLDYgKzQzLDggQEAKICMgZGVmaW5lIF9fZ2xpYmN4eF9yZXF1aXJl c19ub25fZW1wdHlfcmFuZ2UoX0ZpcnN0LF9MYXN0KQogIyBkZWZpbmUgX19nbGliY3h4X3Jl cXVpcmVzX25vbmVtcHR5KCkKICMgZGVmaW5lIF9fZ2xpYmN4eF9yZXF1aXJlc19zdWJzY3Jp cHQoX04pCisjIGRlZmluZSBfX2dsaWJjeHhfcmVxdWlyZXNfc3RyaW5nKF9TdHJpbmcpCisj IGRlZmluZSBfX2dsaWJjeHhfcmVxdWlyZXNfc3RyaW5nX2xlbihfU3RyaW5nLF9MZW4pCiAj ZWxzZQogCiAvLyBWZXJpZnkgdGhhdCBbX0ZpcnN0LCBfTGFzdCkgZm9ybXMgYSBub24tZW1w dHkgaXRlcmF0b3IgcmFuZ2UuCkBAIC01Myw2ICs1NSwyMiBAQAogLy8gVmVyaWZ5IHRoYXQg dGhlIGNvbnRhaW5lciBpcyBub25lbXB0eQogIyBkZWZpbmUgX19nbGliY3h4X3JlcXVpcmVz X25vbmVtcHR5KCkJCVwKICAgX19nbGliY3h4X2Fzc2VydCghdGhpcy0+ZW1wdHkoKSkKKyMg aWZkZWYgX0dMSUJDWFhfREVCVUdfUEVEQU5USUMKKyMgIGlmIF9fY3BsdXNwbHVzIDwgMjAx MTAzTAorIyAgIGRlZmluZSBfX2dsaWJjeHhfcmVxdWlyZXNfc3RyaW5nKF9TdHJpbmcpCVwK KyAgX19nbGliY3h4X2Fzc2VydChfU3RyaW5nICE9IDApCisjICAgZGVmaW5lIF9fZ2xpYmN4 eF9yZXF1aXJlc19zdHJpbmdfbGVuKF9TdHJpbmcsX0xlbikJXAorICBfX2dsaWJjeHhfYXNz ZXJ0KF9TdHJpbmcgIT0gMCB8fCBfTGVuID09IDApCisjICBlbHNlCisjICAgZGVmaW5lIF9f Z2xpYmN4eF9yZXF1aXJlc19zdHJpbmcoX1N0cmluZykJXAorICBfX2dsaWJjeHhfYXNzZXJ0 KF9TdHJpbmcgIT0gbnVsbHB0cikKKyMgICBkZWZpbmUgX19nbGliY3h4X3JlcXVpcmVzX3N0 cmluZ19sZW4oX1N0cmluZyxfTGVuKQlcCisgIF9fZ2xpYmN4eF9hc3NlcnQoX1N0cmluZyAh PSBudWxscHRyIHx8IF9MZW4gPT0gMCkKKyMgIGVuZGlmIC8vIEMrKzExCisjIGVsc2UKKyMg IGRlZmluZSBfX2dsaWJjeHhfcmVxdWlyZXNfc3RyaW5nKF9TdHJpbmcpCisjICBkZWZpbmUg X19nbGliY3h4X3JlcXVpcmVzX3N0cmluZ19sZW4oX1N0cmluZyxfTGVuKQorIyBlbmRpZiAv LyBfR0xJQkNYWF9ERUJVR19QRURBTlRJQwogI2VuZGlmCiAKICNpZmRlZiBfR0xJQkNYWF9E RUJVRwpkaWZmIC0tZ2l0IGEvbGlic3RkYysrLXYzL2luY2x1ZGUvZGVidWcvZGVidWcuaCBi L2xpYnN0ZGMrKy12My9pbmNsdWRlL2RlYnVnL2RlYnVnLmgKaW5kZXggZjQyMzM3NjA0MjYu LjU1OTNiNGZlOTJjIDEwMDY0NAotLS0gYS9saWJzdGRjKystdjMvaW5jbHVkZS9kZWJ1Zy9k ZWJ1Zy5oCisrKyBiL2xpYnN0ZGMrKy12My9pbmNsdWRlL2RlYnVnL2RlYnVnLmgKQEAgLTc4 LDggKzc4LDYgQEAgbmFtZXNwYWNlIF9fZ251X2RlYnVnCiAjIGRlZmluZSBfX2dsaWJjeHhf cmVxdWlyZXNfcGFydGl0aW9uZWRfdXBwZXJfcHJlZChfRmlyc3QsX0xhc3QsX1ZhbHVlLF9Q cmVkKQogIyBkZWZpbmUgX19nbGliY3h4X3JlcXVpcmVzX2hlYXAoX0ZpcnN0LF9MYXN0KQog IyBkZWZpbmUgX19nbGliY3h4X3JlcXVpcmVzX2hlYXBfcHJlZChfRmlyc3QsX0xhc3QsX1By ZWQpCi0jIGRlZmluZSBfX2dsaWJjeHhfcmVxdWlyZXNfc3RyaW5nKF9TdHJpbmcpCi0jIGRl ZmluZSBfX2dsaWJjeHhfcmVxdWlyZXNfc3RyaW5nX2xlbihfU3RyaW5nLF9MZW4pCiAjIGRl ZmluZSBfX2dsaWJjeHhfcmVxdWlyZXNfaXJyZWZsZXhpdmUoX0ZpcnN0LF9MYXN0KQogIyBk ZWZpbmUgX19nbGliY3h4X3JlcXVpcmVzX2lycmVmbGV4aXZlMihfRmlyc3QsX0xhc3QpCiAj IGRlZmluZSBfX2dsaWJjeHhfcmVxdWlyZXNfaXJyZWZsZXhpdmVfcHJlZChfRmlyc3QsX0xh c3QsX1ByZWQpCkBAIC0xMTgsMTcgKzExNiw2IEBAIG5hbWVzcGFjZSBfX2dudV9kZWJ1Zwog ICBfX2dsaWJjeHhfY2hlY2tfaGVhcChfRmlyc3QsX0xhc3QpCiAjIGRlZmluZSBfX2dsaWJj eHhfcmVxdWlyZXNfaGVhcF9wcmVkKF9GaXJzdCxfTGFzdCxfUHJlZCkJXAogICBfX2dsaWJj eHhfY2hlY2tfaGVhcF9wcmVkKF9GaXJzdCxfTGFzdCxfUHJlZCkKLSMgaWYgX19jcGx1c3Bs dXMgPCAyMDExMDNMCi0jICBkZWZpbmUgX19nbGliY3h4X3JlcXVpcmVzX3N0cmluZyhfU3Ry aW5nKQlcCi0gIF9HTElCQ1hYX0RFQlVHX1BFREFTU0VSVChfU3RyaW5nICE9IDApCi0jICBk ZWZpbmUgX19nbGliY3h4X3JlcXVpcmVzX3N0cmluZ19sZW4oX1N0cmluZyxfTGVuKQlcCi0g IF9HTElCQ1hYX0RFQlVHX1BFREFTU0VSVChfU3RyaW5nICE9IDAgfHwgX0xlbiA9PSAwKQot IyBlbHNlCi0jICBkZWZpbmUgX19nbGliY3h4X3JlcXVpcmVzX3N0cmluZyhfU3RyaW5nKQlc Ci0gIF9HTElCQ1hYX0RFQlVHX1BFREFTU0VSVChfU3RyaW5nICE9IG51bGxwdHIpCi0jICBk ZWZpbmUgX19nbGliY3h4X3JlcXVpcmVzX3N0cmluZ19sZW4oX1N0cmluZyxfTGVuKQlcCi0g IF9HTElCQ1hYX0RFQlVHX1BFREFTU0VSVChfU3RyaW5nICE9IG51bGxwdHIgfHwgX0xlbiA9 PSAwKQotIyBlbmRpZgogIyBkZWZpbmUgX19nbGliY3h4X3JlcXVpcmVzX2lycmVmbGV4aXZl KF9GaXJzdCxfTGFzdCkJXAogICBfX2dsaWJjeHhfY2hlY2tfaXJyZWZsZXhpdmUoX0ZpcnN0 LF9MYXN0KQogIyBkZWZpbmUgX19nbGliY3h4X3JlcXVpcmVzX2lycmVmbGV4aXZlMihfRmly c3QsX0xhc3QpCVwKZGlmZiAtLWdpdCBhL2xpYnN0ZGMrKy12My90ZXN0c3VpdGUvMjFfc3Ry aW5ncy9iYXNpY19zdHJpbmcvb3BlcmF0aW9ucy9lbmRzX3dpdGgvY2hhcl9uZWcuY2MgYi9s aWJzdGRjKystdjMvdGVzdHN1aXRlLzIxX3N0cmluZ3MvYmFzaWNfc3RyaW5nL29wZXJhdGlv bnMvZW5kc193aXRoL2NoYXJfbmVnLmNjCmluZGV4IDdhN2I4ZGQwNzdkLi42MDgwZGRjMDU1 NSAxMDA2NDQKLS0tIGEvbGlic3RkYysrLXYzL3Rlc3RzdWl0ZS8yMV9zdHJpbmdzL2Jhc2lj X3N0cmluZy9vcGVyYXRpb25zL2VuZHNfd2l0aC9jaGFyX25lZy5jYworKysgYi9saWJzdGRj KystdjMvdGVzdHN1aXRlLzIxX3N0cmluZ3MvYmFzaWNfc3RyaW5nL29wZXJhdGlvbnMvZW5k c193aXRoL2NoYXJfbmVnLmNjCkBAIC0xNSw3ICsxNSw3IEBACiAvLyB3aXRoIHRoaXMgbGli cmFyeTsgc2VlIHRoZSBmaWxlIENPUFlJTkczLiAgSWYgbm90IHNlZQogLy8gPGh0dHA6Ly93 d3cuZ251Lm9yZy9saWNlbnNlcy8+LgogLy8KLS8vIHsgZGctb3B0aW9ucyAiLXN0ZD1nbnUr KzJhIC1PMCIgfQorLy8geyBkZy1vcHRpb25zICItc3RkPWdudSsrMmEgLURfR0xJQkNYWF9B U1NFUlRJT05TIiB9CiAvLyB7IGRnLWRvIHJ1biB7IHRhcmdldCBjKysyYSB4ZmFpbCAqLSot KiB9IH0KIAogI2RlZmluZSBfR0xJQkNYWF9ERUJVR19QRURBTlRJQwpkaWZmIC0tZ2l0IGEv bGlic3RkYysrLXYzL3Rlc3RzdWl0ZS8yMV9zdHJpbmdzL2Jhc2ljX3N0cmluZy9vcGVyYXRp b25zL2VuZHNfd2l0aC93Y2hhcl90X25lZy5jYyBiL2xpYnN0ZGMrKy12My90ZXN0c3VpdGUv MjFfc3RyaW5ncy9iYXNpY19zdHJpbmcvb3BlcmF0aW9ucy9lbmRzX3dpdGgvd2NoYXJfdF9u ZWcuY2MKaW5kZXggYTY4ODFiZjQwNmIuLjYxZDQzNTU4YTc0IDEwMDY0NAotLS0gYS9saWJz dGRjKystdjMvdGVzdHN1aXRlLzIxX3N0cmluZ3MvYmFzaWNfc3RyaW5nL29wZXJhdGlvbnMv ZW5kc193aXRoL3djaGFyX3RfbmVnLmNjCisrKyBiL2xpYnN0ZGMrKy12My90ZXN0c3VpdGUv MjFfc3RyaW5ncy9iYXNpY19zdHJpbmcvb3BlcmF0aW9ucy9lbmRzX3dpdGgvd2NoYXJfdF9u ZWcuY2MKQEAgLTE1LDcgKzE1LDcgQEAKIC8vIHdpdGggdGhpcyBsaWJyYXJ5OyBzZWUgdGhl IGZpbGUgQ09QWUlORzMuICBJZiBub3Qgc2VlCiAvLyA8aHR0cDovL3d3dy5nbnUub3JnL2xp Y2Vuc2VzLz4uCiAvLwotLy8geyBkZy1vcHRpb25zICItc3RkPWdudSsrMmEgLU8wIiB9Cisv LyB7IGRnLW9wdGlvbnMgIi1zdGQ9Z251KysyYSAtRF9HTElCQ1hYX0FTU0VSVElPTlMiIH0K IC8vIHsgZGctZG8gcnVuIHsgdGFyZ2V0IGMrKzJhIHhmYWlsICotKi0qIH0gfQogCiAjZGVm aW5lIF9HTElCQ1hYX0RFQlVHX1BFREFOVElDCmRpZmYgLS1naXQgYS9saWJzdGRjKystdjMv dGVzdHN1aXRlLzIxX3N0cmluZ3MvYmFzaWNfc3RyaW5nL29wZXJhdGlvbnMvc3RhcnRzX3dp dGgvY2hhcl9uZWcuY2MgYi9saWJzdGRjKystdjMvdGVzdHN1aXRlLzIxX3N0cmluZ3MvYmFz aWNfc3RyaW5nL29wZXJhdGlvbnMvc3RhcnRzX3dpdGgvY2hhcl9uZWcuY2MKaW5kZXggZjM1 N2FlZjIyODkuLmUxY2M4YmFkNTI1IDEwMDY0NAotLS0gYS9saWJzdGRjKystdjMvdGVzdHN1 aXRlLzIxX3N0cmluZ3MvYmFzaWNfc3RyaW5nL29wZXJhdGlvbnMvc3RhcnRzX3dpdGgvY2hh cl9uZWcuY2MKKysrIGIvbGlic3RkYysrLXYzL3Rlc3RzdWl0ZS8yMV9zdHJpbmdzL2Jhc2lj X3N0cmluZy9vcGVyYXRpb25zL3N0YXJ0c193aXRoL2NoYXJfbmVnLmNjCkBAIC0xNSw3ICsx NSw3IEBACiAvLyB3aXRoIHRoaXMgbGlicmFyeTsgc2VlIHRoZSBmaWxlIENPUFlJTkczLiAg SWYgbm90IHNlZQogLy8gPGh0dHA6Ly93d3cuZ251Lm9yZy9saWNlbnNlcy8+LgogLy8KLS8v IHsgZGctb3B0aW9ucyAiLXN0ZD1nbnUrKzJhIC1PMCIgfQorLy8geyBkZy1vcHRpb25zICIt c3RkPWdudSsrMmEgLURfR0xJQkNYWF9BU1NFUlRJT05TIiB9CiAvLyB7IGRnLWRvIHJ1biB7 IHRhcmdldCBjKysyYSB4ZmFpbCAqLSotKiB9IH0KIAogI2RlZmluZSBfR0xJQkNYWF9ERUJV R19QRURBTlRJQwpkaWZmIC0tZ2l0IGEvbGlic3RkYysrLXYzL3Rlc3RzdWl0ZS8yMV9zdHJp bmdzL2Jhc2ljX3N0cmluZy9vcGVyYXRpb25zL3N0YXJ0c193aXRoL3djaGFyX3RfbmVnLmNj IGIvbGlic3RkYysrLXYzL3Rlc3RzdWl0ZS8yMV9zdHJpbmdzL2Jhc2ljX3N0cmluZy9vcGVy YXRpb25zL3N0YXJ0c193aXRoL3djaGFyX3RfbmVnLmNjCmluZGV4IDkwMDY1YTQ1OWI2Li44 ZmMzOWJiZDYzYyAxMDA2NDQKLS0tIGEvbGlic3RkYysrLXYzL3Rlc3RzdWl0ZS8yMV9zdHJp bmdzL2Jhc2ljX3N0cmluZy9vcGVyYXRpb25zL3N0YXJ0c193aXRoL3djaGFyX3RfbmVnLmNj CisrKyBiL2xpYnN0ZGMrKy12My90ZXN0c3VpdGUvMjFfc3RyaW5ncy9iYXNpY19zdHJpbmcv b3BlcmF0aW9ucy9zdGFydHNfd2l0aC93Y2hhcl90X25lZy5jYwpAQCAtMTUsNyArMTUsNyBA QAogLy8gd2l0aCB0aGlzIGxpYnJhcnk7IHNlZSB0aGUgZmlsZSBDT1BZSU5HMy4gIElmIG5v dCBzZWUKIC8vIDxodHRwOi8vd3d3LmdudS5vcmcvbGljZW5zZXMvPi4KIC8vCi0vLyB7IGRn LW9wdGlvbnMgIi1zdGQ9Z251KysyYSAtTzAiIH0KKy8vIHsgZGctb3B0aW9ucyAiLXN0ZD1n bnUrKzJhIC1EX0dMSUJDWFhfQVNTRVJUSU9OUyIgfQogLy8geyBkZy1kbyBydW4geyB0YXJn ZXQgYysrMmEgeGZhaWwgKi0qLSogfSB9CiAKICNkZWZpbmUgX0dMSUJDWFhfREVCVUdfUEVE QU5USUMK --------------1f0Hq0bzp0dBfCXHXWcmBVUy--