From: Matthias Kretz <m.kretz@gsi.de>
To: <gcc-patches@gcc.gnu.org>, <libstdc++@gcc.gnu.org>
Subject: [PATCH 08/11] libstdc++: Avoid raising fp exceptions in trunc, floor, and ceil
Date: Tue, 8 Jun 2021 14:11:55 +0200 [thread overview]
Message-ID: <2900568.OVeUXlzvHe@excalibur> (raw)
In-Reply-To: <270527782.u9WJ3AIrlG@excalibur>
[-- Attachment #1: Type: text/plain, Size: 1050 bytes --]
From: Matthias Kretz <kretz@kde.org>
Signed-off-by: Matthias Kretz <m.kretz@gsi.de>
libstdc++-v3/ChangeLog:
* include/experimental/bits/simd_x86.h (_S_trunc, _S_floor,
_S_ceil): Set bit 8 (_MM_FROUND_NO_EXC) on AVX and SSE4.1
roundp[sd] calls.
---
.../include/experimental/bits/simd_x86.h | 24 +++++++++----------
1 file changed, 12 insertions(+), 12 deletions(-)
--
──────────────────────────────────────────────────────────────────────────
Dr. Matthias Kretz https://mattkretz.github.io
GSI Helmholtz Centre for Heavy Ion Research https://gsi.de
std::experimental::simd https://github.com/VcDevel/std-simd
──────────────────────────────────────────────────────────────────────────
[-- Attachment #2: 0008-libstdc-Avoid-raising-fp-exceptions-in-trunc-floor-a.patch --]
[-- Type: text/x-patch, Size: 2545 bytes --]
diff --git a/libstdc++-v3/include/experimental/bits/simd_x86.h b/libstdc++-v3/include/experimental/bits/simd_x86.h
index 5706bf63845..34633c096b1 100644
--- a/libstdc++-v3/include/experimental/bits/simd_x86.h
+++ b/libstdc++-v3/include/experimental/bits/simd_x86.h
@@ -2657,13 +2657,13 @@ template <typename _Abi>
else if constexpr (__is_avx512_pd<_Tp, _Np>())
return _mm512_roundscale_pd(__x, 0x0b);
else if constexpr (__is_avx_ps<_Tp, _Np>())
- return _mm256_round_ps(__x, 0x3);
+ return _mm256_round_ps(__x, 0xb);
else if constexpr (__is_avx_pd<_Tp, _Np>())
- return _mm256_round_pd(__x, 0x3);
+ return _mm256_round_pd(__x, 0xb);
else if constexpr (__have_sse4_1 && __is_sse_ps<_Tp, _Np>())
- return __auto_bitcast(_mm_round_ps(__to_intrin(__x), 0x3));
+ return __auto_bitcast(_mm_round_ps(__to_intrin(__x), 0xb));
else if constexpr (__have_sse4_1 && __is_sse_pd<_Tp, _Np>())
- return _mm_round_pd(__x, 0x3);
+ return _mm_round_pd(__x, 0xb);
else if constexpr (__is_sse_ps<_Tp, _Np>())
{
auto __truncated
@@ -2786,13 +2786,13 @@ template <typename _Abi>
else if constexpr (__is_avx512_pd<_Tp, _Np>())
return _mm512_roundscale_pd(__x, 0x09);
else if constexpr (__is_avx_ps<_Tp, _Np>())
- return _mm256_round_ps(__x, 0x1);
+ return _mm256_round_ps(__x, 0x9);
else if constexpr (__is_avx_pd<_Tp, _Np>())
- return _mm256_round_pd(__x, 0x1);
+ return _mm256_round_pd(__x, 0x9);
else if constexpr (__have_sse4_1 && __is_sse_ps<_Tp, _Np>())
- return __auto_bitcast(_mm_floor_ps(__to_intrin(__x)));
+ return __auto_bitcast(_mm_round_ps(__to_intrin(__x), 0x9));
else if constexpr (__have_sse4_1 && __is_sse_pd<_Tp, _Np>())
- return _mm_floor_pd(__x);
+ return _mm_round_pd(__x, 0x9);
else
return _Base::_S_floor(__x);
}
@@ -2808,13 +2808,13 @@ template <typename _Abi>
else if constexpr (__is_avx512_pd<_Tp, _Np>())
return _mm512_roundscale_pd(__x, 0x0a);
else if constexpr (__is_avx_ps<_Tp, _Np>())
- return _mm256_round_ps(__x, 0x2);
+ return _mm256_round_ps(__x, 0xa);
else if constexpr (__is_avx_pd<_Tp, _Np>())
- return _mm256_round_pd(__x, 0x2);
+ return _mm256_round_pd(__x, 0xa);
else if constexpr (__have_sse4_1 && __is_sse_ps<_Tp, _Np>())
- return __auto_bitcast(_mm_ceil_ps(__to_intrin(__x)));
+ return __auto_bitcast(_mm_round_ps(__to_intrin(__x), 0xa));
else if constexpr (__have_sse4_1 && __is_sse_pd<_Tp, _Np>())
- return _mm_ceil_pd(__x);
+ return _mm_round_pd(__x, 0xa);
else
return _Base::_S_ceil(__x);
}
next prev parent reply other threads:[~2021-06-08 12:11 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-08 12:10 [PATCH 00/11] stdx::simd optimizations, corrections, and cleanups Matthias Kretz
2021-06-08 12:11 ` [PATCH 01/11] libstdc++: Improve copysign codegen Matthias Kretz
2021-06-08 12:11 ` [PATCH 02/11] libstdc++: Remove dead code Matthias Kretz
2021-06-08 12:11 ` [PATCH 03/11] libstdc++: Improve fixed_size codegen Matthias Kretz
2021-06-08 12:11 ` [PATCH 04/11] libstdc++: Make use of __builtin_bit_cast Matthias Kretz
2021-06-11 10:53 ` [PATCH 04/11 v2] " Matthias Kretz
2021-06-24 14:01 ` [PATCH 04/11 v3] " Matthias Kretz
2021-06-24 14:08 ` Jakub Jelinek
2021-06-24 14:11 ` Jonathan Wakely
2021-06-24 14:12 ` Jonathan Wakely
2021-06-24 14:21 ` Jakub Jelinek
2021-06-24 14:34 ` Jonathan Wakely
2021-06-24 14:40 ` Jonathan Wakely
2021-06-24 14:44 ` Jakub Jelinek
2021-06-25 11:23 ` Jonathan Wakely
2021-06-08 12:11 ` [PATCH 05/11] libstdc++: Remove incorrect fabs overload Matthias Kretz
2021-06-08 12:11 ` [PATCH 06/11] libstdc++: Minor simd_math cleanups Matthias Kretz
2021-06-08 12:11 ` [PATCH 07/11] libstdc++: Fix condition when AVX512F ldexp implementation is used Matthias Kretz
2021-06-08 12:11 ` Matthias Kretz [this message]
2021-06-08 12:11 ` [PATCH 09/11] libstdc++: Ensure unrolled loops inline the lambda Matthias Kretz
2021-06-08 12:12 ` [PATCH 10/11] libstdc++: Fix internal names: add missing underscores Matthias Kretz
2021-06-08 12:12 ` [PATCH 11/11] libstdc++: Fix ODR issues with different -m flags Matthias Kretz
2021-06-09 12:22 ` Richard Biener
2021-06-09 12:53 ` Matthias Kretz
2021-06-09 13:22 ` Richard Biener
2021-11-15 8:57 ` Matthias Kretz
2022-01-14 21:30 ` Jonathan Wakely
2022-01-17 0:08 ` Jonathan Wakely
2021-06-24 13:42 ` [PATCH 00/11] stdx::simd optimizations, corrections, and cleanups Jonathan Wakely
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2900568.OVeUXlzvHe@excalibur \
--to=m.kretz@gsi.de \
--cc=gcc-patches@gcc.gnu.org \
--cc=libstdc++@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).