From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from fx306.security-mail.net (smtpout30.security-mail.net [85.31.212.37]) by sourceware.org (Postfix) with ESMTPS id BD7A53857C6D for ; Wed, 21 Jul 2021 15:02:30 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org BD7A53857C6D Received: from localhost (localhost [127.0.0.1]) by fx306.security-mail.net (Postfix) with ESMTP id C03A6399630 for ; Wed, 21 Jul 2021 17:02:29 +0200 (CEST) Received: from fx306 (localhost [127.0.0.1]) by fx306.security-mail.net (Postfix) with ESMTP id DFCAB39964B; Wed, 21 Jul 2021 17:02:28 +0200 (CEST) Received: from zimbra2.kalray.eu (unknown [217.181.231.53]) by fx306.security-mail.net (Postfix) with ESMTPS id CC6CC39962A; Wed, 21 Jul 2021 17:02:24 +0200 (CEST) Received: from zimbra2.kalray.eu (localhost [127.0.0.1]) by zimbra2.kalray.eu (Postfix) with ESMTPS id B70C827E0232; Wed, 21 Jul 2021 17:02:24 +0200 (CEST) Received: from localhost (localhost [127.0.0.1]) by zimbra2.kalray.eu (Postfix) with ESMTP id 9FFB427E039C; Wed, 21 Jul 2021 17:02:24 +0200 (CEST) Received: from zimbra2.kalray.eu ([127.0.0.1]) by localhost (zimbra2.kalray.eu [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id jdE1WTRN8WPR; Wed, 21 Jul 2021 17:02:24 +0200 (CEST) Received: from zimbra2.kalray.eu (localhost [127.0.0.1]) by zimbra2.kalray.eu (Postfix) with ESMTP id 8DBF027E0232; Wed, 21 Jul 2021 17:02:24 +0200 (CEST) X-Virus-Scanned: E-securemail, by Secumail Secumail-id: DKIM-Filter: OpenDKIM Filter v2.10.3 zimbra2.kalray.eu 9FFB427E039C Date: Wed, 21 Jul 2021 17:02:24 +0200 (CEST) From: Marc Poulhies To: Marc Poulhies Cc: gcc-patches , libstdc++ , Luc Michel Message-ID: <291496446.934555.1626879744068.JavaMail.zimbra@kalray.eu> In-Reply-To: <1855720815.793351.1626790336484.JavaMail.zimbra@kalray.eu> References: <1855720815.793351.1626790336484.JavaMail.zimbra@kalray.eu> Subject: Re: [NEWS] libstdc++: Fix testsuite for skipping gdb tests on remote/non-native target MIME-Version: 1.0 Content-Type: multipart/mixed; boundary=secu_fd9c27a6d70567b1f50dce8a6b819a6a_part1 X-Originating-IP: [192.168.40.202] X-Mailer: Zimbra 9.0.0_GA_3990 (ZimbraWebClient - FF88 (Linux)/9.0.0_GA_3990) Thread-Topic: libstdc++: Fix testsuite for skipping gdb tests on remote/non-native target Thread-Index: IrSSEUX4DnBF1EiLGPi1DCexzazdSRRq53C5 X-ALTERMIMEV2_out: done X-Spam-Status: No, score=-15.4 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_DNSWL_LOW, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: libstdc++@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libstdc++ mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 21 Jul 2021 15:02:33 -0000 This message is in MIME format. --secu_fd9c27a6d70567b1f50dce8a6b819a6a_part1 Content-Type: text/plain; charset=utf-8 With the correct patch attached, sorry for the incorrect previous one ! Marc ----- Original Message ----- > From: "gcc-patches" > To: "gcc-patches" , "libstdc++" > Cc: "Luc Michel" > Sent: Tuesday, July 20, 2021 4:12:16 PM > Subject: [NEWS] libstdc++: Fix testsuite for skipping gdb tests on remote/non-native target > This fixes an incorrect invocation of gdb on remote targets where DejaGNU would > try to run host's gdb in remote target simulator. > gdb-test skips the testing when target is remote or non native but the gdb > version check function does not. > > libstdc++-v3/ChangeLog: > * testsuite/lib/gdb-test.exp (gdb_batch_check): Exit if non native or remote > target. --secu_fd9c27a6d70567b1f50dce8a6b819a6a_part1 Content-Type: text/x-patch; name=patch.txt Content-Disposition: attachment; filename=patch.txt diff --git a/libstdc++-v3/testsuite/lib/gdb-test.exp b/libstdc++-v3/testsuite/lib/gdb-test.exp index af20c85e5a0..0ec9ac46c68 100644 --- a/libstdc++-v3/testsuite/lib/gdb-test.exp +++ b/libstdc++-v3/testsuite/lib/gdb-test.exp @@ -244,6 +244,8 @@ proc gdb-test { marker {selector {}} {load_xmethods 0} } { # Invoke gdb with a command and pattern-match the output. proc gdb_batch_check {command pattern} { + if { ![isnative] || [is_remote target] } { return 0 } + set gdb_name $::env(GUALITY_GDB_NAME) set cmd "$gdb_name -nw -nx -quiet -batch -ex \"$command\"" send_log "Spawning: $cmd\n" --secu_fd9c27a6d70567b1f50dce8a6b819a6a_part1--