public inbox for libstdc++@gcc.gnu.org
 help / color / mirror / Atom feed
From: Olivier Hainque <hainque@adacore.com>
To: Jonathan Wakely <jwakely@redhat.com>
Cc: Olivier Hainque <hainque@adacore.com>,
	libstdc++ <libstdc++@gcc.gnu.org>,
	gcc-patches <gcc-patches@gcc.gnu.org>
Subject: Re: [PATCH] #undef isblank before def or decl in libstdc++ headers
Date: Sat, 11 Dec 2021 11:55:31 +0100	[thread overview]
Message-ID: <3913529E-3CB1-4758-B675-A8862869B238@adacore.com> (raw)
In-Reply-To: <CACb0b4=VHWQOfEqvHfFMQU46RDt3yc40rS80rXFcZA+TG29TKg@mail.gmail.com>

(Thanks for your feedback Jonathan)

> On 10 Dec 2021, at 19:24, Jonathan Wakely <jwakely@redhat.com> wrote:
> 
> I'm curious why _GLIBCXX_USE_C99_CTYPE_TR1 is not defined if VxWorks
> has isblank, the configure check is:

Oh, hmm, very good point. The reason was that the definition
of isblank is conditioned on _C99/_HAS_C9X as well, so the need
for which we had introduced the definition in os_defines.h
would better be generalized.

	* config/vxworks.h (VXWORKS_OS_CPP_BUILTINS): Define
	_C99 for C++.

--- a/gcc/config/vxworks.h
+++ b/gcc/config/vxworks.h
@@ -328,6 +328,10 @@ extern void vxworks_asm_out_destructor (rtx symbol, int priority);
 	   if (!flag_isoc99 && !c_dialect_cxx())			\
              builtin_define ("_ALLOW_KEYWORD_MACROS");			\
         }								\
+      /* C++ support relies on C99 features.  Make sure they are	\
+	 exposed by the system headers.  */				\
+      if (c_dialect_cxx())						\
+	builtin_define("_C99");						\
     }									\
   while (0)


Works with the two libstdc++ changes reverted, and gives
"configure" a better view of what's there.

Makes sense?



  reply	other threads:[~2021-12-11 10:55 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-12-10 17:06 Olivier Hainque
2021-12-10 18:24 ` Jonathan Wakely
2021-12-11 10:55   ` Olivier Hainque [this message]
2021-12-11 17:09     ` Jonathan Wakely
2021-12-13 11:09       ` Olivier Hainque

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3913529E-3CB1-4758-B675-A8862869B238@adacore.com \
    --to=hainque@adacore.com \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=jwakely@redhat.com \
    --cc=libstdc++@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).