From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <hainque@adacore.com>
Received: from mail-wm1-x32f.google.com (mail-wm1-x32f.google.com
 [IPv6:2a00:1450:4864:20::32f])
 by sourceware.org (Postfix) with ESMTPS id 1F1FD3858D39
 for <libstdc++@gcc.gnu.org>; Sat, 11 Dec 2021 10:55:33 +0000 (GMT)
DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 1F1FD3858D39
Received: by mail-wm1-x32f.google.com with SMTP id
 j140-20020a1c2392000000b003399ae48f58so10746910wmj.5
 for <libstdc++@gcc.gnu.org>; Sat, 11 Dec 2021 02:55:33 -0800 (PST)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20210112;
 h=x-gm-message-state:mime-version:subject:from:in-reply-to:date:cc
 :content-transfer-encoding:message-id:references:to;
 bh=5xIbAiqFngt3j999XNfj5ciWOOkxFnz/hoya0ErhaEI=;
 b=jJg5iVn8PGK1NuBSUfWS+gX3IKXfJ3M1KV+7sI6hXKqRTBciBSDLaiz5J8YIjG4t0W
 yRc6S099kAe+9nPSVVxbpnrRDJ9uL2Gay4at1fV+YCeUpWiMyr4mdz/mgiTKKaSw06FB
 xv/3yGLGFsAa0oNGvbfDqajoIy/wtsus+j8Xmz1OTHaQcRSkWVVThQTqIEgAV76BT8Fi
 MEs+xAqyhaALcaon8I19c5ZFGeXzKBgg+7kPOQp9B9q5JuxgktA4XggNTyv+yDdfUFRb
 w6MCyhuOREMFdhQyMPpbVIefLfE1eyWE3OIzPEd6FfzJWF1vACYJi91RGzVRwJYom+qh
 y86g==
X-Gm-Message-State: AOAM531ggXcxqoGc7ZfBWo89HtoR/Hfkk2RbyFVXURjHNE1uio5XSSPe
 eUEaSWkR2guAaz9jHmfI8aTY4A==
X-Google-Smtp-Source: ABdhPJxxNzTdGXi30LrKzm+wZh4jUrj6PV5XQXqtQ761uy9vQ8K0WKGEjzxTr3OhKhXmIKf5ptNU1g==
X-Received: by 2002:a05:600c:1f0c:: with SMTP id
 bd12mr23637033wmb.56.1639220132066; 
 Sat, 11 Dec 2021 02:55:32 -0800 (PST)
Received: from imac.home (2a01cb00029127002c6a05c80e79cada.ipv6.abo.wanadoo.fr.
 [2a01:cb00:291:2700:2c6a:5c8:e79:cada])
 by smtp.gmail.com with ESMTPSA id p5sm5111919wrd.13.2021.12.11.02.55.31
 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128);
 Sat, 11 Dec 2021 02:55:31 -0800 (PST)
Content-Type: text/plain;
	charset=us-ascii
Mime-Version: 1.0 (Mac OS X Mail 13.4 \(3608.120.23.2.4\))
Subject: Re: [PATCH] #undef isblank before def or decl in libstdc++ headers
From: Olivier Hainque <hainque@adacore.com>
In-Reply-To: <CACb0b4=VHWQOfEqvHfFMQU46RDt3yc40rS80rXFcZA+TG29TKg@mail.gmail.com>
Date: Sat, 11 Dec 2021 11:55:31 +0100
Cc: Olivier Hainque <hainque@adacore.com>, libstdc++ <libstdc++@gcc.gnu.org>,
 gcc-patches <gcc-patches@gcc.gnu.org>
Content-Transfer-Encoding: quoted-printable
Message-Id: <3913529E-3CB1-4758-B675-A8862869B238@adacore.com>
References: <E4EEFE7A-0BD9-4845-A32C-E62D0DCAA16C@adacore.com>
 <CACb0b4=VHWQOfEqvHfFMQU46RDt3yc40rS80rXFcZA+TG29TKg@mail.gmail.com>
To: Jonathan Wakely <jwakely@redhat.com>
X-Mailer: Apple Mail (2.3608.120.23.2.4)
X-Spam-Status: No, score=-2.4 required=5.0 tests=BAYES_00, DKIM_SIGNED,
 DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,
 SPF_PASS, TXREP autolearn=unavailable autolearn_force=no version=3.4.4
X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on
 server2.sourceware.org
X-BeenThere: libstdc++@gcc.gnu.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Libstdc++ mailing list <libstdc++.gcc.gnu.org>
List-Unsubscribe: <https://gcc.gnu.org/mailman/options/libstdc++>,
 <mailto:libstdc++-request@gcc.gnu.org?subject=unsubscribe>
List-Archive: <https://gcc.gnu.org/pipermail/libstdc++/>
List-Post: <mailto:libstdc++@gcc.gnu.org>
List-Help: <mailto:libstdc++-request@gcc.gnu.org?subject=help>
List-Subscribe: <https://gcc.gnu.org/mailman/listinfo/libstdc++>,
 <mailto:libstdc++-request@gcc.gnu.org?subject=subscribe>
X-List-Received-Date: Sat, 11 Dec 2021 10:55:34 -0000

(Thanks for your feedback Jonathan)

> On 10 Dec 2021, at 19:24, Jonathan Wakely <jwakely@redhat.com> wrote:
>=20
> I'm curious why _GLIBCXX_USE_C99_CTYPE_TR1 is not defined if VxWorks
> has isblank, the configure check is:

Oh, hmm, very good point. The reason was that the definition
of isblank is conditioned on _C99/_HAS_C9X as well, so the need
for which we had introduced the definition in os_defines.h
would better be generalized.

	* config/vxworks.h (VXWORKS_OS_CPP_BUILTINS): Define
	_C99 for C++.

--- a/gcc/config/vxworks.h
+++ b/gcc/config/vxworks.h
@@ -328,6 +328,10 @@ extern void vxworks_asm_out_destructor (rtx symbol, =
int priority);
 	   if (!flag_isoc99 && !c_dialect_cxx())			=
\
              builtin_define ("_ALLOW_KEYWORD_MACROS");			=
\
         }								=
\
+      /* C++ support relies on C99 features.  Make sure they are	=
\
+	 exposed by the system headers.  */				=
\
+      if (c_dialect_cxx())						=
\
+	builtin_define("_C99");						=
\
     }									=
\
   while (0)


Works with the two libstdc++ changes reverted, and gives
"configure" a better view of what's there.

Makes sense?