From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR02-AM5-obe.outbound.protection.outlook.com (mail-eopbgr00103.outbound.protection.outlook.com [40.107.0.103]) by sourceware.org (Postfix) with ESMTPS id B80A23858403; Fri, 10 Dec 2021 15:15:26 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org B80A23858403 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=WLHR0SJcpovX8dFeyg//Z3PbqRa5gDtoMGPlZJ0svWel85qg3nIaH66b4wO15nk+6Q/FyztyERmDB5kp/XylJJyzFj+C6ZFbzXn5eq61oS8xYeA88mGZTdr1rwZvNszQrQdcCuzZgMg3NzBzawJFfn/3BtTEG4kYCNTaX5SyF7lQFJfCSSfh2eNMceXiCACHuWaYNFvUXsndfbWrcKHemDPUCo/58TwLIEZkaMh+TuWyMYZKuP2Eun4qxhJwc+hkf5nHRgxbFoP1AfhBmvylE//88sAhl02PQ1U70zk7yGddoMFSUqBWXs4GWfp0fTzcJRn1sA4NKtI7CEbIuQAIrQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=igybB7gv+hey06UZY5NRgpq9z9EfJpSdSYCbfVfCtq4=; b=Hr1xcPWsf4mlhJfwvSddeRzTzFZuJTdjmUEwHkit9Hg9lesjZfOYQ4F+wVCb2mCtIHSCFtv2bEY4h2Tp1EQnPD3Jw200ArlAgzd7WjCc1HgoB3sET+4VNpWgcUFikXoG6EUp6aaXJVecmS2eER63cls5sAe12TTDtVldR9fpvNyszbhH86ApeuTRdLEFjsYcJwBXftuM+stY6/VqRPGYqxB5Fi2TxnuY09FSJm5et/rF/63fUDSWLcd/IkEm+dWprCxSIxWRmWbZ5lz06zofYZNwZMhHN6LE6gDw7GPUo9qNZGR+zrWUfqhwvpZiiRwqo06Q/dunjuqXHAglcgzjPQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=prevas.dk; dmarc=pass action=none header.from=prevas.dk; dkim=pass header.d=prevas.dk; arc=none Received: from DU0PR10MB5266.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:10:34a::22) by DB9PR10MB5308.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:10:336::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4755.20; Fri, 10 Dec 2021 15:15:24 +0000 Received: from DU0PR10MB5266.EURPRD10.PROD.OUTLOOK.COM ([fe80::e1f4:ce93:7894:bd1e]) by DU0PR10MB5266.EURPRD10.PROD.OUTLOOK.COM ([fe80::e1f4:ce93:7894:bd1e%5]) with mapi id 15.20.4755.021; Fri, 10 Dec 2021 15:15:24 +0000 Subject: Re: [PATCH] Define _C99 in libstdc++ vxworks/os_defines.h To: Olivier Hainque , libstdc++@gcc.gnu.org, gcc-patches@gcc.gnu.org References: From: Rasmus Villemoes Message-ID: <3a28a096-3aec-7270-5e7b-9b8a54e4c7b9@prevas.dk> Date: Fri, 10 Dec 2021 16:15:20 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.14.0 In-Reply-To: Content-Type: text/plain; charset=windows-1252 Content-Language: en-US Content-Transfer-Encoding: 7bit X-ClientProxiedBy: HE1PR0401CA0080.eurprd04.prod.outlook.com (2603:10a6:3:19::48) To DU0PR10MB5266.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:10:34a::22) MIME-Version: 1.0 Received: from [172.16.11.1] (81.216.59.226) by HE1PR0401CA0080.eurprd04.prod.outlook.com (2603:10a6:3:19::48) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4755.17 via Frontend Transport; Fri, 10 Dec 2021 15:15:23 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: d10927bb-0bc2-4e18-f2a1-08d9bbefe3aa X-MS-TrafficTypeDiagnostic: DB9PR10MB5308:EE_ X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:2512; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 0aq+jD/z14NsDVtdTddpjRjl24zvkdT3BlKYWMwLOpCE8zB3YrxDxSWiLwhkYM1fz5jmr47l/Jz3VgVne+WQQRS+mRJ8kvHJM06maUm1/VinP4mWCk/yZHxRVk0XY6Y/4DUBHKk3eX2CyLFCO++AvmP2kNta0t/N4bPbgClzFDLo1/mIG2nk070RCLS5fYnIEJISsvJjWR1k6PN5HD9gdMZpzZpUcdTpR1IFtBGv938hWSTrf4Q7hXopoGhzzYdJN6Lio76csIidKiYJnmfYoUiGlD7J+NDufUeNJzqQ2zaxrbfY39q38mjnhHgkuWsSGMGHMYOf2tNoNPhn+dGit8X4T7z8XnvblzbMApVRYcIfL4feQKZZsn1ZWGIGU2tiBL2str8TCcLCq1a9dHObd//o0DwbD0vxms50ph5ShSOJpzbGUlSfkVkIxBmooF0O5zmJgtyCwqavrYBjdZgSWujRygHZXU3Z8IskC9SC64iNiX2+TLJs5e8ZNyiar4wGSWQF6e9L9IXff6hJtdzPAcNVUVvHb/abAP+0PUrCvMeHp0ZUFYYJD/jJG1TOP7fqVdUtWJEYF1535z+ni80gwKo9r5FhHWig9yiGv9R8KZKbGtyC17p7lkRzFROOA8QjLpd6/EoRRNawdd/fe1tC8yqRslGxqhODEPfMKj5f5JHzgws8BJoamTPtSeZHPcuri2L+ovaUHiKDMK/5RemJPJaRVhbAzmveBDdhbFw76XviXpSygBwbar//VN+lf7pkDH019gBYZ36kDufKYIRARg== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DU0PR10MB5266.EURPRD10.PROD.OUTLOOK.COM; PTR:; CAT:NONE; SFS:(366004)(316002)(8936002)(8976002)(52116002)(66556008)(2906002)(66476007)(8676002)(6486002)(26005)(186003)(31696002)(36756003)(5660300002)(2616005)(956004)(83380400001)(66946007)(16576012)(38100700002)(86362001)(44832011)(508600001)(38350700002)(31686004)(4744005)(43740500002)(45980500001); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?Windows-1252?Q?xWzLBaXopb367Aidx50EbvdaN9/2MX+vp/4KeERVxB6D4ujXd3rap5B0?= =?Windows-1252?Q?gMwB0EfIhZfn2RKSoDqAFnD7d4O5YIifFDibkDrqP1AilY9/ApZfMqRj?= =?Windows-1252?Q?61CuG14UC6TqDOWEP2nqwsBoOJpT396q3uRaXv/1CHo5yiBQLursBqLH?= =?Windows-1252?Q?j9Gle6tWSmGSZhw3O6FSHinjT7jrcSMDEv6PV62uiBcupbAvaSSA/AX6?= =?Windows-1252?Q?20Fha3ZIIsDRhQhNZEWggBdZ12W6OPzk2BLeJWFNUYb5kKPmvK6wJCwM?= =?Windows-1252?Q?NFuP/hVvWdbWQ01MYyEpMwL8StcVDphqiquhZH6Dq3yNpmkNaQxojhZo?= =?Windows-1252?Q?tMMmvUWf2YLdIg/v5ZXsF4ra+52PO3AqtR9AJf9c9FbEDeRnoPMyHTwC?= =?Windows-1252?Q?RvO8qvwvhm4wLaOEkbE/INHIo7BL6qCSKbSxbqYqxaN8Mv9jcCelwjrh?= =?Windows-1252?Q?nRu4IFkvbFpvfyoGtnu16Q6ph7H3+r3wfXhvqRPh7Lm1CX7hMqQrU2Ma?= =?Windows-1252?Q?zH2u/0F5qnuSEP5rYlwaBK0Ms0+eb/ODB/VKKN/SHKwzr/ItpY7bEXOo?= =?Windows-1252?Q?JeZdGXtSYkKLeri/YI6zB2jEiLAOsfjLC0i2VHasuBXCjAfEMGsxM8o7?= =?Windows-1252?Q?pkKvux1mQisfIcrTiY6vFSh51WaLH2VMiSlSODKGDlmWdMeP0GE8tu9y?= =?Windows-1252?Q?y6qUC36TTib+Z7OF5UAWQIKtlfZG2GMupv0p7tdVa19zoMJnGV8AXf3p?= =?Windows-1252?Q?cAJIKZLVk5gSj23y+64vFf0DgTl5+SF9GwNeieQUijy7436K8veIxfnK?= =?Windows-1252?Q?Y7tiEM9gf4wNyGLPcZpM6Zjc4gXWNQXYl1/3jpzn6nn0eYlob08gCfqi?= =?Windows-1252?Q?JIfmRtSqlgfK2gLJ1VZcIQ1Ym1q7htJJPAetqM0m48p4s1Pz4M3UitXJ?= =?Windows-1252?Q?oxP34uP5BIn//fWMIEcEewRiucCAEq7nD4lE7Z5avjfTnYoGHqy9V7/2?= =?Windows-1252?Q?kpsa8VBfdOJ5iHcu3vdzPbgw2ZN3saDKM2BEx4d5pHrfokL3KZtEtKr9?= =?Windows-1252?Q?MYmYSW2nnShbt6HveZr1KGJL7xWaTK1Nkheeo+EJp/FvWWpUW3oNUk9C?= =?Windows-1252?Q?wLZOQcKRjL+J7+vNiYdYrrJXgOpsjTGnYoIeOXYO/bopYEd8Q9dFJWA+?= =?Windows-1252?Q?SxeqsUmvJ+btqID88laDdBIcvR8ldumHlzI21pcVApbjairzndxhhG79?= =?Windows-1252?Q?ir5xd8bdeLragsdVgJkhWTT3wXumCgUEAp0/QLysqjmd9fOmHo8R18OH?= =?Windows-1252?Q?PBSx/RoVuo9Lf7v05OUBVxXvD5cf9GVUjhPm96W08n+KnNJcV4hhKalZ?= =?Windows-1252?Q?YaFMMEL5r2SqJssBA+tD9WlKOqSDoEBYXZUQZVp9hh0SNpC0EzxigILM?= =?Windows-1252?Q?XdZx5Pny/x+4I7e+CXUObZvbEObw0nOHEJLBUcxbN2aJINtNTw1KtNva?= =?Windows-1252?Q?8AO1G68lortUM7m6nNIGS4FSmasH4g9eKTvby7FbcW6aOBPTDvQNgig2?= =?Windows-1252?Q?FkpkOnns32FmDelj4Re5Fu3903I1XPJJHw60mX4PVJawGMzp4juha4a+?= =?Windows-1252?Q?vrpdsWHHEZ0lxgN6wWEdkRRaSPfp7L3X9M/uxRWsVssrF9un9DQ62HEE?= =?Windows-1252?Q?Od9SqTFKvlQFiU4ipDbkH1oJ2i4PZr4L8jnbzOvZANkRI/Qmq89avSOJ?= =?Windows-1252?Q?PjaThuUYOruskWn/evkWBk+m/AVcbuXsFlf//frLD4I1lXGM9mAIkPB8?= =?Windows-1252?Q?5YWM/nsacJ3scYde2G4BtlSUbgU=3D?= X-OriginatorOrg: prevas.dk X-MS-Exchange-CrossTenant-Network-Message-Id: d10927bb-0bc2-4e18-f2a1-08d9bbefe3aa X-MS-Exchange-CrossTenant-AuthSource: DU0PR10MB5266.EURPRD10.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Dec 2021 15:15:24.2278 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: d350cf71-778d-4780-88f5-071a4cb1ed61 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 5P1rHxortUcn+krlATQq1AymMHeqQNZYHAaQ59tAEs7GY4Cpw0O4jMPYygTbMQVBBns2k2tMww1Dj9cZfMbBkynjlvtly3SIWEKO5xhX16o= X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB9PR10MB5308 X-Spam-Status: No, score=-3.4 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, MSGID_FROM_MTA_HEADER, NICE_REPLY_A, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_PASS, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: libstdc++@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libstdc++ mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 10 Dec 2021 15:15:28 -0000 On 10/12/2021 16.06, Olivier Hainque wrote: > Hello, > > The attached patch for libstdc++ / VxWorks helps building > the library for old versions of the OS, as witnessed with > VxWorks 6.9 in particular. > > It explicitly requests C99 features from old system headers, > on which libstc++ relies since at least c++98. The specific > issue that exposed this was a failure to compile > > libstdc++-v3/src/c++17/floating_to_chars.cc > > for VxWorks 6.9 with a batch of errors such as: > > error: 'FP_NAN' was not declared in this scope > > The missing definitions are provided by the > system headers with guards on _HAS_C9X, which gets > internally defined when _C99 is. > > Ok to commit? Yes, we've observed that error as well. We have just patched our vxworks 5.5 headers to provide FP_NAN et al. There's no test of definedness or other uses of a _C99 macro anywhere, so ok by me, as it shouldn't change anything on our end. Rasmus