From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id A1FDC3860C3B for ; Wed, 14 Feb 2024 20:20:12 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org A1FDC3860C3B Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org A1FDC3860C3B Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=170.10.133.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1707942015; cv=none; b=cHTVoAKMLh3+4iUovh2nuHCixZAny7lfCJrXRMzqiQ4PJan5UPEA1Dpn6S3cV6wx1jhHuq3FrhjMDBF2RMGDYBbYMS6TuXa9Vrv4mk9182EaHtgounUEhAjaHsN2LV9Rzgp4oEzN5zrBYlntrLy2vXT1Qo1OWqkI95st1wc94+0= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1707942015; c=relaxed/simple; bh=xbS1XEVYX0B8mGvoR80+vBCEVLPTBMToGFf9k8zoulM=; h=DKIM-Signature:From:Date:To:Subject:Message-ID:MIME-Version; b=LMHorXae5N9RvW19V1w1MN3OyF9LaA4eUjDZ9EOFijWH8IeVc+TGA6xAAeDhAzPvcdWbNNt/83bEd5U/CmkJFcsknxzaZZmZyYDtBbLOzEbP0RR33A0zD8YVUaajNbfSaezU8v0Y7f7wSncPHW1ZBmdmBeNl+5Oi8Girpn7PkzQ= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1707942012; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=IisOkykYfUYhcFxaTdoMteAgoNYhxZ0MrHctUZu1VSA=; b=SKCXWe5947JkL65ZSWtBL8zHvkImY8RySmJHtz9V4NBDaPPCARYSVLGurpQX9AtTk1unnh AOTgVUrVBkLsYtXZL7Cuf7Nmzxbfpxmyt/NkRvzsJ8I2gV3Mv/0eyiWza5f2cuEPqCZxaC q6KNHPGA1vijWjayF7V7L0FPfGitqT8= Received: from mail-qv1-f72.google.com (mail-qv1-f72.google.com [209.85.219.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-82-e-w19hYiOce0MV93xNyuxA-1; Wed, 14 Feb 2024 15:20:10 -0500 X-MC-Unique: e-w19hYiOce0MV93xNyuxA-1 Received: by mail-qv1-f72.google.com with SMTP id 6a1803df08f44-68c43a4cc11so3303616d6.1 for ; Wed, 14 Feb 2024 12:20:10 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1707942010; x=1708546810; h=mime-version:references:message-id:in-reply-to:subject:cc:to:date :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=IisOkykYfUYhcFxaTdoMteAgoNYhxZ0MrHctUZu1VSA=; b=B2WPK3DE96UCYffD1zYjseWypj655XoqKirgACA/HrOKoWtrfWnyvZh3HeNoUpPKb5 91bKaiIAtIJo3jRX4Lb630E/+V+qWGbZ4CnkI83G0YpUuFDv9E72j9ctdu1PaeM+rzQH dI9Ax+WEnOdc8Sbfc89uM9eDrodML2kj5KkSG3nrkHExYWvimhseou6guf2FIH98tOtt fjysr9Yc4G3RHbPqIl1J/U96v2eYSF0MZyv2MGHhnMWm7D2brLbyKSD+3RUWcUuYTVVR QeUIgKeEoml8NoF/EHcUCruGCooh49sbb/3+VAdwQgm9+N6yJoDV0dv+ArOS67b2ErNM D9rA== X-Forwarded-Encrypted: i=1; AJvYcCVg0GbwhgNROb4+fCk4PiGyhJvP+9VrAdE5jCv45AjWbc9k4G+DUTRJy1krY0vFd2muLdsRGtGwMTCHzw6x0pb/j7Cndmc= X-Gm-Message-State: AOJu0YxyG+AdipnQvzb4oWUfw07t4c7zgZs7gBSF49NcZWZsi/jkrckn w81Bce2GHfyFwjWjkX+I7pF4nfAgrjbz/1SSIg/4b99W+Pzyhx8BoPPAt4oU90Zqwxd9Pp2JMXS qFDWTS8Ejptw1gSLuT7+9vZCU2rG2ADczOwE0AN+AtAwWtZaJMndA X-Received: by 2002:a05:6214:224c:b0:68c:61e9:d199 with SMTP id c12-20020a056214224c00b0068c61e9d199mr4640152qvc.7.1707942010522; Wed, 14 Feb 2024 12:20:10 -0800 (PST) X-Google-Smtp-Source: AGHT+IF3+SIU60IpMs/VDEkYicEv4Bpx2k20/vwfekRonz1/5nmtS6HVGJwWYGVE9kxBZ5xbRht/aA== X-Received: by 2002:a05:6214:224c:b0:68c:61e9:d199 with SMTP id c12-20020a056214224c00b0068c61e9d199mr4640140qvc.7.1707942010244; Wed, 14 Feb 2024 12:20:10 -0800 (PST) X-Forwarded-Encrypted: i=1; AJvYcCVgcKvegLYLJkHCIa6dbBcKyyaywWay2zLZxlAbPGjmu17PMLzB1CcZjM+rOs6rOShNfZwVlTsoe7k8fiGjeu+5Td9y4Rg= Received: from [192.168.1.130] (ool-457670bb.dyn.optonline.net. [69.118.112.187]) by smtp.gmail.com with ESMTPSA id op11-20020a056214458b00b0068c6789ce9csm2622656qvb.6.2024.02.14.12.20.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 14 Feb 2024 12:20:09 -0800 (PST) From: Patrick Palka X-Google-Original-From: Patrick Palka Date: Wed, 14 Feb 2024 15:20:09 -0500 (EST) To: Ken Matsui cc: gcc-patches@gcc.gnu.org, libstdc++@gcc.gnu.org Subject: Re: [PATCH v2 3/4] c++: Implement __remove_extent built-in trait In-Reply-To: <20240214135252.1416047-3-kmatsui@gcc.gnu.org> Message-ID: <3c755462-9a60-4ba7-fbc0-214683c9ac1c@idea> References: <20240214114448.847646-1-kmatsui@gcc.gnu.org> <20240214135252.1416047-1-kmatsui@gcc.gnu.org> <20240214135252.1416047-3-kmatsui@gcc.gnu.org> MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=US-ASCII X-Spam-Status: No, score=-14.0 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H4,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Wed, 14 Feb 2024, Ken Matsui wrote: > This patch implements built-in trait for std::remove_extent. > > gcc/cp/ChangeLog: > > * cp-trait.def: Define __remove_extent. > * semantics.cc (finish_trait_type): Handle CPTK_REMOVE_EXTENT. > > gcc/testsuite/ChangeLog: > > * g++.dg/ext/has-builtin-1.C: Test existence of __remove_extent. > * g++.dg/ext/remove_extent.C: New test. LGTM > > Signed-off-by: Ken Matsui > --- > gcc/cp/cp-trait.def | 1 + > gcc/cp/semantics.cc | 5 +++++ > gcc/testsuite/g++.dg/ext/has-builtin-1.C | 3 +++ > gcc/testsuite/g++.dg/ext/remove_extent.C | 16 ++++++++++++++++ > 4 files changed, 25 insertions(+) > create mode 100644 gcc/testsuite/g++.dg/ext/remove_extent.C > > diff --git a/gcc/cp/cp-trait.def b/gcc/cp/cp-trait.def > index cec385ee501..3ff5611b60e 100644 > --- a/gcc/cp/cp-trait.def > +++ b/gcc/cp/cp-trait.def > @@ -96,6 +96,7 @@ DEFTRAIT_EXPR (REF_CONSTRUCTS_FROM_TEMPORARY, "__reference_constructs_from_tempo > DEFTRAIT_EXPR (REF_CONVERTS_FROM_TEMPORARY, "__reference_converts_from_temporary", 2) > DEFTRAIT_TYPE (REMOVE_CV, "__remove_cv", 1) > DEFTRAIT_TYPE (REMOVE_CVREF, "__remove_cvref", 1) > +DEFTRAIT_TYPE (REMOVE_EXTENT, "__remove_extent", 1) > DEFTRAIT_TYPE (REMOVE_POINTER, "__remove_pointer", 1) > DEFTRAIT_TYPE (REMOVE_REFERENCE, "__remove_reference", 1) > DEFTRAIT_TYPE (TYPE_PACK_ELEMENT, "__type_pack_element", -1) > diff --git a/gcc/cp/semantics.cc b/gcc/cp/semantics.cc > index e23693ab57f..bf998377c88 100644 > --- a/gcc/cp/semantics.cc > +++ b/gcc/cp/semantics.cc > @@ -12777,6 +12777,11 @@ finish_trait_type (cp_trait_kind kind, tree type1, tree type2, > type1 = TREE_TYPE (type1); > return cv_unqualified (type1); > > + case CPTK_REMOVE_EXTENT: > + if (TREE_CODE (type1) == ARRAY_TYPE) > + type1 = TREE_TYPE (type1); > + return type1; > + > case CPTK_REMOVE_POINTER: > if (TYPE_PTR_P (type1)) > type1 = TREE_TYPE (type1); > diff --git a/gcc/testsuite/g++.dg/ext/has-builtin-1.C b/gcc/testsuite/g++.dg/ext/has-builtin-1.C > index 56e8db7ac32..4f1094befb9 100644 > --- a/gcc/testsuite/g++.dg/ext/has-builtin-1.C > +++ b/gcc/testsuite/g++.dg/ext/has-builtin-1.C > @@ -170,6 +170,9 @@ > #if !__has_builtin (__remove_cvref) > # error "__has_builtin (__remove_cvref) failed" > #endif > +#if !__has_builtin (__remove_extent) > +# error "__has_builtin (__remove_extent) failed" > +#endif > #if !__has_builtin (__remove_pointer) > # error "__has_builtin (__remove_pointer) failed" > #endif > diff --git a/gcc/testsuite/g++.dg/ext/remove_extent.C b/gcc/testsuite/g++.dg/ext/remove_extent.C > new file mode 100644 > index 00000000000..6183aca5a48 > --- /dev/null > +++ b/gcc/testsuite/g++.dg/ext/remove_extent.C > @@ -0,0 +1,16 @@ > +// { dg-do compile { target c++11 } } > + > +#define SA(X) static_assert((X),#X) > + > +class ClassType { }; > + > +SA(__is_same(__remove_extent(int), int)); > +SA(__is_same(__remove_extent(int[2]), int)); > +SA(__is_same(__remove_extent(int[2][3]), int[3])); > +SA(__is_same(__remove_extent(int[][3]), int[3])); > +SA(__is_same(__remove_extent(const int[2]), const int)); > +SA(__is_same(__remove_extent(ClassType), ClassType)); > +SA(__is_same(__remove_extent(ClassType[2]), ClassType)); > +SA(__is_same(__remove_extent(ClassType[2][3]), ClassType[3])); > +SA(__is_same(__remove_extent(ClassType[][3]), ClassType[3])); > +SA(__is_same(__remove_extent(const ClassType[2]), const ClassType)); > -- > 2.43.0 > >