* [PATCH 4/4]: C++ P1423R3 char8_t remediation: New tests
@ 2019-09-15 19:40 Tom Honermann
2019-09-16 2:34 ` Tom Honermann
0 siblings, 1 reply; 9+ messages in thread
From: Tom Honermann @ 2019-09-15 19:40 UTC (permalink / raw)
To: libstdc++, gcc-patches
[-- Attachment #1: Type: text/plain, Size: 1141 bytes --]
This patch adds new tests to validate new deleted overloads of wchar_t,
char8_t, char16_t, and char32_t for ordinary and wide formatted
character and string ostream inserters.
Additionally, new tests are added to validate invocations of u8path with
sequences of char8_t for both the C++17 and filesystem TS implementations.
libstdc++-v3/ChangeLog:
2019-09-15 Tom Honermann <tom@honermann.net>
*
libstdc++-v3/testsuite/27_io/basic_ostream/inserters_character/char/deleted.cc:
New test to validate deleted overloads of character and string
inserters for narrow ostreams.
*
libstdc++-v3/testsuite/27_io/basic_ostream/inserters_character/wchar_t/deleted.cc:
New test to validate deleted overloads of character and string
inserters for wide ostreams.
*
libstdc++-v3/testsuite/27_io/filesystem/path/factory/u8path-char8_t.cc:
New test to validate u8path invocations with sequences of
char8_t.
*
libstdc++-v3/testsuite/experimental/filesystem/path/factory/u8path-char8_t.cc
New test to validate u8path invocations with sequences of
char8_t.
Tom.
[-- Attachment #2: p1423r3-4.patch --]
[-- Type: text/x-patch, Size: 7802 bytes --]
diff --git a/libstdc++-v3/testsuite/27_io/basic_ostream/inserters_character/char/deleted.cc b/libstdc++-v3/testsuite/27_io/basic_ostream/inserters_character/char/deleted.cc
new file mode 100644
index 00000000000..87afb295086
--- /dev/null
+++ b/libstdc++-v3/testsuite/27_io/basic_ostream/inserters_character/char/deleted.cc
@@ -0,0 +1,43 @@
+// Copyright (C) 2019 Free Software Foundation, Inc.
+//
+// This file is part of the GNU ISO C++ Library. This library is free
+// software; you can redistribute it and/or modify it under the
+// terms of the GNU General Public License as published by the
+// Free Software Foundation; either version 3, or (at your option)
+// any later version.
+
+// This library is distributed in the hope that it will be useful,
+// but WITHOUT ANY WARRANTY; without even the implied warranty of
+// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+// GNU General Public License for more details.
+
+// You should have received a copy of the GNU General Public License along
+// with this library; see the file COPYING3. If not see
+// <http://www.gnu.org/licenses/>.
+
+// 29.7.2 Header <ostream> synopsys; deleted character inserters.
+
+// Test character inserters defined as deleted by P1423.
+
+// { dg-options "-std=gnu++17 -fchar8_t" }
+// { dg-do compile { target c++17 } }
+
+#include <ostream>
+
+void test_character_inserters(std::ostream &os)
+{
+ os << 'x'; // ok.
+ os << L'x'; // { dg-error "use of deleted function" }
+ os << u8'x'; // { dg-error "use of deleted function" }
+ os << u'x'; // { dg-error "use of deleted function" }
+ os << U'x'; // { dg-error "use of deleted function" }
+}
+
+void test_string_inserters(std::ostream &os)
+{
+ os << "text"; // ok.
+ os << L"text"; // { dg-error "use of deleted function" }
+ os << u8"text"; // { dg-error "use of deleted function" }
+ os << u"text"; // { dg-error "use of deleted function" }
+ os << U"text"; // { dg-error "use of deleted function" }
+}
diff --git a/libstdc++-v3/testsuite/27_io/basic_ostream/inserters_character/wchar_t/deleted.cc b/libstdc++-v3/testsuite/27_io/basic_ostream/inserters_character/wchar_t/deleted.cc
new file mode 100644
index 00000000000..701de16822b
--- /dev/null
+++ b/libstdc++-v3/testsuite/27_io/basic_ostream/inserters_character/wchar_t/deleted.cc
@@ -0,0 +1,43 @@
+// Copyright (C) 2019 Free Software Foundation, Inc.
+//
+// This file is part of the GNU ISO C++ Library. This library is free
+// software; you can redistribute it and/or modify it under the
+// terms of the GNU General Public License as published by the
+// Free Software Foundation; either version 3, or (at your option)
+// any later version.
+
+// This library is distributed in the hope that it will be useful,
+// but WITHOUT ANY WARRANTY; without even the implied warranty of
+// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+// GNU General Public License for more details.
+
+// You should have received a copy of the GNU General Public License along
+// with this library; see the file COPYING3. If not see
+// <http://www.gnu.org/licenses/>.
+
+// 29.7.2 Header <ostream> synopsys; deleted character inserters.
+
+// Test wide character inserters defined as deleted by P1423.
+
+// { dg-options "-std=gnu++17 -fchar8_t" }
+// { dg-do compile { target c++17 } }
+
+#include <ostream>
+
+void test_character_inserters(std::wostream &os)
+{
+ os << 'x'; // ok.
+ os << L'x'; // ok.
+ os << u8'x'; // { dg-error "use of deleted function" }
+ os << u'x'; // { dg-error "use of deleted function" }
+ os << U'x'; // { dg-error "use of deleted function" }
+}
+
+void test_string_inserters(std::wostream &os)
+{
+ os << "text"; // ok.
+ os << L"text"; // ok.
+ os << u8"text"; // { dg-error "use of deleted function" }
+ os << u"text"; // { dg-error "use of deleted function" }
+ os << U"text"; // { dg-error "use of deleted function" }
+}
diff --git a/libstdc++-v3/testsuite/27_io/filesystem/path/factory/u8path-char8_t.cc b/libstdc++-v3/testsuite/27_io/filesystem/path/factory/u8path-char8_t.cc
new file mode 100644
index 00000000000..867ee5b3856
--- /dev/null
+++ b/libstdc++-v3/testsuite/27_io/filesystem/path/factory/u8path-char8_t.cc
@@ -0,0 +1,60 @@
+// Copyright (C) 2019 Free Software Foundation, Inc.
+//
+// This file is part of the GNU ISO C++ Library. This library is free
+// software; you can redistribute it and/or modify it under the
+// terms of the GNU General Public License as published by the
+// Free Software Foundation; either version 3, or (at your option)
+// any later version.
+
+// This library is distributed in the hope that it will be useful,
+// but WITHOUT ANY WARRANTY; without even the implied warranty of
+// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+// GNU General Public License for more details.
+
+// You should have received a copy of the GNU General Public License along
+// with this library; see the file COPYING3. If not see
+// <http://www.gnu.org/licenses/>.
+
+// { dg-options "-std=gnu++17 -fchar8_t" }
+// { dg-do run { target c++17 } }
+
+#include <filesystem>
+#include <string_view>
+#include <testsuite_hooks.h>
+
+namespace fs = std::filesystem;
+
+void
+test01()
+{
+ fs::path p = fs::u8path(u8"");
+ VERIFY( p.empty() );
+
+ p = fs::u8path(u8"filename1");
+ VERIFY( p.u8string() == u8"filename1" );
+
+ p = fs::u8path(u8"\xf0\x9d\x84\x9e");
+ VERIFY( p.u8string() == u8"\U0001D11E" );
+
+ std::u8string s1 = u8"filename2";
+ p = fs::u8path(s1);
+ VERIFY( p.u8string() == u8"filename2" );
+
+ std::u8string s2 = u8"filename3";
+ p = fs::u8path(s2.begin(), s2.end());
+ VERIFY( p.u8string() == u8"filename3" );
+
+ std::u8string_view sv1{ s1 };
+ p = fs::u8path(sv1);
+ VERIFY( p.u8string() == u8"filename2" );
+
+ std::u8string_view sv2{ s2 };
+ p = fs::u8path(sv2.begin(), sv2.end());
+ VERIFY( p.u8string() == u8"filename3" );
+}
+
+int
+main()
+{
+ test01();
+}
diff --git a/libstdc++-v3/testsuite/experimental/filesystem/path/factory/u8path-char8_t.cc b/libstdc++-v3/testsuite/experimental/filesystem/path/factory/u8path-char8_t.cc
new file mode 100644
index 00000000000..dc509c3f912
--- /dev/null
+++ b/libstdc++-v3/testsuite/experimental/filesystem/path/factory/u8path-char8_t.cc
@@ -0,0 +1,52 @@
+// Copyright (C) 2019 Free Software Foundation, Inc.
+//
+// This file is part of the GNU ISO C++ Library. This library is free
+// software; you can redistribute it and/or modify it under the
+// terms of the GNU General Public License as published by the
+// Free Software Foundation; either version 3, or (at your option)
+// any later version.
+
+// This library is distributed in the hope that it will be useful,
+// but WITHOUT ANY WARRANTY; without even the implied warranty of
+// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+// GNU General Public License for more details.
+
+// You should have received a copy of the GNU General Public License along
+// with this library; see the file COPYING3. If not see
+// <http://www.gnu.org/licenses/>.
+
+// { dg-options "-lstdc++fs -fchar8_t" }
+// { dg-do run { target c++11 } }
+// { dg-require-filesystem-ts "" }
+
+#include <experimental/filesystem>
+#include <testsuite_hooks.h>
+
+namespace fs = std::experimental::filesystem;
+
+void
+test01()
+{
+ fs::path p = fs::u8path(u8"");
+ VERIFY( p.empty() );
+
+ p = fs::u8path(u8"filename1");
+ VERIFY( p.u8string() == u8"filename1" );
+
+ p = fs::u8path(u8"\xf0\x9d\x84\x9e");
+ VERIFY( p.u8string() == u8"\U0001D11E" );
+
+ std::u8string s1 = u8"filename2";
+ p = fs::u8path(s1);
+ VERIFY( p.u8string() == u8"filename2" );
+
+ std::u8string s2 = u8"filename3";
+ p = fs::u8path(s2.begin(), s2.end());
+ VERIFY( p.u8string() == u8"filename3" );
+}
+
+int
+main()
+{
+ test01();
+}
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH 4/4]: C++ P1423R3 char8_t remediation: New tests
2019-09-15 19:40 [PATCH 4/4]: C++ P1423R3 char8_t remediation: New tests Tom Honermann
@ 2019-09-16 2:34 ` Tom Honermann
2019-12-03 8:11 ` Christophe Lyon
0 siblings, 1 reply; 9+ messages in thread
From: Tom Honermann @ 2019-09-16 2:34 UTC (permalink / raw)
To: libstdc++, gcc-patches
[-- Attachment #1: Type: text/plain, Size: 1670 bytes --]
A revised patch is attached that modifies the tests for deleted ostream
inserters to require C++2a. This is required by the revision of patch
2/4 that adds proper preprocessor conditionals to the definitions.
Tom.
On 9/15/19 3:40 PM, Tom Honermann wrote:
> This patch adds new tests to validate new deleted overloads of wchar_t,
> char8_t, char16_t, and char32_t for ordinary and wide formatted
> character and string ostream inserters.
>
> Additionally, new tests are added to validate invocations of u8path with
> sequences of char8_t for both the C++17 and filesystem TS implementations.
>
> libstdc++-v3/ChangeLog:
>
> 2019-09-15 Tom Honermann <tom@honermann.net>
>
> Â Â Â Â *
> libstdc++-v3/testsuite/27_io/basic_ostream/inserters_character/char/deleted.cc:
>
> Â Â Â Â Â Â New test to validate deleted overloads of character and string
> Â Â Â Â Â Â inserters for narrow ostreams.
> Â Â Â Â *
> libstdc++-v3/testsuite/27_io/basic_ostream/inserters_character/wchar_t/deleted.cc:
>
> Â Â Â Â Â Â New test to validate deleted overloads of character and string
> Â Â Â Â Â Â inserters for wide ostreams.
> Â Â Â Â *
> libstdc++-v3/testsuite/27_io/filesystem/path/factory/u8path-char8_t.cc:
> Â Â Â Â Â Â New test to validate u8path invocations with sequences of
> Â Â Â Â Â Â char8_t.
> Â Â Â Â *
> libstdc++-v3/testsuite/experimental/filesystem/path/factory/u8path-char8_t.cc
>
> Â Â Â Â Â Â New test to validate u8path invocations with sequences of
> Â Â Â Â Â Â char8_t.
>
> Tom.
[-- Attachment #2: p1423r3-4-2.patch --]
[-- Type: text/x-patch, Size: 8310 bytes --]
commit b7eb4714cc2c999ce0491358fcbcebf4a8723185
Author: Tom Honermann <tom@honermann.net>
Date: Sun Sep 15 22:25:28 2019 -0400
P1423R3 char8_t remediation: New tests
This patch adds new tests to validate new deleted overloads of wchar_t,
char8_t, char16_t, and char32_t for ordinary and wide formatted
character and string ostream inserters.
Additionally, new tests are added to validate invocations of u8path with
sequences of char8_t for both the C++17 and filesystem TS implementations.
diff --git a/libstdc++-v3/testsuite/27_io/basic_ostream/inserters_character/char/deleted.cc b/libstdc++-v3/testsuite/27_io/basic_ostream/inserters_character/char/deleted.cc
new file mode 100644
index 00000000000..f2eb538f42e
--- /dev/null
+++ b/libstdc++-v3/testsuite/27_io/basic_ostream/inserters_character/char/deleted.cc
@@ -0,0 +1,43 @@
+// Copyright (C) 2019 Free Software Foundation, Inc.
+//
+// This file is part of the GNU ISO C++ Library. This library is free
+// software; you can redistribute it and/or modify it under the
+// terms of the GNU General Public License as published by the
+// Free Software Foundation; either version 3, or (at your option)
+// any later version.
+
+// This library is distributed in the hope that it will be useful,
+// but WITHOUT ANY WARRANTY; without even the implied warranty of
+// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+// GNU General Public License for more details.
+
+// You should have received a copy of the GNU General Public License along
+// with this library; see the file COPYING3. If not see
+// <http://www.gnu.org/licenses/>.
+
+// 29.7.2 Header <ostream> synopsys; deleted character inserters.
+
+// Test character inserters defined as deleted by P1423.
+
+// { dg-options "-std=gnu++2a" }
+// { dg-do compile { target c++2a } }
+
+#include <ostream>
+
+void test_character_inserters(std::ostream &os)
+{
+ os << 'x'; // ok.
+ os << L'x'; // { dg-error "use of deleted function" }
+ os << u8'x'; // { dg-error "use of deleted function" }
+ os << u'x'; // { dg-error "use of deleted function" }
+ os << U'x'; // { dg-error "use of deleted function" }
+}
+
+void test_string_inserters(std::ostream &os)
+{
+ os << "text"; // ok.
+ os << L"text"; // { dg-error "use of deleted function" }
+ os << u8"text"; // { dg-error "use of deleted function" }
+ os << u"text"; // { dg-error "use of deleted function" }
+ os << U"text"; // { dg-error "use of deleted function" }
+}
diff --git a/libstdc++-v3/testsuite/27_io/basic_ostream/inserters_character/wchar_t/deleted.cc b/libstdc++-v3/testsuite/27_io/basic_ostream/inserters_character/wchar_t/deleted.cc
new file mode 100644
index 00000000000..1422a01aab3
--- /dev/null
+++ b/libstdc++-v3/testsuite/27_io/basic_ostream/inserters_character/wchar_t/deleted.cc
@@ -0,0 +1,43 @@
+// Copyright (C) 2019 Free Software Foundation, Inc.
+//
+// This file is part of the GNU ISO C++ Library. This library is free
+// software; you can redistribute it and/or modify it under the
+// terms of the GNU General Public License as published by the
+// Free Software Foundation; either version 3, or (at your option)
+// any later version.
+
+// This library is distributed in the hope that it will be useful,
+// but WITHOUT ANY WARRANTY; without even the implied warranty of
+// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+// GNU General Public License for more details.
+
+// You should have received a copy of the GNU General Public License along
+// with this library; see the file COPYING3. If not see
+// <http://www.gnu.org/licenses/>.
+
+// 29.7.2 Header <ostream> synopsys; deleted character inserters.
+
+// Test wide character inserters defined as deleted by P1423.
+
+// { dg-options "-std=gnu++2a" }
+// { dg-do compile { target c++2a } }
+
+#include <ostream>
+
+void test_character_inserters(std::wostream &os)
+{
+ os << 'x'; // ok.
+ os << L'x'; // ok.
+ os << u8'x'; // { dg-error "use of deleted function" }
+ os << u'x'; // { dg-error "use of deleted function" }
+ os << U'x'; // { dg-error "use of deleted function" }
+}
+
+void test_string_inserters(std::wostream &os)
+{
+ os << "text"; // ok.
+ os << L"text"; // ok.
+ os << u8"text"; // { dg-error "use of deleted function" }
+ os << u"text"; // { dg-error "use of deleted function" }
+ os << U"text"; // { dg-error "use of deleted function" }
+}
diff --git a/libstdc++-v3/testsuite/27_io/filesystem/path/factory/u8path-char8_t.cc b/libstdc++-v3/testsuite/27_io/filesystem/path/factory/u8path-char8_t.cc
new file mode 100644
index 00000000000..867ee5b3856
--- /dev/null
+++ b/libstdc++-v3/testsuite/27_io/filesystem/path/factory/u8path-char8_t.cc
@@ -0,0 +1,60 @@
+// Copyright (C) 2019 Free Software Foundation, Inc.
+//
+// This file is part of the GNU ISO C++ Library. This library is free
+// software; you can redistribute it and/or modify it under the
+// terms of the GNU General Public License as published by the
+// Free Software Foundation; either version 3, or (at your option)
+// any later version.
+
+// This library is distributed in the hope that it will be useful,
+// but WITHOUT ANY WARRANTY; without even the implied warranty of
+// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+// GNU General Public License for more details.
+
+// You should have received a copy of the GNU General Public License along
+// with this library; see the file COPYING3. If not see
+// <http://www.gnu.org/licenses/>.
+
+// { dg-options "-std=gnu++17 -fchar8_t" }
+// { dg-do run { target c++17 } }
+
+#include <filesystem>
+#include <string_view>
+#include <testsuite_hooks.h>
+
+namespace fs = std::filesystem;
+
+void
+test01()
+{
+ fs::path p = fs::u8path(u8"");
+ VERIFY( p.empty() );
+
+ p = fs::u8path(u8"filename1");
+ VERIFY( p.u8string() == u8"filename1" );
+
+ p = fs::u8path(u8"\xf0\x9d\x84\x9e");
+ VERIFY( p.u8string() == u8"\U0001D11E" );
+
+ std::u8string s1 = u8"filename2";
+ p = fs::u8path(s1);
+ VERIFY( p.u8string() == u8"filename2" );
+
+ std::u8string s2 = u8"filename3";
+ p = fs::u8path(s2.begin(), s2.end());
+ VERIFY( p.u8string() == u8"filename3" );
+
+ std::u8string_view sv1{ s1 };
+ p = fs::u8path(sv1);
+ VERIFY( p.u8string() == u8"filename2" );
+
+ std::u8string_view sv2{ s2 };
+ p = fs::u8path(sv2.begin(), sv2.end());
+ VERIFY( p.u8string() == u8"filename3" );
+}
+
+int
+main()
+{
+ test01();
+}
diff --git a/libstdc++-v3/testsuite/experimental/filesystem/path/factory/u8path-char8_t.cc b/libstdc++-v3/testsuite/experimental/filesystem/path/factory/u8path-char8_t.cc
new file mode 100644
index 00000000000..dc509c3f912
--- /dev/null
+++ b/libstdc++-v3/testsuite/experimental/filesystem/path/factory/u8path-char8_t.cc
@@ -0,0 +1,52 @@
+// Copyright (C) 2019 Free Software Foundation, Inc.
+//
+// This file is part of the GNU ISO C++ Library. This library is free
+// software; you can redistribute it and/or modify it under the
+// terms of the GNU General Public License as published by the
+// Free Software Foundation; either version 3, or (at your option)
+// any later version.
+
+// This library is distributed in the hope that it will be useful,
+// but WITHOUT ANY WARRANTY; without even the implied warranty of
+// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+// GNU General Public License for more details.
+
+// You should have received a copy of the GNU General Public License along
+// with this library; see the file COPYING3. If not see
+// <http://www.gnu.org/licenses/>.
+
+// { dg-options "-lstdc++fs -fchar8_t" }
+// { dg-do run { target c++11 } }
+// { dg-require-filesystem-ts "" }
+
+#include <experimental/filesystem>
+#include <testsuite_hooks.h>
+
+namespace fs = std::experimental::filesystem;
+
+void
+test01()
+{
+ fs::path p = fs::u8path(u8"");
+ VERIFY( p.empty() );
+
+ p = fs::u8path(u8"filename1");
+ VERIFY( p.u8string() == u8"filename1" );
+
+ p = fs::u8path(u8"\xf0\x9d\x84\x9e");
+ VERIFY( p.u8string() == u8"\U0001D11E" );
+
+ std::u8string s1 = u8"filename2";
+ p = fs::u8path(s1);
+ VERIFY( p.u8string() == u8"filename2" );
+
+ std::u8string s2 = u8"filename3";
+ p = fs::u8path(s2.begin(), s2.end());
+ VERIFY( p.u8string() == u8"filename3" );
+}
+
+int
+main()
+{
+ test01();
+}
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH 4/4]: C++ P1423R3 char8_t remediation: New tests
2019-09-16 2:34 ` Tom Honermann
@ 2019-12-03 8:11 ` Christophe Lyon
2019-12-03 9:16 ` Jonathan Wakely
0 siblings, 1 reply; 9+ messages in thread
From: Christophe Lyon @ 2019-12-03 8:11 UTC (permalink / raw)
To: Tom Honermann; +Cc: libstdc++, gcc-patches
On Mon, 16 Sep 2019 at 04:34, Tom Honermann <tom@honermann.net> wrote:
>
> A revised patch is attached that modifies the tests for deleted ostream
> inserters to require C++2a. This is required by the revision of patch
> 2/4 that adds proper preprocessor conditionals to the definitions.
>
> Tom.
>
> On 9/15/19 3:40 PM, Tom Honermann wrote:
> > This patch adds new tests to validate new deleted overloads of wchar_t,
> > char8_t, char16_t, and char32_t for ordinary and wide formatted
> > character and string ostream inserters.
> >
> > Additionally, new tests are added to validate invocations of u8path with
> > sequences of char8_t for both the C++17 and filesystem TS implementations.
> >
> > libstdc++-v3/ChangeLog:
> >
> > 2019-09-15 Tom Honermann <tom@honermann.net>
> >
> > *
> > libstdc++-v3/testsuite/27_io/basic_ostream/inserters_character/char/deleted.cc:
> >
> > New test to validate deleted overloads of character and string
> > inserters for narrow ostreams.
> > *
> > libstdc++-v3/testsuite/27_io/basic_ostream/inserters_character/wchar_t/deleted.cc:
> >
> > New test to validate deleted overloads of character and string
> > inserters for wide ostreams.
> > *
> > libstdc++-v3/testsuite/27_io/filesystem/path/factory/u8path-char8_t.cc:
> > New test to validate u8path invocations with sequences of
> > char8_t.
> > *
> > libstdc++-v3/testsuite/experimental/filesystem/path/factory/u8path-char8_t.cc
> >
> > New test to validate u8path invocations with sequences of
> > char8_t.
> >
Hi,
I've noticed that the new test
27_io/filesystem/path/factory/u8path-char8_t.cc
fails to compile on arm-none-eabi with default cpu/fpu, because:
/tools/arm-none-eabi/bin/ld:
/obj-arm-none-eabi/gcc3/arm-none-eabi/libstdc++-v3/src/.libs/libstdc++.a(string-inst.o):
in function `_ZNSt7__cxx1112basic_stringIcSt11char_traitsIcESaIcEEaSEOS4_':
string-inst.cc:(.text._ZNSt7__cxx1112basic_stringIcSt11char_traitsIcESaIcEEaSEOS4_[_ZNSt7__cxx1112basic_stringIcSt11char_traitsIcESaIcEEaSEOS4_]+0xf4):
undefined reference to `_ZSt15__alloc_on_moveISaIcEEvRT_S2_'
[etc...]
The one in experimental is unsupported thanks to
// { dg-require-filesystem-ts "" }
Should that be added to the version in 27_io?
Thanks,
Christophe
> > Tom.
>
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH 4/4]: C++ P1423R3 char8_t remediation: New tests
2019-12-03 8:11 ` Christophe Lyon
@ 2019-12-03 9:16 ` Jonathan Wakely
2019-12-05 8:01 ` Christophe Lyon
0 siblings, 1 reply; 9+ messages in thread
From: Jonathan Wakely @ 2019-12-03 9:16 UTC (permalink / raw)
To: Christophe Lyon; +Cc: Tom Honermann, libstdc++, gcc-patches
On 03/12/19 09:11 +0100, Christophe Lyon wrote:
>On Mon, 16 Sep 2019 at 04:34, Tom Honermann <tom@honermann.net> wrote:
>>
>> A revised patch is attached that modifies the tests for deleted ostream
>> inserters to require C++2a. This is required by the revision of patch
>> 2/4 that adds proper preprocessor conditionals to the definitions.
>>
>> Tom.
>>
>> On 9/15/19 3:40 PM, Tom Honermann wrote:
>> > This patch adds new tests to validate new deleted overloads of wchar_t,
>> > char8_t, char16_t, and char32_t for ordinary and wide formatted
>> > character and string ostream inserters.
>> >
>> > Additionally, new tests are added to validate invocations of u8path with
>> > sequences of char8_t for both the C++17 and filesystem TS implementations.
>> >
>> > libstdc++-v3/ChangeLog:
>> >
>> > 2019-09-15 Tom Honermann <tom@honermann.net>
>> >
>> > *
>> > libstdc++-v3/testsuite/27_io/basic_ostream/inserters_character/char/deleted.cc:
>> >
>> > New test to validate deleted overloads of character and string
>> > inserters for narrow ostreams.
>> > *
>> > libstdc++-v3/testsuite/27_io/basic_ostream/inserters_character/wchar_t/deleted.cc:
>> >
>> > New test to validate deleted overloads of character and string
>> > inserters for wide ostreams.
>> > *
>> > libstdc++-v3/testsuite/27_io/filesystem/path/factory/u8path-char8_t.cc:
>> > New test to validate u8path invocations with sequences of
>> > char8_t.
>> > *
>> > libstdc++-v3/testsuite/experimental/filesystem/path/factory/u8path-char8_t.cc
>> >
>> > New test to validate u8path invocations with sequences of
>> > char8_t.
>> >
>
>Hi,
>
>I've noticed that the new test
>27_io/filesystem/path/factory/u8path-char8_t.cc
>fails to compile on arm-none-eabi with default cpu/fpu, because:
>/tools/arm-none-eabi/bin/ld:
>/obj-arm-none-eabi/gcc3/arm-none-eabi/libstdc++-v3/src/.libs/libstdc++.a(string-inst.o):
>in function `_ZNSt7__cxx1112basic_stringIcSt11char_traitsIcESaIcEEaSEOS4_':
>string-inst.cc:(.text._ZNSt7__cxx1112basic_stringIcSt11char_traitsIcESaIcEEaSEOS4_[_ZNSt7__cxx1112basic_stringIcSt11char_traitsIcESaIcEEaSEOS4_]+0xf4):
>undefined reference to `_ZSt15__alloc_on_moveISaIcEEvRT_S2_'
>[etc...]
That function is defined inline and so should be instantiated in any
TU that needs it, and so should not give linker errors. There was a
similar bug reported the other day that turned out to be pilot error:
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=92733
>The one in experimental is unsupported thanks to
>// { dg-require-filesystem-ts "" }
>Should that be added to the version in 27_io?
No, the std::filesystem::path class has no dependencies, it should
work everywhere. I'm not sure what's happening here.
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH 4/4]: C++ P1423R3 char8_t remediation: New tests
2019-12-03 9:16 ` Jonathan Wakely
@ 2019-12-05 8:01 ` Christophe Lyon
2019-12-05 11:43 ` Jonathan Wakely
0 siblings, 1 reply; 9+ messages in thread
From: Christophe Lyon @ 2019-12-05 8:01 UTC (permalink / raw)
To: Jonathan Wakely; +Cc: Tom Honermann, libstdc++, gcc-patches
On Tue, 3 Dec 2019 at 10:16, Jonathan Wakely <jwakely@redhat.com> wrote:
>
> On 03/12/19 09:11 +0100, Christophe Lyon wrote:
> >On Mon, 16 Sep 2019 at 04:34, Tom Honermann <tom@honermann.net> wrote:
> >>
> >> A revised patch is attached that modifies the tests for deleted ostream
> >> inserters to require C++2a. This is required by the revision of patch
> >> 2/4 that adds proper preprocessor conditionals to the definitions.
> >>
> >> Tom.
> >>
> >> On 9/15/19 3:40 PM, Tom Honermann wrote:
> >> > This patch adds new tests to validate new deleted overloads of wchar_t,
> >> > char8_t, char16_t, and char32_t for ordinary and wide formatted
> >> > character and string ostream inserters.
> >> >
> >> > Additionally, new tests are added to validate invocations of u8path with
> >> > sequences of char8_t for both the C++17 and filesystem TS implementations.
> >> >
> >> > libstdc++-v3/ChangeLog:
> >> >
> >> > 2019-09-15 Tom Honermann <tom@honermann.net>
> >> >
> >> > *
> >> > libstdc++-v3/testsuite/27_io/basic_ostream/inserters_character/char/deleted.cc:
> >> >
> >> > New test to validate deleted overloads of character and string
> >> > inserters for narrow ostreams.
> >> > *
> >> > libstdc++-v3/testsuite/27_io/basic_ostream/inserters_character/wchar_t/deleted.cc:
> >> >
> >> > New test to validate deleted overloads of character and string
> >> > inserters for wide ostreams.
> >> > *
> >> > libstdc++-v3/testsuite/27_io/filesystem/path/factory/u8path-char8_t.cc:
> >> > New test to validate u8path invocations with sequences of
> >> > char8_t.
> >> > *
> >> > libstdc++-v3/testsuite/experimental/filesystem/path/factory/u8path-char8_t.cc
> >> >
> >> > New test to validate u8path invocations with sequences of
> >> > char8_t.
> >> >
> >
> >Hi,
> >
> >I've noticed that the new test
> >27_io/filesystem/path/factory/u8path-char8_t.cc
> >fails to compile on arm-none-eabi with default cpu/fpu, because:
> >/tools/arm-none-eabi/bin/ld:
> >/obj-arm-none-eabi/gcc3/arm-none-eabi/libstdc++-v3/src/.libs/libstdc++.a(string-inst.o):
> >in function `_ZNSt7__cxx1112basic_stringIcSt11char_traitsIcESaIcEEaSEOS4_':
> >string-inst.cc:(.text._ZNSt7__cxx1112basic_stringIcSt11char_traitsIcESaIcEEaSEOS4_[_ZNSt7__cxx1112basic_stringIcSt11char_traitsIcESaIcEEaSEOS4_]+0xf4):
> >undefined reference to `_ZSt15__alloc_on_moveISaIcEEvRT_S2_'
> >[etc...]
>
> That function is defined inline and so should be instantiated in any
> TU that needs it, and so should not give linker errors. There was a
> similar bug reported the other day that turned out to be pilot error:
> https://gcc.gnu.org/bugzilla/show_bug.cgi?id=92733
>
Hi,
Sorry for the delay, it took me a while to reproduce the problem manually.
I think I see this because I build that particular configuration with
CXXFLAGS_FOR_TARGET=-fno-threadsafe-statics
Does that sound plausible?
> >The one in experimental is unsupported thanks to
> >// { dg-require-filesystem-ts "" }
> >Should that be added to the version in 27_io?
>
> No, the std::filesystem::path class has no dependencies, it should
> work everywhere. I'm not sure what's happening here.
>
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH 4/4]: C++ P1423R3 char8_t remediation: New tests
2019-12-05 8:01 ` Christophe Lyon
@ 2019-12-05 11:43 ` Jonathan Wakely
2019-12-05 16:12 ` Christophe Lyon
0 siblings, 1 reply; 9+ messages in thread
From: Jonathan Wakely @ 2019-12-05 11:43 UTC (permalink / raw)
To: Christophe Lyon; +Cc: Tom Honermann, libstdc++, gcc-patches
On 05/12/19 09:00 +0100, Christophe Lyon wrote:
>On Tue, 3 Dec 2019 at 10:16, Jonathan Wakely <jwakely@redhat.com> wrote:
>>
>> On 03/12/19 09:11 +0100, Christophe Lyon wrote:
>> >On Mon, 16 Sep 2019 at 04:34, Tom Honermann <tom@honermann.net> wrote:
>> >>
>> >> A revised patch is attached that modifies the tests for deleted ostream
>> >> inserters to require C++2a. This is required by the revision of patch
>> >> 2/4 that adds proper preprocessor conditionals to the definitions.
>> >>
>> >> Tom.
>> >>
>> >> On 9/15/19 3:40 PM, Tom Honermann wrote:
>> >> > This patch adds new tests to validate new deleted overloads of wchar_t,
>> >> > char8_t, char16_t, and char32_t for ordinary and wide formatted
>> >> > character and string ostream inserters.
>> >> >
>> >> > Additionally, new tests are added to validate invocations of u8path with
>> >> > sequences of char8_t for both the C++17 and filesystem TS implementations.
>> >> >
>> >> > libstdc++-v3/ChangeLog:
>> >> >
>> >> > 2019-09-15 Tom Honermann <tom@honermann.net>
>> >> >
>> >> > *
>> >> > libstdc++-v3/testsuite/27_io/basic_ostream/inserters_character/char/deleted.cc:
>> >> >
>> >> > New test to validate deleted overloads of character and string
>> >> > inserters for narrow ostreams.
>> >> > *
>> >> > libstdc++-v3/testsuite/27_io/basic_ostream/inserters_character/wchar_t/deleted.cc:
>> >> >
>> >> > New test to validate deleted overloads of character and string
>> >> > inserters for wide ostreams.
>> >> > *
>> >> > libstdc++-v3/testsuite/27_io/filesystem/path/factory/u8path-char8_t.cc:
>> >> > New test to validate u8path invocations with sequences of
>> >> > char8_t.
>> >> > *
>> >> > libstdc++-v3/testsuite/experimental/filesystem/path/factory/u8path-char8_t.cc
>> >> >
>> >> > New test to validate u8path invocations with sequences of
>> >> > char8_t.
>> >> >
>> >
>> >Hi,
>> >
>> >I've noticed that the new test
>> >27_io/filesystem/path/factory/u8path-char8_t.cc
>> >fails to compile on arm-none-eabi with default cpu/fpu, because:
>> >/tools/arm-none-eabi/bin/ld:
>> >/obj-arm-none-eabi/gcc3/arm-none-eabi/libstdc++-v3/src/.libs/libstdc++.a(string-inst.o):
>> >in function `_ZNSt7__cxx1112basic_stringIcSt11char_traitsIcESaIcEEaSEOS4_':
>> >string-inst.cc:(.text._ZNSt7__cxx1112basic_stringIcSt11char_traitsIcESaIcEEaSEOS4_[_ZNSt7__cxx1112basic_stringIcSt11char_traitsIcESaIcEEaSEOS4_]+0xf4):
>> >undefined reference to `_ZSt15__alloc_on_moveISaIcEEvRT_S2_'
>> >[etc...]
>>
>> That function is defined inline and so should be instantiated in any
>> TU that needs it, and so should not give linker errors. There was a
>> similar bug reported the other day that turned out to be pilot error:
>> https://gcc.gnu.org/bugzilla/show_bug.cgi?id=92733
>>
>Hi,
>Sorry for the delay, it took me a while to reproduce the problem manually.
>I think I see this because I build that particular configuration with
>CXXFLAGS_FOR_TARGET=-fno-threadsafe-statics
>
>Does that sound plausible?
Not really ... I still don't know why that function template would
ever be undefined.
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH 4/4]: C++ P1423R3 char8_t remediation: New tests
2019-12-05 11:43 ` Jonathan Wakely
@ 2019-12-05 16:12 ` Christophe Lyon
2019-12-19 9:36 ` Jonathan Wakely
0 siblings, 1 reply; 9+ messages in thread
From: Christophe Lyon @ 2019-12-05 16:12 UTC (permalink / raw)
To: Jonathan Wakely; +Cc: Tom Honermann, libstdc++, gcc-patches
On Thu, 5 Dec 2019 at 12:43, Jonathan Wakely <jwakely@redhat.com> wrote:
>
> On 05/12/19 09:00 +0100, Christophe Lyon wrote:
> >On Tue, 3 Dec 2019 at 10:16, Jonathan Wakely <jwakely@redhat.com> wrote:
> >>
> >> On 03/12/19 09:11 +0100, Christophe Lyon wrote:
> >> >On Mon, 16 Sep 2019 at 04:34, Tom Honermann <tom@honermann.net> wrote:
> >> >>
> >> >> A revised patch is attached that modifies the tests for deleted ostream
> >> >> inserters to require C++2a. This is required by the revision of patch
> >> >> 2/4 that adds proper preprocessor conditionals to the definitions.
> >> >>
> >> >> Tom.
> >> >>
> >> >> On 9/15/19 3:40 PM, Tom Honermann wrote:
> >> >> > This patch adds new tests to validate new deleted overloads of wchar_t,
> >> >> > char8_t, char16_t, and char32_t for ordinary and wide formatted
> >> >> > character and string ostream inserters.
> >> >> >
> >> >> > Additionally, new tests are added to validate invocations of u8path with
> >> >> > sequences of char8_t for both the C++17 and filesystem TS implementations.
> >> >> >
> >> >> > libstdc++-v3/ChangeLog:
> >> >> >
> >> >> > 2019-09-15 Tom Honermann <tom@honermann.net>
> >> >> >
> >> >> > *
> >> >> > libstdc++-v3/testsuite/27_io/basic_ostream/inserters_character/char/deleted.cc:
> >> >> >
> >> >> > New test to validate deleted overloads of character and string
> >> >> > inserters for narrow ostreams.
> >> >> > *
> >> >> > libstdc++-v3/testsuite/27_io/basic_ostream/inserters_character/wchar_t/deleted.cc:
> >> >> >
> >> >> > New test to validate deleted overloads of character and string
> >> >> > inserters for wide ostreams.
> >> >> > *
> >> >> > libstdc++-v3/testsuite/27_io/filesystem/path/factory/u8path-char8_t.cc:
> >> >> > New test to validate u8path invocations with sequences of
> >> >> > char8_t.
> >> >> > *
> >> >> > libstdc++-v3/testsuite/experimental/filesystem/path/factory/u8path-char8_t.cc
> >> >> >
> >> >> > New test to validate u8path invocations with sequences of
> >> >> > char8_t.
> >> >> >
> >> >
> >> >Hi,
> >> >
> >> >I've noticed that the new test
> >> >27_io/filesystem/path/factory/u8path-char8_t.cc
> >> >fails to compile on arm-none-eabi with default cpu/fpu, because:
> >> >/tools/arm-none-eabi/bin/ld:
> >> >/obj-arm-none-eabi/gcc3/arm-none-eabi/libstdc++-v3/src/.libs/libstdc++.a(string-inst.o):
> >> >in function `_ZNSt7__cxx1112basic_stringIcSt11char_traitsIcESaIcEEaSEOS4_':
> >> >string-inst.cc:(.text._ZNSt7__cxx1112basic_stringIcSt11char_traitsIcESaIcEEaSEOS4_[_ZNSt7__cxx1112basic_stringIcSt11char_traitsIcESaIcEEaSEOS4_]+0xf4):
> >> >undefined reference to `_ZSt15__alloc_on_moveISaIcEEvRT_S2_'
> >> >[etc...]
> >>
> >> That function is defined inline and so should be instantiated in any
> >> TU that needs it, and so should not give linker errors. There was a
> >> similar bug reported the other day that turned out to be pilot error:
> >> https://gcc.gnu.org/bugzilla/show_bug.cgi?id=92733
> >>
> >Hi,
> >Sorry for the delay, it took me a while to reproduce the problem manually.
> >I think I see this because I build that particular configuration with
> >CXXFLAGS_FOR_TARGET=-fno-threadsafe-statics
> >
> >Does that sound plausible?
>
> Not really ... I still don't know why that function template would
> ever be undefined.
>
Hmmm that's because doing CXXFLAGS_FOR_TARGET means that the generated
Makefile contains:
CXXFLAGS = -fno-threadsafe-statics
while if I don't define CXXFLAGS_FOR_TARGET, it contains
CXXFLAGS = -g -O2 -D_GNU_SOURCE
Re-compiling string-inst with -O2 removes the undefined reference
Sigh... looks like I fixed something similar 7 years ago :-(
https://gcc.gnu.org/viewcvs/gcc?view=revision&revision=189046
So... the current configure.ac code makes sure -O2 and -g are present
in CXXFLAGS_FOR_TARGET only if it's derived from CXXFLAGS, which
happens only when CXXFLAGS_FOR_TARGET is NOT overridden, and not
cross-compiling...
We have:
case " $CXXFLAGS " in
*" -O2 "*) ;;
*) CXXFLAGS_FOR_TARGET="-O2 $CXXFLAGS_FOR_TARGET" ;;
esac
Why isn't it case "$CXXFLAGS_FOR_TARGET" instead? And that whole
case/esac should be after the 'fi'.
Or is it that way on purpose?
So it seems the fix for the problem I saw is for me to use
CXXFLAGS_FOR_TARGET="-O2 -g -fno-threadsafe-statics"
Christophe
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH 4/4]: C++ P1423R3 char8_t remediation: New tests
2019-12-05 16:12 ` Christophe Lyon
@ 2019-12-19 9:36 ` Jonathan Wakely
2019-12-20 17:11 ` Jonathan Wakely
0 siblings, 1 reply; 9+ messages in thread
From: Jonathan Wakely @ 2019-12-19 9:36 UTC (permalink / raw)
To: Christophe Lyon; +Cc: Tom Honermann, libstdc++, gcc-patches
On 05/12/19 17:12 +0100, Christophe Lyon wrote:
>On Thu, 5 Dec 2019 at 12:43, Jonathan Wakely <jwakely@redhat.com> wrote:
>>
>> On 05/12/19 09:00 +0100, Christophe Lyon wrote:
>> >On Tue, 3 Dec 2019 at 10:16, Jonathan Wakely <jwakely@redhat.com> wrote:
>> >>
>> >> On 03/12/19 09:11 +0100, Christophe Lyon wrote:
>> >> >On Mon, 16 Sep 2019 at 04:34, Tom Honermann <tom@honermann.net> wrote:
>> >> >>
>> >> >> A revised patch is attached that modifies the tests for deleted ostream
>> >> >> inserters to require C++2a. This is required by the revision of patch
>> >> >> 2/4 that adds proper preprocessor conditionals to the definitions.
>> >> >>
>> >> >> Tom.
>> >> >>
>> >> >> On 9/15/19 3:40 PM, Tom Honermann wrote:
>> >> >> > This patch adds new tests to validate new deleted overloads of wchar_t,
>> >> >> > char8_t, char16_t, and char32_t for ordinary and wide formatted
>> >> >> > character and string ostream inserters.
>> >> >> >
>> >> >> > Additionally, new tests are added to validate invocations of u8path with
>> >> >> > sequences of char8_t for both the C++17 and filesystem TS implementations.
>> >> >> >
>> >> >> > libstdc++-v3/ChangeLog:
>> >> >> >
>> >> >> > 2019-09-15 Tom Honermann <tom@honermann.net>
>> >> >> >
>> >> >> > *
>> >> >> > libstdc++-v3/testsuite/27_io/basic_ostream/inserters_character/char/deleted.cc:
>> >> >> >
>> >> >> > New test to validate deleted overloads of character and string
>> >> >> > inserters for narrow ostreams.
>> >> >> > *
>> >> >> > libstdc++-v3/testsuite/27_io/basic_ostream/inserters_character/wchar_t/deleted.cc:
>> >> >> >
>> >> >> > New test to validate deleted overloads of character and string
>> >> >> > inserters for wide ostreams.
>> >> >> > *
>> >> >> > libstdc++-v3/testsuite/27_io/filesystem/path/factory/u8path-char8_t.cc:
>> >> >> > New test to validate u8path invocations with sequences of
>> >> >> > char8_t.
>> >> >> > *
>> >> >> > libstdc++-v3/testsuite/experimental/filesystem/path/factory/u8path-char8_t.cc
>> >> >> >
>> >> >> > New test to validate u8path invocations with sequences of
>> >> >> > char8_t.
>> >> >> >
>> >> >
>> >> >Hi,
>> >> >
>> >> >I've noticed that the new test
>> >> >27_io/filesystem/path/factory/u8path-char8_t.cc
>> >> >fails to compile on arm-none-eabi with default cpu/fpu, because:
>> >> >/tools/arm-none-eabi/bin/ld:
>> >> >/obj-arm-none-eabi/gcc3/arm-none-eabi/libstdc++-v3/src/.libs/libstdc++.a(string-inst.o):
>> >> >in function `_ZNSt7__cxx1112basic_stringIcSt11char_traitsIcESaIcEEaSEOS4_':
>> >> >string-inst.cc:(.text._ZNSt7__cxx1112basic_stringIcSt11char_traitsIcESaIcEEaSEOS4_[_ZNSt7__cxx1112basic_stringIcSt11char_traitsIcESaIcEEaSEOS4_]+0xf4):
>> >> >undefined reference to `_ZSt15__alloc_on_moveISaIcEEvRT_S2_'
>> >> >[etc...]
>> >>
>> >> That function is defined inline and so should be instantiated in any
>> >> TU that needs it, and so should not give linker errors. There was a
>> >> similar bug reported the other day that turned out to be pilot error:
>> >> https://gcc.gnu.org/bugzilla/show_bug.cgi?id=92733
>> >>
>> >Hi,
>> >Sorry for the delay, it took me a while to reproduce the problem manually.
>> >I think I see this because I build that particular configuration with
>> >CXXFLAGS_FOR_TARGET=-fno-threadsafe-statics
>> >
>> >Does that sound plausible?
>>
>> Not really ... I still don't know why that function template would
>> ever be undefined.
>>
>
>Hmmm that's because doing CXXFLAGS_FOR_TARGET means that the generated
>Makefile contains:
>CXXFLAGS = -fno-threadsafe-statics
>while if I don't define CXXFLAGS_FOR_TARGET, it contains
>CXXFLAGS = -g -O2 -D_GNU_SOURCE
>
>Re-compiling string-inst with -O2 removes the undefined reference
>
>Sigh... looks like I fixed something similar 7 years ago :-(
>https://gcc.gnu.org/viewcvs/gcc?view=revision&revision=189046
>
>So... the current configure.ac code makes sure -O2 and -g are present
>in CXXFLAGS_FOR_TARGET only if it's derived from CXXFLAGS, which
>happens only when CXXFLAGS_FOR_TARGET is NOT overridden, and not
>cross-compiling...
>
>We have:
> case " $CXXFLAGS " in
> *" -O2 "*) ;;
> *) CXXFLAGS_FOR_TARGET="-O2 $CXXFLAGS_FOR_TARGET" ;;
> esac
>
>Why isn't it case "$CXXFLAGS_FOR_TARGET" instead? And that whole
>case/esac should be after the 'fi'.
>Or is it that way on purpose?
>
>So it seems the fix for the problem I saw is for me to use
>CXXFLAGS_FOR_TARGET="-O2 -g -fno-threadsafe-statics"
This is https://gcc.gnu.org/bugzilla/show_bug.cgi?id=92927 and thanks
to the bisected revision number in the PR I see what the problem is.
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH 4/4]: C++ P1423R3 char8_t remediation: New tests
2019-12-19 9:36 ` Jonathan Wakely
@ 2019-12-20 17:11 ` Jonathan Wakely
0 siblings, 0 replies; 9+ messages in thread
From: Jonathan Wakely @ 2019-12-20 17:11 UTC (permalink / raw)
To: Christophe Lyon; +Cc: Tom Honermann, libstdc++, gcc-patches
[-- Attachment #1: Type: text/plain, Size: 5171 bytes --]
On 19/12/19 09:36 +0000, Jonathan Wakely wrote:
>On 05/12/19 17:12 +0100, Christophe Lyon wrote:
>>On Thu, 5 Dec 2019 at 12:43, Jonathan Wakely <jwakely@redhat.com> wrote:
>>>
>>>On 05/12/19 09:00 +0100, Christophe Lyon wrote:
>>>>On Tue, 3 Dec 2019 at 10:16, Jonathan Wakely <jwakely@redhat.com> wrote:
>>>>>
>>>>> On 03/12/19 09:11 +0100, Christophe Lyon wrote:
>>>>> >On Mon, 16 Sep 2019 at 04:34, Tom Honermann <tom@honermann.net> wrote:
>>>>> >>
>>>>> >> A revised patch is attached that modifies the tests for deleted ostream
>>>>> >> inserters to require C++2a. This is required by the revision of patch
>>>>> >> 2/4 that adds proper preprocessor conditionals to the definitions.
>>>>> >>
>>>>> >> Tom.
>>>>> >>
>>>>> >> On 9/15/19 3:40 PM, Tom Honermann wrote:
>>>>> >> > This patch adds new tests to validate new deleted overloads of wchar_t,
>>>>> >> > char8_t, char16_t, and char32_t for ordinary and wide formatted
>>>>> >> > character and string ostream inserters.
>>>>> >> >
>>>>> >> > Additionally, new tests are added to validate invocations of u8path with
>>>>> >> > sequences of char8_t for both the C++17 and filesystem TS implementations.
>>>>> >> >
>>>>> >> > libstdc++-v3/ChangeLog:
>>>>> >> >
>>>>> >> > 2019-09-15 Tom Honermann <tom@honermann.net>
>>>>> >> >
>>>>> >> > *
>>>>> >> > libstdc++-v3/testsuite/27_io/basic_ostream/inserters_character/char/deleted.cc:
>>>>> >> >
>>>>> >> > New test to validate deleted overloads of character and string
>>>>> >> > inserters for narrow ostreams.
>>>>> >> > *
>>>>> >> > libstdc++-v3/testsuite/27_io/basic_ostream/inserters_character/wchar_t/deleted.cc:
>>>>> >> >
>>>>> >> > New test to validate deleted overloads of character and string
>>>>> >> > inserters for wide ostreams.
>>>>> >> > *
>>>>> >> > libstdc++-v3/testsuite/27_io/filesystem/path/factory/u8path-char8_t.cc:
>>>>> >> > New test to validate u8path invocations with sequences of
>>>>> >> > char8_t.
>>>>> >> > *
>>>>> >> > libstdc++-v3/testsuite/experimental/filesystem/path/factory/u8path-char8_t.cc
>>>>> >> >
>>>>> >> > New test to validate u8path invocations with sequences of
>>>>> >> > char8_t.
>>>>> >> >
>>>>> >
>>>>> >Hi,
>>>>> >
>>>>> >I've noticed that the new test
>>>>> >27_io/filesystem/path/factory/u8path-char8_t.cc
>>>>> >fails to compile on arm-none-eabi with default cpu/fpu, because:
>>>>> >/tools/arm-none-eabi/bin/ld:
>>>>> >/obj-arm-none-eabi/gcc3/arm-none-eabi/libstdc++-v3/src/.libs/libstdc++.a(string-inst.o):
>>>>> >in function `_ZNSt7__cxx1112basic_stringIcSt11char_traitsIcESaIcEEaSEOS4_':
>>>>> >string-inst.cc:(.text._ZNSt7__cxx1112basic_stringIcSt11char_traitsIcESaIcEEaSEOS4_[_ZNSt7__cxx1112basic_stringIcSt11char_traitsIcESaIcEEaSEOS4_]+0xf4):
>>>>> >undefined reference to `_ZSt15__alloc_on_moveISaIcEEvRT_S2_'
>>>>> >[etc...]
>>>>>
>>>>> That function is defined inline and so should be instantiated in any
>>>>> TU that needs it, and so should not give linker errors. There was a
>>>>> similar bug reported the other day that turned out to be pilot error:
>>>>> https://gcc.gnu.org/bugzilla/show_bug.cgi?id=92733
>>>>>
>>>>Hi,
>>>>Sorry for the delay, it took me a while to reproduce the problem manually.
>>>>I think I see this because I build that particular configuration with
>>>>CXXFLAGS_FOR_TARGET=-fno-threadsafe-statics
>>>>
>>>>Does that sound plausible?
>>>
>>>Not really ... I still don't know why that function template would
>>>ever be undefined.
>>>
>>
>>Hmmm that's because doing CXXFLAGS_FOR_TARGET means that the generated
>>Makefile contains:
>>CXXFLAGS = -fno-threadsafe-statics
>>while if I don't define CXXFLAGS_FOR_TARGET, it contains
>>CXXFLAGS = -g -O2 -D_GNU_SOURCE
>>
>>Re-compiling string-inst with -O2 removes the undefined reference
>>
>>Sigh... looks like I fixed something similar 7 years ago :-(
>>https://gcc.gnu.org/viewcvs/gcc?view=revision&revision=189046
>>
>>So... the current configure.ac code makes sure -O2 and -g are present
>>in CXXFLAGS_FOR_TARGET only if it's derived from CXXFLAGS, which
>>happens only when CXXFLAGS_FOR_TARGET is NOT overridden, and not
>>cross-compiling...
>>
>>We have:
>> case " $CXXFLAGS " in
>> *" -O2 "*) ;;
>> *) CXXFLAGS_FOR_TARGET="-O2 $CXXFLAGS_FOR_TARGET" ;;
>> esac
>>
>>Why isn't it case "$CXXFLAGS_FOR_TARGET" instead? And that whole
>>case/esac should be after the 'fi'.
>>Or is it that way on purpose?
>>
>>So it seems the fix for the problem I saw is for me to use
>>CXXFLAGS_FOR_TARGET="-O2 -g -fno-threadsafe-statics"
>
>This is https://gcc.gnu.org/bugzilla/show_bug.cgi?id=92927 and thanks
>to the bisected revision number in the PR I see what the problem is.
To be clear, PR 92927 is about the undefined references when building
with -O0, and will be fixed soon by the attached patch that I've just
committed to trunk.
I don't know the answer to the question about CXXFLAGS_FOR_TARGET, and
don't know if it's that way on purpose. Please feel free to create a
bug for it, or propose a patch.
[-- Attachment #2: patch.txt --]
[-- Type: text/x-patch, Size: 1820 bytes --]
commit 5adbd32971c31ec3f0d05f883aba6015f98fbc33
Author: Jonathan Wakely <jwakely@redhat.com>
Date: Fri Dec 20 11:03:40 2019 +0000
libstdc++: Add inline to maybe-constexpr functions (PR 92927)
Originally these functions were always inline. I changed them in r277342
to be always constexpr, then in r277588 changed them to be constexpr for
C++14, but I didn't restore the 'inline' for C++11. That leads to linker
errors when libstdc++.so is built unoptimized, because those functions
don't get instantiated in src/c++11/string-inst.o
PR libstdc++/92927
* include/bits/alloc_traits.h (__alloc_on_copy, __alloc_on_move)
(__alloc_on_swap): Add inline specifier.
diff --git a/libstdc++-v3/include/bits/alloc_traits.h b/libstdc++-v3/include/bits/alloc_traits.h
index 142b23fe00f..812cff0fabe 100644
--- a/libstdc++-v3/include/bits/alloc_traits.h
+++ b/libstdc++-v3/include/bits/alloc_traits.h
@@ -567,7 +567,7 @@ _GLIBCXX_BEGIN_NAMESPACE_VERSION
#endif
template<typename _Alloc>
- _GLIBCXX14_CONSTEXPR void
+ _GLIBCXX14_CONSTEXPR inline void
__alloc_on_copy(_Alloc& __one, const _Alloc& __two)
{
typedef allocator_traits<_Alloc> __traits;
@@ -599,7 +599,7 @@ _GLIBCXX_BEGIN_NAMESPACE_VERSION
#endif
template<typename _Alloc>
- _GLIBCXX14_CONSTEXPR void
+ _GLIBCXX14_CONSTEXPR inline void
__alloc_on_move(_Alloc& __one, _Alloc& __two)
{
typedef allocator_traits<_Alloc> __traits;
@@ -626,7 +626,7 @@ _GLIBCXX_BEGIN_NAMESPACE_VERSION
#endif
template<typename _Alloc>
- _GLIBCXX14_CONSTEXPR void
+ _GLIBCXX14_CONSTEXPR inline void
__alloc_on_swap(_Alloc& __one, _Alloc& __two)
{
typedef allocator_traits<_Alloc> __traits;
^ permalink raw reply [flat|nested] 9+ messages in thread
end of thread, other threads:[~2019-12-20 17:11 UTC | newest]
Thread overview: 9+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-09-15 19:40 [PATCH 4/4]: C++ P1423R3 char8_t remediation: New tests Tom Honermann
2019-09-16 2:34 ` Tom Honermann
2019-12-03 8:11 ` Christophe Lyon
2019-12-03 9:16 ` Jonathan Wakely
2019-12-05 8:01 ` Christophe Lyon
2019-12-05 11:43 ` Jonathan Wakely
2019-12-05 16:12 ` Christophe Lyon
2019-12-19 9:36 ` Jonathan Wakely
2019-12-20 17:11 ` Jonathan Wakely
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).