From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id A78F6384AB78 for ; Thu, 2 May 2024 19:49:49 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org A78F6384AB78 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org A78F6384AB78 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=170.10.129.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1714679394; cv=none; b=oxgZzWOrnv8ULrLRNTFObqP2mtcgugkAQxGvr+skliZbpb0SheyKhHvPkFqBebpiBpiIFvwCtWl4pjZ4fYi/xCn7K+SfD37UsaT1ni2oGdo/eEVp3ONMsaShY2KFMXL5alZs20kx7KTztIDuNq4BkuW69UFzP/SnCVzoQHok7TY= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1714679394; c=relaxed/simple; bh=TI+wuQ62uLobCAQgtCNiqIorZ3X3Sl1XTY/zblwxMcg=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=roB/Fmrt9wA0nEO87hFSn5MtaGHew/iu1d9k+RD8N4s4oXdT9hp6F3nPDiNG7ID9MdyzlbY5WGRc7wlzcnEs+Rl2flLyAkSnKS5RErAInwOzCfXu4gHmHdgTFL17J7q/Z6qgxtKUgqwbu2PA8Fj9GLi36wvtoGc2Ax4x3UGiwKk= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1714679389; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=f7tNtMuxrOEX9v+3rCd+qWkKDTVfeIDT4pqMYN6tpQo=; b=eFmO4kFgpt1ayvDSGmRqesmGezU+f1rN5fFvSjKhWIMYjgeKlv5+wIu6bLC7Vl6kXuYrre NZ/uLZMIIJVzg4avtHVX9Nf0quczb/R8wCJeIc/8UurXHzV8LbIxna1gqUd7T2sGr75n+4 cxFVk3tFW0Z0E07hGnk+oyp23haXItg= Received: from mail-oo1-f71.google.com (mail-oo1-f71.google.com [209.85.161.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-231-MN2Ks1nsODGp3QTkpMeeSA-1; Thu, 02 May 2024 15:49:48 -0400 X-MC-Unique: MN2Ks1nsODGp3QTkpMeeSA-1 Received: by mail-oo1-f71.google.com with SMTP id 006d021491bc7-5acd51e4692so10803991eaf.0 for ; Thu, 02 May 2024 12:49:47 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1714679386; x=1715284186; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=f7tNtMuxrOEX9v+3rCd+qWkKDTVfeIDT4pqMYN6tpQo=; b=JvFWhL1rgoUuFTDbvs3OhB0Z7kW4DVXnEFzxRQ0ya03B2gW0w4ik0C96dhXolbpKFl +npde3Bij76m1gFIcsbb9snLueHY9YhPTFrFCh/aQ64wGLN4y5SB1MVcdOZIOroPLpUQ b/xianJEQaKK+AGLd65Abe4GOv1Zv1S4oi7XJoXwO2IbaY8ipssAAK2Zm+JIZ7tB/MJb 37Seig+jVm+BwX0SINsh7ajKoou9wv5UUQHgbxgiz1svvv8Cz12ZDHUNPlwes/ZEwlWe 9vkSbog7yEDgosOFksv+vEKIGOvsJi5JNaREEGjgSPrNsyA0a+sCSSH9Ajg7wpTtqd0s X8bA== X-Gm-Message-State: AOJu0YyLdWVcIKYkDvF44Zox45Xbdr4o5OJBlpTGtKM4i/9Xrb5HOe0D WxOOR9bLqviWa/AD/5Md8LpZfTnRAi56hYO2kS9e71e/bLqRHLUgfqrWU2U/60Rd9FPzuGlKzLK CmccKLKXv//d/w4/EZh3uBJAnnDHSTBK0pq5A3J5o2dExn9ipM5P3 X-Received: by 2002:a05:6358:52cf:b0:18a:5c27:7032 with SMTP id z15-20020a05635852cf00b0018a5c277032mr494424rwz.13.1714679386288; Thu, 02 May 2024 12:49:46 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEcMWHCTZTBHMR0hp6ep4G2H2WC8l3lzAFfjIlo6NLQwcfKPXBJel9oC2mSTKjxhKlWeamtQQ== X-Received: by 2002:a05:6358:52cf:b0:18a:5c27:7032 with SMTP id z15-20020a05635852cf00b0018a5c277032mr494407rwz.13.1714679385702; Thu, 02 May 2024 12:49:45 -0700 (PDT) Received: from [192.168.1.130] (130-44-146-16.s12558.c3-0.arl-cbr1.sbo-arl.ma.cable.rcncustomer.com. [130.44.146.16]) by smtp.gmail.com with ESMTPSA id cd14-20020a05622a418e00b0043791f7d831sm756416qtb.63.2024.05.02.12.49.44 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 02 May 2024 12:49:44 -0700 (PDT) Message-ID: <4702d376-6360-44c6-83b8-5154dd00fbdb@redhat.com> Date: Thu, 2 May 2024 15:49:44 -0400 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v17 03/26] c++: Implement __is_volatile built-in trait To: Ken Matsui , gcc-patches@gcc.gnu.org Cc: libstdc++@gcc.gnu.org References: <20240502161614.3705912-1-kmatsui@gcc.gnu.org> <20240502184529.97337-1-kmatsui@gcc.gnu.org> <20240502184529.97337-4-kmatsui@gcc.gnu.org> From: Jason Merrill In-Reply-To: <20240502184529.97337-4-kmatsui@gcc.gnu.org> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-13.0 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H4,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 5/2/24 14:42, Ken Matsui wrote: > This patch implements built-in trait for std::is_volatile. OK. > gcc/cp/ChangeLog: > > * cp-trait.def: Define __is_volatile. > * constraint.cc (diagnose_trait_expr): Handle CPTK_IS_VOLATILE. > * semantics.cc (trait_expr_value): Likewise. > (finish_trait_expr): Likewise. > > gcc/testsuite/ChangeLog: > > * g++.dg/ext/has-builtin-1.C: Test existence of __is_volatile. > * g++.dg/ext/is_volatile.C: New test. > > Signed-off-by: Ken Matsui > --- > gcc/cp/constraint.cc | 3 +++ > gcc/cp/cp-trait.def | 1 + > gcc/cp/semantics.cc | 4 ++++ > gcc/testsuite/g++.dg/ext/has-builtin-1.C | 3 +++ > gcc/testsuite/g++.dg/ext/is_volatile.C | 20 ++++++++++++++++++++ > 5 files changed, 31 insertions(+) > create mode 100644 gcc/testsuite/g++.dg/ext/is_volatile.C > > diff --git a/gcc/cp/constraint.cc b/gcc/cp/constraint.cc > index eaf17a50877..d9caf546423 100644 > --- a/gcc/cp/constraint.cc > +++ b/gcc/cp/constraint.cc > @@ -3862,6 +3862,9 @@ diagnose_trait_expr (tree expr, tree args) > case CPTK_IS_UNION: > inform (loc, " %qT is not a union", t1); > break; > + case CPTK_IS_VOLATILE: > + inform (loc, " %qT is not a volatile type", t1); > + break; > case CPTK_REF_CONSTRUCTS_FROM_TEMPORARY: > inform (loc, " %qT is not a reference that binds to a temporary " > "object of type %qT (direct-initialization)", t1, t2); > diff --git a/gcc/cp/cp-trait.def b/gcc/cp/cp-trait.def > index 36faed9c0b3..e9347453829 100644 > --- a/gcc/cp/cp-trait.def > +++ b/gcc/cp/cp-trait.def > @@ -92,6 +92,7 @@ DEFTRAIT_EXPR (IS_TRIVIALLY_ASSIGNABLE, "__is_trivially_assignable", 2) > DEFTRAIT_EXPR (IS_TRIVIALLY_CONSTRUCTIBLE, "__is_trivially_constructible", -1) > DEFTRAIT_EXPR (IS_TRIVIALLY_COPYABLE, "__is_trivially_copyable", 1) > DEFTRAIT_EXPR (IS_UNION, "__is_union", 1) > +DEFTRAIT_EXPR (IS_VOLATILE, "__is_volatile", 1) > DEFTRAIT_EXPR (REF_CONSTRUCTS_FROM_TEMPORARY, "__reference_constructs_from_temporary", 2) > DEFTRAIT_EXPR (REF_CONVERTS_FROM_TEMPORARY, "__reference_converts_from_temporary", 2) > DEFTRAIT_TYPE (REMOVE_CV, "__remove_cv", 1) > diff --git a/gcc/cp/semantics.cc b/gcc/cp/semantics.cc > index fa7ba6a9edc..351235a639a 100644 > --- a/gcc/cp/semantics.cc > +++ b/gcc/cp/semantics.cc > @@ -12616,6 +12616,9 @@ trait_expr_value (cp_trait_kind kind, tree type1, tree type2) > case CPTK_IS_UNION: > return type_code1 == UNION_TYPE; > > + case CPTK_IS_VOLATILE: > + return CP_TYPE_VOLATILE_P (type1); > + > case CPTK_REF_CONSTRUCTS_FROM_TEMPORARY: > return ref_xes_from_temporary (type1, type2, /*direct_init=*/true); > > @@ -12826,6 +12829,7 @@ finish_trait_expr (location_t loc, cp_trait_kind kind, tree type1, tree type2) > case CPTK_IS_SAME: > case CPTK_IS_SCOPED_ENUM: > case CPTK_IS_UNION: > + case CPTK_IS_VOLATILE: > break; > > case CPTK_IS_LAYOUT_COMPATIBLE: > diff --git a/gcc/testsuite/g++.dg/ext/has-builtin-1.C b/gcc/testsuite/g++.dg/ext/has-builtin-1.C > index e3640faeb96..b2e2f2f694d 100644 > --- a/gcc/testsuite/g++.dg/ext/has-builtin-1.C > +++ b/gcc/testsuite/g++.dg/ext/has-builtin-1.C > @@ -158,6 +158,9 @@ > #if !__has_builtin (__is_union) > # error "__has_builtin (__is_union) failed" > #endif > +#if !__has_builtin (__is_volatile) > +# error "__has_builtin (__is_volatile) failed" > +#endif > #if !__has_builtin (__reference_constructs_from_temporary) > # error "__has_builtin (__reference_constructs_from_temporary) failed" > #endif > diff --git a/gcc/testsuite/g++.dg/ext/is_volatile.C b/gcc/testsuite/g++.dg/ext/is_volatile.C > new file mode 100644 > index 00000000000..80a1cfc880d > --- /dev/null > +++ b/gcc/testsuite/g++.dg/ext/is_volatile.C > @@ -0,0 +1,20 @@ > +// { dg-do compile { target c++11 } } > + > +#define SA(X) static_assert((X),#X) > + > +class ClassType { }; > +using cClassType = const ClassType; > +using vClassType = volatile ClassType; > +using cvClassType = const volatile ClassType; > + > +// Positive tests. > +SA(__is_volatile(volatile int)); > +SA(__is_volatile(const volatile int)); > +SA(__is_volatile(vClassType)); > +SA(__is_volatile(cvClassType)); > + > +// Negative tests. > +SA(!__is_volatile(int)); > +SA(!__is_volatile(const int)); > +SA(!__is_volatile(ClassType)); > +SA(!__is_volatile(cClassType));