From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-lf1-x129.google.com (mail-lf1-x129.google.com [IPv6:2a00:1450:4864:20::129]) by sourceware.org (Postfix) with ESMTPS id 40F5D3858D1E; Wed, 20 Sep 2023 17:51:53 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 40F5D3858D1E Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-lf1-x129.google.com with SMTP id 2adb3069b0e04-502b0d23f28so206850e87.2; Wed, 20 Sep 2023 10:51:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1695232311; x=1695837111; darn=gcc.gnu.org; h=in-reply-to:from:references:cc:to:content-language:subject :user-agent:mime-version:date:message-id:from:to:cc:subject:date :message-id:reply-to; bh=iSLDBj1oT/Cx6K6y36R1wtKLf84r20anHgyuFZS10Q0=; b=WbzLAftL1Bzmu6bq3w/l4qZ7eBOuBzar5d+mrQIr5j8r0iE2Wqnp/1rGgB7iAYOrPk mWj/0VM0ZqaxEnqjStpPTiFpbqiX1+89mTKYfoF/HgfxN0zsDe4d2s1x+nFrVFFOVTEs 7PJ65IeyDXFWYHi4kFRRAXXHrX5Pg7ZuCfu++Sia55urlr+Tl747TuVt93CljzJJjvFG EqqQmGWoihn+sHpljivcZfl24S7eFxvU9vZ9gpGHhJ8Ct6n5c174xpE42ggTidQ7x4cH 1I5O1vuUhTzQLe43SICw/AEmu2xOs0F5G8KbrhWsnGynPxJYOz+Qvb3xerrDyX37ocFs ymBw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1695232311; x=1695837111; h=in-reply-to:from:references:cc:to:content-language:subject :user-agent:mime-version:date:message-id:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=iSLDBj1oT/Cx6K6y36R1wtKLf84r20anHgyuFZS10Q0=; b=e2yZt4PhC8YhJRQZxcA6Ch549oiREUWG15j14hB3qzUky1VbjnJnLPgFhq8pql2XP3 9Vkl405P2kZxHyDlP/bIjRoiNdZ5JMqafCw/EZHi6feo6A5XaOSVsEOjTZDOfHrWNKxr 5wETMbgm4GlHSZlB+vigZHeNej+o8/VVWtsbPJR5cp4simFQm9DJrwyuqJkgKWozMjkF 5Q//bsQT8D4D75McZGwj1o/+0klKczA7UDxGjc2L4mmHdcztJlp2ES/KaZWx+uJoUHph xNEGSlOpL4VINGNBZap8emD5N7JVSyXRJyDr2T2wmB3bfEpKinyJOMKGjGaby0Op+8iy zhNw== X-Gm-Message-State: AOJu0YyTJO/JwQkBwTgBdBT7/kIRsCur2ordim6f1ZkoubpAGkNAvMFA gkqugoACdh2KuS/XlVraOHE= X-Google-Smtp-Source: AGHT+IGR0htYnAm16qw2O6EfWhAYT+wn4BhcuXO8OjAZEA75ic9b3uaHqYBi7k+Ni//FhwtSjGEEPA== X-Received: by 2002:a2e:b006:0:b0:2bc:f78a:e5e0 with SMTP id y6-20020a2eb006000000b002bcf78ae5e0mr2889922ljk.43.1695232310967; Wed, 20 Sep 2023 10:51:50 -0700 (PDT) Received: from [10.10.1.55] ([89.207.171.96]) by smtp.gmail.com with ESMTPSA id ox11-20020a170907100b00b00997c1d125fasm9821941ejb.170.2023.09.20.10.51.49 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 20 Sep 2023 10:51:50 -0700 (PDT) Content-Type: multipart/mixed; boundary="------------I58BoHCUQP6zcUhEwfToP5zM" Message-ID: <520bd324-39e8-45e0-a367-3d1195c1807f@gmail.com> Date: Wed, 20 Sep 2023 19:51:35 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.15.1 Subject: Re: [PATCH][_GLIBCXX_INLINE_VERSION] Fix Content-Language: en-US To: Jonathan Wakely Cc: libstdc++ , gcc-patches References: <55f0212a-f8d3-aa9e-8788-f5165484ac6c@gmail.com> From: =?UTF-8?Q?Fran=c3=a7ois_Dumont?= In-Reply-To: X-Spam-Status: No, score=-9.5 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,GIT_PATCH_0,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,RCVD_IN_SBL_CSS,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: This is a multi-part message in MIME format. --------------I58BoHCUQP6zcUhEwfToP5zM Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit libstdc++: [_GLIBCXX_INLINE_VERSION] Add handle_contract_violation symbol alias libstdc++-v3/ChangeLog:     * src/experimental/contract.cc     [_GLIBCXX_INLINE_VERSION](handle_contract_violation): Provide symbol alias     without version namespace decoration for gcc. Here is what I'm testing eventually, ok to commit if successful ? François On 20/09/2023 11:32, Jonathan Wakely wrote: > On Wed, 20 Sept 2023 at 05:51, François Dumont via Libstdc++ > wrote: >> libstdc++: Remove std::constract_violation from versioned namespace > Spelling mistake in contract_violation, and it's not > std::contract_violation, it's std::experimental::contract_violation > >> GCC expects this type to be in std namespace directly. > Again, it's in std::experimental not in std directly. > > Will this change cause problems when including another experimental > header, which does put experimental below std::__8? > > I think std::__8::experimental and std::experimental will become ambiguous. > > Maybe we do want to remove the inline __8 namespace from all > experimental headers. That needs a bit more thought though. > >> libstdc++-v3/ChangeLog: >> >> * include/experimental/contract: >> Remove _GLIBCXX_BEGIN_NAMESPACE_VERSION/_GLIBCXX_END_NAMESPACE_VERSION. > This line is too long for the changelog. > >> It does fix 29 g++.dg/contracts in gcc testsuite. >> >> Ok to commit ? >> >> François --------------I58BoHCUQP6zcUhEwfToP5zM Content-Type: text/x-patch; charset=UTF-8; name="contract.patch" Content-Disposition: attachment; filename="contract.patch" Content-Transfer-Encoding: base64 ZGlmZiAtLWdpdCBhL2xpYnN0ZGMrKy12My9zcmMvZXhwZXJpbWVudGFsL2NvbnRyYWN0LmNj IGIvbGlic3RkYysrLXYzL3NyYy9leHBlcmltZW50YWwvY29udHJhY3QuY2MKaW5kZXggNTA0 YTZjMDQxZjEuLjE3ZGFhMzMxMmNhIDEwMDY0NAotLS0gYS9saWJzdGRjKystdjMvc3JjL2V4 cGVyaW1lbnRhbC9jb250cmFjdC5jYworKysgYi9saWJzdGRjKystdjMvc3JjL2V4cGVyaW1l bnRhbC9jb250cmFjdC5jYwpAQCAtNjcsMyArNjcsMTQgQEAgaGFuZGxlX2NvbnRyYWN0X3Zp b2xhdGlvbiAoY29uc3Qgc3RkOjpleHBlcmltZW50YWw6OmNvbnRyYWN0X3Zpb2xhdGlvbiAm dmlvbGF0aW8KICAgc3RkOjpjZXJyIDw8IHN0ZDo6ZW5kbDsKICNlbmRpZgogfQorCisjaWYg X0dMSUJDWFhfSU5MSU5FX1ZFUlNJT04KKy8vIFByb3ZpZGUgc3ltYm9sIGFsaWFzIHdpdGhv dXQgdmVyc2lvbiBuYW1lc3BhY2UgZGVjb3JhdGlvbiBmb3IgZ2NjLgorZXh0ZXJuICJDIgor dm9pZCBfWjI1aGFuZGxlX2NvbnRyYWN0X3Zpb2xhdGlvblJLTlN0MTJleHBlcmltZW50YWwx OGNvbnRyYWN0X3Zpb2xhdGlvbkUKKyhjb25zdCBzdGQ6OmV4cGVyaW1lbnRhbDo6Y29udHJh Y3RfdmlvbGF0aW9uICZ2aW9sYXRpb24pCitfX2F0dHJpYnV0ZV9fICgKKyhhbGlhcworICgi X1oyNWhhbmRsZV9jb250cmFjdF92aW9sYXRpb25SS05TdDNfXzgxMmV4cGVyaW1lbnRhbDE4 Y29udHJhY3RfdmlvbGF0aW9uRSIpLAorIHdlYWspKTsKKyNlbmRpZgo= --------------I58BoHCUQP6zcUhEwfToP5zM--