From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <SRS0=a7Ys=4F=gmail.com=frs.dumont@sourceware.org>
Received: from mail-wr1-x42a.google.com (mail-wr1-x42a.google.com [IPv6:2a00:1450:4864:20::42a])
	by sourceware.org (Postfix) with ESMTPS id 4417D38FC733;
	Wed,  7 Dec 2022 17:58:27 +0000 (GMT)
DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 4417D38FC733
Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com
Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com
Received: by mail-wr1-x42a.google.com with SMTP id w15so29170907wrl.9;
        Wed, 07 Dec 2022 09:58:27 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=content-transfer-encoding:in-reply-to:from:content-language
         :references:cc:to:subject:user-agent:mime-version:date:message-id
         :from:to:cc:subject:date:message-id:reply-to;
        bh=kH8oFkz1Y51eNwLtvxNmwPKgGkVjyW3+VbfQCtRXQXU=;
        b=eXxaKaOWV6tpFZe+DMcPOVJhgUmEcI+sbR+3yXmQSZqxCsRO3SP7zQWP0mPtf11OJY
         MtnMEwKl91S0nQWSk+Pfpy0Be0cIkYmfQ0LbQ4lDw8LqmCkWWnDtk0/8dx1NjKWsp5hZ
         OPw9PF5lHOSB+WCYmrwpTDWwM1FFZ6JxALBIhcrLoe7hP3bopysuX4/80f/1p2vtWb4u
         igLvKCDq7hdikNh9G5suC/zH2lWkbEITWsPgeWEtvxDnQAEg1PJboijYhosK+7a/UFnp
         qEVHW8/AABjc380nwvT2DGjVrvbMphFOeLu5jZ65XRiWKOZdbytRoSH0+RX0a/rkS+zl
         81KA==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=content-transfer-encoding:in-reply-to:from:content-language
         :references:cc:to:subject:user-agent:mime-version:date:message-id
         :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to;
        bh=kH8oFkz1Y51eNwLtvxNmwPKgGkVjyW3+VbfQCtRXQXU=;
        b=i1udk9b2/DmHo2SnnPAVpAUFZM8R8WPs5N7TfBkmCxib/S89ZENXiNoKXZg32aUpar
         rjMrZkMzPG+86RyTjLN9+jLp3wzUwztqxsObZHkNvYN7OKb3LFFZKt9fA0YeLYH644aa
         NrWPJiTaDYqgyItQBUpvDqftQ8SOfZUS2PYM259WaQZJVynu1wfEBJ2WiEPVE7QyH60N
         1C8xSADaqeR7FhHgVbkQaRQIKq/PZCZV4r5xi7OYw12CH9ZxZo3TmE2nkqexNOokAge8
         n7yVkuosEXuExtDYE2B/zG/DmmIutp0283AwquS0e5NJg/CSEcdvEajsvDMLCMpfN0Ow
         CGDw==
X-Gm-Message-State: ANoB5pnRxsc1WQGmCJafnxDVZ3l/Aa0Bf8ES2ChC5pO3pX7Q+ukQAOhs
	ME7k0V2UBYohmcaFWjyR1Lc=
X-Google-Smtp-Source: AA0mqf42A5z02/48i/4UZL+crBeVc2kXoDTxX6Zg1VZDMDjjx7XhgBttDjdTOU9Zb+i1yJwYMrgRAQ==
X-Received: by 2002:adf:f352:0:b0:241:fd11:dcd with SMTP id e18-20020adff352000000b00241fd110dcdmr36865889wrp.706.1670435905928;
        Wed, 07 Dec 2022 09:58:25 -0800 (PST)
Received: from [10.2.0.27] ([109.190.253.14])
        by smtp.googlemail.com with ESMTPSA id o15-20020a05600c4fcf00b003cf483ee8e0sm3096028wmq.24.2022.12.07.09.58.24
        (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);
        Wed, 07 Dec 2022 09:58:24 -0800 (PST)
Message-ID: <53263b31-c704-78ff-4cba-212c9a18a3c6@gmail.com>
Date: Wed, 7 Dec 2022 18:58:23 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.4.2
Subject: Re: [PATCH] libstdc++: Add error handler for <stacktrace>
To: Jonathan Wakely <jwakely@redhat.com>
Cc: =?UTF-8?Q?Bj=c3=b6rn_Sch=c3=a4pers?= <gcc@hazardy.de>,
 libstdc++@gcc.gnu.org, gcc Patches <gcc-patches@gcc.gnu.org>
References: <20221129214107.25572-1-gcc@hazardy.de>
 <ee866216-8828-6b88-764d-9de8264108d5@gmail.com>
 <CACb0b4nR8Rx9=vpaTh48EkrL+osj8o7FTaBchPW8AUaQVxf0SA@mail.gmail.com>
 <CACb0b4kWc8izwDr_H6iCq1cJLwAr+d9ViwVnpYFy=s6rkiP55g@mail.gmail.com>
 <CACb0b4=Q68rqxPus-mSxD6MyxTuX_T_5M5=oxgEy_rGozKFbvA@mail.gmail.com>
 <830aca53-fd19-2556-28b0-30ebff17df8c@gmail.com>
 <CACb0b4=bFn+-SJoWWQ3UuaTP4a1L84QmjQfCMBA4bV+wKevXKw@mail.gmail.com>
Content-Language: fr, en-US
From: =?UTF-8?Q?Fran=c3=a7ois_Dumont?= <frs.dumont@gmail.com>
In-Reply-To: <CACb0b4=bFn+-SJoWWQ3UuaTP4a1L84QmjQfCMBA4bV+wKevXKw@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
X-Spam-Status: No, score=0.4 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,NICE_REPLY_A,RCVD_IN_BARRACUDACENTRAL,RCVD_IN_DNSWL_NONE,RCVD_IN_SBL_CSS,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=no autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org
List-Id: <libstdc++.gcc.gnu.org>

Looks perfect to me, thanks.

On 06/12/22 22:44, Jonathan Wakely wrote:
> On Wed, 30 Nov 2022 at 18:00, François Dumont <frs.dumont@gmail.com> wrote:
>> On 30/11/22 14:07, Jonathan Wakely wrote:
>>> On Wed, 30 Nov 2022 at 11:57, Jonathan Wakely <jwakely@redhat.com> wrote:
>>>>
>>>> On Wed, 30 Nov 2022 at 11:54, Jonathan Wakely <jwakely@redhat.com> wrote:
>>>>>
>>>>> On Wed, 30 Nov 2022 at 06:04, François Dumont via Libstdc++ <libstdc++@gcc.gnu.org> wrote:
>>>>>> Good catch, then we also need this patch.
>>>>> Is it worth printing an error? If we can't show the backtrace because of an error, we can just print nothing there.
>> No strong opinion on that but if we do not print anything the output
>> will be:
>>
>> Backtrace:
>>
>> Error: ...
>>
>> I just considered that it did not cost much to report the issue to the
>> user that defined _GLIBCXX_DEBUG_BACKTRACE and so is expecting a backtrace.
>>
>> Maybe printing "Backtrace:\n" could be done in the normal callback
>> leaving the user with the feeling that _GLIBCXX_DEBUG_BACKTRACE does not
>> work.
> OK, how's this?
>
> Tested x86_64-linux.