From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm1-x32a.google.com (mail-wm1-x32a.google.com [IPv6:2a00:1450:4864:20::32a]) by sourceware.org (Postfix) with ESMTPS id 3EF1A3858408; Mon, 21 Feb 2022 21:33:08 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 3EF1A3858408 Received: by mail-wm1-x32a.google.com with SMTP id i19so10221178wmq.5; Mon, 21 Feb 2022 13:33:08 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to; bh=YhgElgiV8vqwIKox+u6CW3oaXJSLI5jk4W0TfdVGn5c=; b=vYBdXpwpMaIYh20iUk5Iln/OXhQZJxVMSznXiJp5BP2uubwVTmkfh3ckXkZZLTy7v3 MqiwNLBETMWou0zliI8JkyMJlQNmuLL9QEygHmt5RpJKe/C5RKEyOnQmrtj6d696kYjm cRuSHCio9A8NJHA0X+rUXF+67YNUfKFGtysVCXaEtYh1mELZ3XLQonWYpKt6KJu7hLmw 2DnK6z6QI5SDawM8ySthC0XE5uOWuq33CbH4oFlp0mKm+NC/z/8FssALQAWtMkWohWfn 6zYD6CcB+N9MHHUk5OYjeR7x3snV2/3jYlCcITOEu0K3Z1cARYa++UG85JBTHz7lMFke cPfg== X-Gm-Message-State: AOAM5301WbuHR/RjQFF96c6yChH86xVK2JKhcXySCu1VNQ+YkUr+R36N LPCWqnWKmKhwszzl9TGwe+o= X-Google-Smtp-Source: ABdhPJxVJgY3N+bw1UEgqOiWwGJqVvruVp3l1F/TX1Ekl13pkkt5lURbVIHHe7HcjaHCQzTQ9FNdgw== X-Received: by 2002:a05:600c:3b06:b0:37c:3ce4:9a31 with SMTP id m6-20020a05600c3b0600b0037c3ce49a31mr747360wms.192.1645479187223; Mon, 21 Feb 2022 13:33:07 -0800 (PST) Received: from ?IPV6:2a01:e0a:1dc:b1c0:2d72:f5b1:2a05:732e? ([2a01:e0a:1dc:b1c0:2d72:f5b1:2a05:732e]) by smtp.googlemail.com with ESMTPSA id j6-20020a05600c190600b0037c3659a12fsm664152wmq.6.2022.02.21.13.33.06 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 21 Feb 2022 13:33:06 -0800 (PST) Message-ID: <57c6a713-14a8-5853-3721-8d01774abad9@gmail.com> Date: Mon, 21 Feb 2022 22:33:05 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.5.0 Subject: Re: [PATCH][_Hashtable] Fix insertion of range of type convertible to value_type PR 56112 Content-Language: fr To: Jonathan Wakely Cc: "libstdc++@gcc.gnu.org" , gcc-patches References: <2fe3937d-1b9a-a547-bb41-225d3d5426a2@gmail.com> <87a6c4e2-9ba6-0c04-274a-5f204efe5d17@gmail.com> From: =?UTF-8?Q?Fran=c3=a7ois_Dumont?= In-Reply-To: X-Spam-Status: No, score=-1.8 required=5.0 tests=BAYES_00, BODY_8BITS, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, HTML_MESSAGE, KAM_NUMSUBJECT, NICE_REPLY_A, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Content-Filtered-By: Mailman/MimeDel 2.1.29 X-BeenThere: libstdc++@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libstdc++ mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 21 Feb 2022 21:33:10 -0000 On 21/02/22 21:54, Jonathan Wakely wrote: > > > On Mon, 21 Feb 2022 at 18:00, François Dumont via Libstdc++ > > wrote: > > Gentle reminder, it is important to have this for gcc 12. > > > Well, it's been broken since 4.8, so another year wouldn't be the end > of the world ;-) Sorry for the pressure, I thought I had broken it with my fix of PR 96088. Which moreover was in gcc 11. So indeed not mandatory for gcc 12 but still nice to fix eventually. Thanks > > I did start reviewing it, but I was trying to find a simpler way to > solve it than adding all those overloads. I'll take another look > tomorrow and either approve your patch or suggest something else. > > > > On 15/02/22 10:05, François Dumont wrote: > > We have a regression regarding management of types convertible to > > value_type. It is an occurrence of PR 56112 but for the insert > method. > > > >     libstdc++: [_Hashtable] Insert range of types convertible to > > value_type PR 56112 > > > >     Fix insertion of range of types convertible to value_type. > > > >     libstdc++-v3/ChangeLog: > > > >             PR libstdc++/56112 > >             * include/bits/hashtable.h > >             (_Hashtable<>::_M_insert_unique_aux): New. > >             (_Hashtable<>::_S_to_value): New. > > (_Hashtable<>::_M_insert(_Arg&&, const _NodeGenerator&, > > true_type)): Use latters. > >             * > testsuite/23_containers/unordered_map/cons/56112.cc: Use > > dg-do compile. > >             * > testsuite/23_containers/unordered_set/cons/56112.cc: New > > test. > > > > Tested under Linux x86_64. > > > > Ok to commit ? > > > > François > >