From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id 931613858D1E for ; Tue, 30 Apr 2024 20:54:19 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 931613858D1E Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 931613858D1E Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=170.10.133.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1714510461; cv=none; b=oYmR0E4+2Lp6hGRO9DoBLEflX9iAvsGexPD+tA3aPzc7iRjyX/68wkeurHO7ZEYu62ppzMVjB9rDRe9gKi/MF44UOvTFsaFlv+jhCuvgpMb3Foh3oQ1EvN22BbNMLgtv6QTVbGHZ3SBVkcshspamAYevy3ceZStkCvYyTMWg3PY= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1714510461; c=relaxed/simple; bh=YLfMqjbyB18gHDtZFLzxQXDE2JFZNkf0Sk4ILUQiCfM=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=P3vBvIn1DqKuZRsg8FJPpYhNpKcaZDBQ95pB7yOR20pNdP7ji6sILowazBPjSSEJuC6SkukGNCSKPbTGrOsrMNBXORgFy8o11MGthlzeD0vCQLNRsk6h3MO799MmZDV4HwbpjhsIpVzW7nUldxpPwuDHjxs8PB36T1kNgnVcj+o= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1714510459; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ThllGng21yC8088s6tP2LzlpIgmfMxWTZjhfU5VvPls=; b=dAMcTORkvbJwY0Bfhdq6JiZZEEFgKb9B3TLxjPrb67amZTjFXAPxoPX6ecMFBtTBty+V3t uJC7C4J7HGXUx2ZIWKz/zxpnO7tI5YmM7pg9EqlJm0wiOFMp1hI4UAfV0ekpg36KZPtwQQ HNlJ0Km/BKsORh2E3AkS98k+OPwc0lU= Received: from mail-qv1-f69.google.com (mail-qv1-f69.google.com [209.85.219.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-592-mBNNZUFkNRmwuQHGV7tFFw-1; Tue, 30 Apr 2024 16:54:17 -0400 X-MC-Unique: mBNNZUFkNRmwuQHGV7tFFw-1 Received: by mail-qv1-f69.google.com with SMTP id 6a1803df08f44-6a0dc98dc24so13333196d6.2 for ; Tue, 30 Apr 2024 13:54:17 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1714510457; x=1715115257; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=ThllGng21yC8088s6tP2LzlpIgmfMxWTZjhfU5VvPls=; b=Htum3nYjCLTc806Vb93OrCThM167FIAX9+aJnK77zyhjs2+kJ+41qptgFsGwgwWNfx bQsHncnlzEvZQA71ClYuCkWdl9Jz1YC29TH716StuQVBDH4MPeIO/+5kca3YFwzYvspN tG2zEIlUQh0sU23A1HLuR7LTv0WUc6uZXBl2zTUOXkV51OhNeNIRzAowvpvtMWAMCbQs kqVf1EbJmYXJSvJZMGJAgEcQ4td4gEijrOpyLcFdT0xRrlXD0O0DSrukf4weQH+6CWO+ P/j/a4urZKB0oCcJDpH4uhxDzzPErTV9lPvagzx/pfsR4nM25H9JkxaZoncrq7B2HkQq WfwA== X-Gm-Message-State: AOJu0YwZNZ3ifUiSBWK7H/MUhUhjLB9meoNs2LTegUTwvEpqHAi3q1Uk BMggz3HuYZ8aFXGPCW0AuJ24rInVUNlDUcLq6AtB1Jh+LS/Bu32m3O/p4WgKELlYXZEsKQmuukc cs6FuBv65WsIuMVkILf4lf10WfgprwvP2++S4ZgtYID6gEIVZaoo1 X-Received: by 2002:a05:6214:d6d:b0:6a0:cb7c:68c7 with SMTP id 13-20020a0562140d6d00b006a0cb7c68c7mr486126qvs.65.1714510456864; Tue, 30 Apr 2024 13:54:16 -0700 (PDT) X-Google-Smtp-Source: AGHT+IH+OC4XTNwsRe11d4nGTwlSmyQalYyLt0yXKqMH+Fs21TiWbEtK3YpcwFplXGQgn3JyjCbgvA== X-Received: by 2002:a05:6214:d6d:b0:6a0:cb7c:68c7 with SMTP id 13-20020a0562140d6d00b006a0cb7c68c7mr486111qvs.65.1714510456530; Tue, 30 Apr 2024 13:54:16 -0700 (PDT) Received: from [192.168.1.130] (130-44-146-16.s12558.c3-0.arl-cbr1.sbo-arl.ma.cable.rcncustomer.com. [130.44.146.16]) by smtp.gmail.com with ESMTPSA id y19-20020ad445b3000000b006a0cf22e54asm2164401qvu.41.2024.04.30.13.54.15 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 30 Apr 2024 13:54:15 -0700 (PDT) Message-ID: <5a4aa0a8-e626-4e5b-8a39-bb66ebb9bd89@redhat.com> Date: Tue, 30 Apr 2024 16:54:14 -0400 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v14 01/26] c++: Implement __is_const built-in trait To: Ken Matsui , gcc-patches@gcc.gnu.org Cc: libstdc++@gcc.gnu.org References: <20240221093616.4001742-1-kmatsui@gcc.gnu.org> <20240228192843.188979-1-kmatsui@gcc.gnu.org> <20240228192843.188979-2-kmatsui@gcc.gnu.org> From: Jason Merrill In-Reply-To: <20240228192843.188979-2-kmatsui@gcc.gnu.org> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-12.7 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H4,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 2/28/24 11:26, Ken Matsui wrote: > This patch implements built-in trait for std::is_const. OK. > gcc/cp/ChangeLog: > > * cp-trait.def: Define __is_const. > * constraint.cc (diagnose_trait_expr): Handle CPTK_IS_CONST. > * semantics.cc (trait_expr_value): Likewise. > (finish_trait_expr): Likewise. > > gcc/testsuite/ChangeLog: > > * g++.dg/ext/has-builtin-1.C: Test existence of __is_const. > * g++.dg/ext/is_const.C: New test. > > Signed-off-by: Ken Matsui > --- > gcc/cp/constraint.cc | 3 +++ > gcc/cp/cp-trait.def | 1 + > gcc/cp/semantics.cc | 4 ++++ > gcc/testsuite/g++.dg/ext/has-builtin-1.C | 3 +++ > gcc/testsuite/g++.dg/ext/is_const.C | 20 ++++++++++++++++++++ > 5 files changed, 31 insertions(+) > create mode 100644 gcc/testsuite/g++.dg/ext/is_const.C > > diff --git a/gcc/cp/constraint.cc b/gcc/cp/constraint.cc > index 49de3211d4c..f32a1c78d63 100644 > --- a/gcc/cp/constraint.cc > +++ b/gcc/cp/constraint.cc > @@ -3767,6 +3767,9 @@ diagnose_trait_expr (tree expr, tree args) > case CPTK_IS_CLASS: > inform (loc, " %qT is not a class", t1); > break; > + case CPTK_IS_CONST: > + inform (loc, " %qT is not a const type", t1); > + break; > case CPTK_IS_CONSTRUCTIBLE: > if (!t2) > inform (loc, " %qT is not default constructible", t1); > diff --git a/gcc/cp/cp-trait.def b/gcc/cp/cp-trait.def > index 394f006f20f..36faed9c0b3 100644 > --- a/gcc/cp/cp-trait.def > +++ b/gcc/cp/cp-trait.def > @@ -64,6 +64,7 @@ DEFTRAIT_EXPR (IS_ASSIGNABLE, "__is_assignable", 2) > DEFTRAIT_EXPR (IS_BASE_OF, "__is_base_of", 2) > DEFTRAIT_EXPR (IS_BOUNDED_ARRAY, "__is_bounded_array", 1) > DEFTRAIT_EXPR (IS_CLASS, "__is_class", 1) > +DEFTRAIT_EXPR (IS_CONST, "__is_const", 1) > DEFTRAIT_EXPR (IS_CONSTRUCTIBLE, "__is_constructible", -1) > DEFTRAIT_EXPR (IS_CONVERTIBLE, "__is_convertible", 2) > DEFTRAIT_EXPR (IS_EMPTY, "__is_empty", 1) > diff --git a/gcc/cp/semantics.cc b/gcc/cp/semantics.cc > index 57840176863..0d08900492b 100644 > --- a/gcc/cp/semantics.cc > +++ b/gcc/cp/semantics.cc > @@ -12446,6 +12446,9 @@ trait_expr_value (cp_trait_kind kind, tree type1, tree type2) > case CPTK_IS_CLASS: > return NON_UNION_CLASS_TYPE_P (type1); > > + case CPTK_IS_CONST: > + return CP_TYPE_CONST_P (type1); > + > case CPTK_IS_CONSTRUCTIBLE: > return is_xible (INIT_EXPR, type1, type2); > > @@ -12688,6 +12691,7 @@ finish_trait_expr (location_t loc, cp_trait_kind kind, tree type1, tree type2) > case CPTK_IS_ARRAY: > case CPTK_IS_BOUNDED_ARRAY: > case CPTK_IS_CLASS: > + case CPTK_IS_CONST: > case CPTK_IS_ENUM: > case CPTK_IS_FUNCTION: > case CPTK_IS_MEMBER_FUNCTION_POINTER: > diff --git a/gcc/testsuite/g++.dg/ext/has-builtin-1.C b/gcc/testsuite/g++.dg/ext/has-builtin-1.C > index 02b4b4d745d..e3640faeb96 100644 > --- a/gcc/testsuite/g++.dg/ext/has-builtin-1.C > +++ b/gcc/testsuite/g++.dg/ext/has-builtin-1.C > @@ -71,6 +71,9 @@ > #if !__has_builtin (__is_class) > # error "__has_builtin (__is_class) failed" > #endif > +#if !__has_builtin (__is_const) > +# error "__has_builtin (__is_const) failed" > +#endif > #if !__has_builtin (__is_constructible) > # error "__has_builtin (__is_constructible) failed" > #endif > diff --git a/gcc/testsuite/g++.dg/ext/is_const.C b/gcc/testsuite/g++.dg/ext/is_const.C > new file mode 100644 > index 00000000000..8a0e8df72a9 > --- /dev/null > +++ b/gcc/testsuite/g++.dg/ext/is_const.C > @@ -0,0 +1,20 @@ > +// { dg-do compile { target c++11 } } > + > +#define SA(X) static_assert((X),#X) > + > +class ClassType { }; > +using cClassType = const ClassType; > +using vClassType = volatile ClassType; > +using cvClassType = const volatile ClassType; > + > +// Positive tests. > +SA(__is_const(const int)); > +SA(__is_const(const volatile int)); > +SA(__is_const(cClassType)); > +SA(__is_const(cvClassType)); > + > +// Negative tests. > +SA(!__is_const(int)); > +SA(!__is_const(volatile int)); > +SA(!__is_const(ClassType)); > +SA(!__is_const(vClassType));