From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wr1-x42c.google.com (mail-wr1-x42c.google.com [IPv6:2a00:1450:4864:20::42c]) by sourceware.org (Postfix) with ESMTPS id D8D513858D20 for ; Mon, 5 Jun 2023 20:09:48 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org D8D513858D20 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-wr1-x42c.google.com with SMTP id ffacd0b85a97d-30af159b433so5296341f8f.3 for ; Mon, 05 Jun 2023 13:09:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1685995787; x=1688587787; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=EqgPMZSiQHGp8KAv0lGPVdVVAU+t4doxJ9YUyLk7ZLc=; b=hm7mDLGUAc5L+3MO+5ahMK9GHZKxQX432zqMNc/TPs256YIOHJB/9Ib3hlMu+ELTBp YxdF4YboB0M6u+UrZY6/v+DlXMhhCv48BK7mrvMdxcUtgxz5W5sQvPnUTzRvYC48J91S DsYr8oXgYeGMilAagHAmPhY6maoQYBk4XGzDX4mkbtM4oXs2GbNvkwscLKE+kRtWKrZn ttL1TdJETi67JpL0zSbBeFkTUI0T/RY+cgTtXLygq25YpiuJdyiENEqdUGS4zvQ4+KZ7 ae+x+y6QZZ3/gifcvCSmJsYpvQXGJFje9jXWQCmcQDz5pIv9R5gC2SxUL/9R3bxBvbVT oZSQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1685995787; x=1688587787; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=EqgPMZSiQHGp8KAv0lGPVdVVAU+t4doxJ9YUyLk7ZLc=; b=hWAVALS2iewQrLh5b6zF8vONRcmhZnrqxI41V53M/jLvW3LbV8UpyEuq3521Tgr0pX au0KKjMXtD4ZSiI3l2jufgWiHoHuDrHcXUYdYTfJZdDfaDcMldtTU9Fga9EP2Uin7O+L eOpDWSNOMP0j+dLBCK2xZ9CEWfIVEpz+kGnyJgBGtp+G7ZWE4/D0b3dxAdu7ExkJTr/M IFdtsYZEeAlSmzapLzz6ojmm/gDPwt3qQ64rRB3eA22FJDQC3EsMZRxnigEfKG59GsI8 ZUQDwbFzEdGApbXEg8x4cDx5uhkd5xMzwLGLP/qnS2inrgBNZpcxK9gSZx4bcPOHomC2 Onpw== X-Gm-Message-State: AC+VfDyNFTAg5QuoZEsf3epJXZMHU2NOC+QvfiSlopVX3N44gLB4+bW5 kPTSfDnmKJEfV07ou7th8Lk= X-Google-Smtp-Source: ACHHUZ7RWShhSsS5ZBdjmUzFBsRe6qtxssKupWSC87juXeKLc3Bjs4aSvs7EJVCZIzfqkv6PSrCU6A== X-Received: by 2002:a5d:5961:0:b0:30a:f3f6:2712 with SMTP id e33-20020a5d5961000000b0030af3f62712mr6632081wri.60.1685995787364; Mon, 05 Jun 2023 13:09:47 -0700 (PDT) Received: from ?IPV6:2a01:e0a:1dc:b1c0:b9e6:9336:3547:310a? ([2a01:e0a:1dc:b1c0:b9e6:9336:3547:310a]) by smtp.gmail.com with ESMTPSA id k9-20020adfe8c9000000b0030644bdefd8sm10450865wrn.52.2023.06.05.13.09.46 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 05 Jun 2023 13:09:46 -0700 (PDT) Message-ID: <5c352c17-c047-4694-198b-9714e8a3dbaa@gmail.com> Date: Mon, 5 Jun 2023 22:09:46 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.11.0 Subject: Re: [PATCH] Move std::search into algobase.h To: Jonathan Wakely Cc: Jonathan Wakely , Rainer Orth , libstdc++ References: <01f2b9e7-14e8-12a7-c275-7e48e3bd94df@gmail.com> <8f43b613-f185-8e46-8fc6-02bc286125b5@gmail.com> <12cad432-888f-6db7-152a-89c5a17e4ac8@gmail.com> Content-Language: en-US From: =?UTF-8?Q?Fran=c3=a7ois_Dumont?= In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-3.4 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 05/06/2023 21:52, Jonathan Wakely wrote: > >> >>> I can see the libgomp path in LD_LIBRARY_PATH but no -I for the same. Should it come from some default xgcc include path ? > > No, see the comment I suggested below, which explains that it finds it > in the installed $prefix. Ok, sorry, I hadn't read it closely enough. It would be helpful to add it indeed. > Since we already have dg-require-parallel-mode that is used for most parallel mode tests, I don't think it's worth adding a new "openmp" effective-target just for these three tests. But it would be helpful if I added this comment to them instead: > > --- a/libstdc++-v3/testsuite/17_intro/headers/c++2014/parallel_mode.cc > +++ b/libstdc++-v3/testsuite/17_intro/headers/c++2014/parallel_mode.cc > @@ -19,6 +19,12 @@ > // { dg-do compile { target c++14 } } > // { dg-require-normal-mode "" } > > +// In order to improve coverage this test is run by the normal 'make check' > +// target, not only the infrequently-tested check-parallel target. That means > +// the makefile variable $(libgomp_flags) is not used, so the libgomp files > +// in the build tree will not be found. The parallel mode headers will only > +// be able to include if libgomp has already been installed to the > +// $prefix of the GCC being tested, so use __has_include to fail gracefully. > #if __has_include() > # define _GLIBCXX_PARALLEL 1 > # include >