public inbox for libstdc++@gcc.gnu.org
 help / color / mirror / Atom feed
From: "François Dumont" <frs.dumont@gmail.com>
To: Jonathan Wakely <jwakely@redhat.com>
Cc: "libstdc++@gcc.gnu.org" <libstdc++@gcc.gnu.org>,
	gcc-patches <gcc-patches@gcc.gnu.org>
Subject: Re: [PATCH][_GLIBCXX_INLINE_VERSION] Adapt dg error messages
Date: Mon, 28 Nov 2022 18:59:27 +0100	[thread overview]
Message-ID: <5e6d726e-7152-c0da-8d57-baa5ca94143a@gmail.com> (raw)
In-Reply-To: <CACb0b4=e2i=2qoBMF3D95pJG_2ENBesJHBt0wC28PkV850yhiQ@mail.gmail.com>

[-- Attachment #1: Type: text/plain, Size: 1843 bytes --]

On 28/11/22 14:39, Jonathan Wakely wrote:
>
>
> On Mon, 28 Nov 2022 at 10:08, Jonathan Wakely <jwakely@redhat.com> wrote:
>
>
>
>     On Mon, 28 Nov 2022 at 10:06, Jonathan Wakely <jwakely@redhat.com>
>     wrote:
>
>
>
>         On Mon, 28 Nov 2022 at 06:02, François Dumont via Libstdc++
>         <libstdc++@gcc.gnu.org <mailto:libstdc%2B%2B@gcc.gnu.org>> wrote:
>
>             libstdc++: [_GLIBCXX_INLINE_VERSION] Adapt dg error messages
>
>             libstdc++-v3/ChangeLog
>
>                      * testsuite/20_util/bind/ref_neg.cc: Adapt
>             dg-prune-output message.
>                      * testsuite/20_util/function/cons/70692.cc: Adapt
>             dg-error message.
>
>             Ok to commit ?
>
>
>         OK, thanks.
>
>
>
>     Actually wait, can you test this instead?
>
>     --- a/libstdc++-v3/testsuite/lib/prune.exp
>     +++ b/libstdc++-v3/testsuite/lib/prune.exp
>     @@ -37,6 +37,8 @@ proc libstdc++-dg-prune { system text } {
>           return "::unsupported::hosted C++ headers not supported"
>         }
>
>     +    regsub -all "std::__8::" $text "std::" text
>     +
>         # Ignore caret diagnostics. Unfortunately dejaGNU trims leading
>         # spaces, so one cannot rely on them being present.
>         regsub -all "(^|\n)\[^\n\]+\n *\\^\n" $text "\n" text
>
>     This should mean we can stop needing to make these changes to
>     every test, and just write the tests naturally.
>
>
> That only helps for dg-prune-output but we still need to (__8::)? for 
> dg-error.
>
> Please push your change to 20_util/function/cons/70692.cc but not the 
> change to 20_util/bind/ref_neg.cc (the latter will get fixed after I 
> pushed the prune.expo change).
>
>
Done as requested and I confirm that prune.exp enhancement fixed 
20_util/bind/ref_neg.cc.

Thanks

      reply	other threads:[~2022-11-28 17:59 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-11-28  6:01 François Dumont
2022-11-28 10:06 ` Jonathan Wakely
2022-11-28 10:08   ` Jonathan Wakely
2022-11-28 13:39     ` Jonathan Wakely
2022-11-28 17:59       ` François Dumont [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5e6d726e-7152-c0da-8d57-baa5ca94143a@gmail.com \
    --to=frs.dumont@gmail.com \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=jwakely@redhat.com \
    --cc=libstdc++@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).