From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id 30FCD384AB4C for ; Tue, 30 Apr 2024 20:56:57 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 30FCD384AB4C Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 30FCD384AB4C Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=170.10.129.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1714510619; cv=none; b=pEBlwcBrcP1QrWpwuKsHiZCEUAHSF6j1Pwdbyvp6P2Fc8q+gaRgTprV+Jzg+I4Iob2aSBXaGFL04VzWgqfzc8oPDoGFkWRn6BcAlnHI6z3Yw9cOnjcpndXknJu2KdXo8d7xh1n8+XLvkHS34h8As46J7NcU648Oni6PEb+dFnhs= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1714510619; c=relaxed/simple; bh=Mzkq1LZDe+TtVFw2ZrXIA1n1NJQhIfNZ+Y2o5jp9dJQ=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=uUGEhIw3IkBI2duJ2KeKiclw/U0ODjhgb8C5Qu4udhioo4s4BqIoTG9hEzvXTMkXErF3Ajsnnd1VQ6Rut8STg1qnIARJbXLwHjnGWqgxmcp4Zst0ITyGNLCvvVpksqW8+LCEGGeuqv8/GT3/lrq52sHEoetrkFsJD1q7B4dbGmE= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1714510616; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=+djVok47wzjYYmpEQj9m94Hp02QW/E9K+41q7yjnYSM=; b=WYO5RZrl1m7ATIMAXpkmjwIlvBj4/xU+Z03YGKQwr2E1Jx1YOcUXU0tZARhB6/VoKn7bBX NrbIC1Oqx93yqvxHGq0bNavJS7NxhRWC0P8Qr/d72bEXRzZXI4m8zR1/DoF+wtORGL5lOe tvdkMb1+XhLuQK3MjijTmQCZKshEwaY= Received: from mail-qt1-f198.google.com (mail-qt1-f198.google.com [209.85.160.198]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-343-cmb4WlJdObq3JkK-0Mqqhg-1; Tue, 30 Apr 2024 16:56:55 -0400 X-MC-Unique: cmb4WlJdObq3JkK-0Mqqhg-1 Received: by mail-qt1-f198.google.com with SMTP id d75a77b69052e-439fcfca0a7so84198471cf.3 for ; Tue, 30 Apr 2024 13:56:55 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1714510615; x=1715115415; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=+djVok47wzjYYmpEQj9m94Hp02QW/E9K+41q7yjnYSM=; b=McM71mB3aBXoqirw0P5x4KNZJxeHAFG8kCypinXfdktOZL7G5HYoQpL2VXBJrpo09c 0DojjltAGW/40bzexj1TSi5d7Aep6pq9GO1NEIFPpelL9YWYRWESa4PGQik8hlqOMfgL 3WY/56y40QvHqDzOvu4AtaKrsAKd3tA0MYbGm0qNUaYZ90s3giX4AbYmRyDh3A2mwgDX 8UVaA+JwwErpevQCprU4xF4uy1bOBYK0YLXWv1bT5b/+/s3KqDszl0cYoMD+h2h5opon cZGMk2Z6GQUd/LW8FcysfvSMmNQM8S0Qnosy3ubz3X0zkYgmML6tAVRdvKxrDqks3v3w 6Xrg== X-Gm-Message-State: AOJu0YxpQZB3Q14dqf3uZw6AmxWij/rPGTNj2qw+WdsDur+9Mt5MbBi1 5ebe0i3+Fe1N2XriHMEYdbKp7HSKIJxon1iCugVC/xYyUdw9MbXbcTYyx6ToLnWqoht2NaGxfGQ CuTpepauLhiC9Xna/MxYATCUWKOP+Fp0RrJtZxYBCq5QBWmnbCskv X-Received: by 2002:a05:622a:181f:b0:43a:745f:a93f with SMTP id t31-20020a05622a181f00b0043a745fa93fmr534993qtc.53.1714510614620; Tue, 30 Apr 2024 13:56:54 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFU6YZ33CsRaL1WnC/1gtDSNTLsRPNAO+wVGdXV7VhAVwUpOq3CCVt6IOctg2J7XOKMTkQTWg== X-Received: by 2002:a05:622a:181f:b0:43a:745f:a93f with SMTP id t31-20020a05622a181f00b0043a745fa93fmr534967qtc.53.1714510614006; Tue, 30 Apr 2024 13:56:54 -0700 (PDT) Received: from [192.168.1.130] (130-44-146-16.s12558.c3-0.arl-cbr1.sbo-arl.ma.cable.rcncustomer.com. [130.44.146.16]) by smtp.gmail.com with ESMTPSA id w16-20020ac843d0000000b00439d68d5eb0sm7659056qtn.78.2024.04.30.13.56.53 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 30 Apr 2024 13:56:53 -0700 (PDT) Message-ID: <5fc2680c-9cc7-4690-b3e0-ebc7d8026d58@redhat.com> Date: Tue, 30 Apr 2024 16:56:52 -0400 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v14 07/26] c++: Implement __is_unbounded_array built-in trait To: Ken Matsui , gcc-patches@gcc.gnu.org Cc: libstdc++@gcc.gnu.org References: <20240221093616.4001742-1-kmatsui@gcc.gnu.org> <20240228192843.188979-1-kmatsui@gcc.gnu.org> <20240228192843.188979-8-kmatsui@gcc.gnu.org> From: Jason Merrill In-Reply-To: <20240228192843.188979-8-kmatsui@gcc.gnu.org> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-13.3 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H4,RCVD_IN_MSPIKE_WL,RCVD_IN_SORBS_WEB,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 2/28/24 11:26, Ken Matsui wrote: > This patch implements built-in trait for std::is_unbounded_array. OK. > gcc/cp/ChangeLog: > > * cp-trait.def: Define __is_unbounded_array. > * constraint.cc (diagnose_trait_expr): Handle > CPTK_IS_UNBOUNDED_ARRAY. > * semantics.cc (trait_expr_value): Likewise. > (finish_trait_expr): Likewise. > > gcc/testsuite/ChangeLog: > > * g++.dg/ext/has-builtin-1.C: Test existence of > __is_unbounded_array. > * g++.dg/ext/is_unbounded_array.C: New test. > > Signed-off-by: Ken Matsui > --- > gcc/cp/constraint.cc | 3 ++ > gcc/cp/cp-trait.def | 1 + > gcc/cp/semantics.cc | 4 ++ > gcc/testsuite/g++.dg/ext/has-builtin-1.C | 3 ++ > gcc/testsuite/g++.dg/ext/is_unbounded_array.C | 37 +++++++++++++++++++ > 5 files changed, 48 insertions(+) > create mode 100644 gcc/testsuite/g++.dg/ext/is_unbounded_array.C > > diff --git a/gcc/cp/constraint.cc b/gcc/cp/constraint.cc > index 244070d93c2..000df847342 100644 > --- a/gcc/cp/constraint.cc > +++ b/gcc/cp/constraint.cc > @@ -3861,6 +3861,9 @@ diagnose_trait_expr (tree expr, tree args) > case CPTK_IS_TRIVIALLY_COPYABLE: > inform (loc, " %qT is not trivially copyable", t1); > break; > + case CPTK_IS_UNBOUNDED_ARRAY: > + inform (loc, " %qT is not an unbounded array", t1); > + break; > case CPTK_IS_UNION: > inform (loc, " %qT is not a union", t1); > break; > diff --git a/gcc/cp/cp-trait.def b/gcc/cp/cp-trait.def > index 18e2d0f3480..05514a51c21 100644 > --- a/gcc/cp/cp-trait.def > +++ b/gcc/cp/cp-trait.def > @@ -92,6 +92,7 @@ DEFTRAIT_EXPR (IS_TRIVIAL, "__is_trivial", 1) > DEFTRAIT_EXPR (IS_TRIVIALLY_ASSIGNABLE, "__is_trivially_assignable", 2) > DEFTRAIT_EXPR (IS_TRIVIALLY_CONSTRUCTIBLE, "__is_trivially_constructible", -1) > DEFTRAIT_EXPR (IS_TRIVIALLY_COPYABLE, "__is_trivially_copyable", 1) > +DEFTRAIT_EXPR (IS_UNBOUNDED_ARRAY, "__is_unbounded_array", 1) > DEFTRAIT_EXPR (IS_UNION, "__is_union", 1) > DEFTRAIT_EXPR (IS_VOLATILE, "__is_volatile", 1) > DEFTRAIT_EXPR (REF_CONSTRUCTS_FROM_TEMPORARY, "__reference_constructs_from_temporary", 2) > diff --git a/gcc/cp/semantics.cc b/gcc/cp/semantics.cc > index 9dcdb06191a..1794e83baa2 100644 > --- a/gcc/cp/semantics.cc > +++ b/gcc/cp/semantics.cc > @@ -12532,6 +12532,9 @@ trait_expr_value (cp_trait_kind kind, tree type1, tree type2) > case CPTK_IS_TRIVIALLY_COPYABLE: > return trivially_copyable_p (type1); > > + case CPTK_IS_UNBOUNDED_ARRAY: > + return array_of_unknown_bound_p (type1); > + > case CPTK_IS_UNION: > return type_code1 == UNION_TYPE; > > @@ -12708,6 +12711,7 @@ finish_trait_expr (location_t loc, cp_trait_kind kind, tree type1, tree type2) > case CPTK_IS_REFERENCE: > case CPTK_IS_SAME: > case CPTK_IS_SCOPED_ENUM: > + case CPTK_IS_UNBOUNDED_ARRAY: > case CPTK_IS_UNION: > case CPTK_IS_VOLATILE: > break; > diff --git a/gcc/testsuite/g++.dg/ext/has-builtin-1.C b/gcc/testsuite/g++.dg/ext/has-builtin-1.C > index 96b7a89e4f1..b1430e9bd8b 100644 > --- a/gcc/testsuite/g++.dg/ext/has-builtin-1.C > +++ b/gcc/testsuite/g++.dg/ext/has-builtin-1.C > @@ -158,6 +158,9 @@ > #if !__has_builtin (__is_trivially_copyable) > # error "__has_builtin (__is_trivially_copyable) failed" > #endif > +#if !__has_builtin (__is_unbounded_array) > +# error "__has_builtin (__is_unbounded_array) failed" > +#endif > #if !__has_builtin (__is_union) > # error "__has_builtin (__is_union) failed" > #endif > diff --git a/gcc/testsuite/g++.dg/ext/is_unbounded_array.C b/gcc/testsuite/g++.dg/ext/is_unbounded_array.C > new file mode 100644 > index 00000000000..283a74e1a0a > --- /dev/null > +++ b/gcc/testsuite/g++.dg/ext/is_unbounded_array.C > @@ -0,0 +1,37 @@ > +// { dg-do compile { target c++11 } } > + > +#define SA(X) static_assert((X),#X) > + > +#define SA_TEST_CATEGORY(TRAIT, TYPE, EXPECT) \ > + SA(TRAIT(TYPE) == EXPECT); \ > + SA(TRAIT(const TYPE) == EXPECT); \ > + SA(TRAIT(volatile TYPE) == EXPECT); \ > + SA(TRAIT(const volatile TYPE) == EXPECT) > + > +class ClassType { }; > +class IncompleteClass; > +union IncompleteUnion; > + > +SA_TEST_CATEGORY(__is_unbounded_array, int[2], false); > +SA_TEST_CATEGORY(__is_unbounded_array, int[], true); > +SA_TEST_CATEGORY(__is_unbounded_array, int[2][3], false); > +SA_TEST_CATEGORY(__is_unbounded_array, int[][3], true); > +SA_TEST_CATEGORY(__is_unbounded_array, float*[2], false); > +SA_TEST_CATEGORY(__is_unbounded_array, float*[], true); > +SA_TEST_CATEGORY(__is_unbounded_array, float*[2][3], false); > +SA_TEST_CATEGORY(__is_unbounded_array, float*[][3], true); > +SA_TEST_CATEGORY(__is_unbounded_array, ClassType[2], false); > +SA_TEST_CATEGORY(__is_unbounded_array, ClassType[], true); > +SA_TEST_CATEGORY(__is_unbounded_array, ClassType[2][3], false); > +SA_TEST_CATEGORY(__is_unbounded_array, ClassType[][3], true); > +SA_TEST_CATEGORY(__is_unbounded_array, IncompleteClass[2][3], false); > +SA_TEST_CATEGORY(__is_unbounded_array, IncompleteClass[][3], true); > +SA_TEST_CATEGORY(__is_unbounded_array, int(*)[2], false); > +SA_TEST_CATEGORY(__is_unbounded_array, int(*)[], false); > +SA_TEST_CATEGORY(__is_unbounded_array, int(&)[2], false); > +SA_TEST_CATEGORY(__is_unbounded_array, int(&)[], false); > + > +// Sanity check. > +SA_TEST_CATEGORY(__is_unbounded_array, ClassType, false); > +SA_TEST_CATEGORY(__is_unbounded_array, IncompleteClass, false); > +SA_TEST_CATEGORY(__is_unbounded_array, IncompleteUnion, false);