From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id 6D16E3849AD8 for ; Thu, 2 May 2024 19:49:33 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 6D16E3849AD8 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 6D16E3849AD8 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=170.10.133.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1714679376; cv=none; b=L/rHImT6DoWVjVafq+MB1QVBk7mcgxN6aihPnA6zrKUFsBsdE80bGWcSSc99ykt0BKN769iLubOtQYTqVOcZ560lNeHfWVUdxAXw4mnzNLx7RoCGhSJQzjvEVsO4W+FxO+H/LSFjLNcUBt3VVaB3deZ4kY4h4kJrw+kZo7lzxfc= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1714679376; c=relaxed/simple; bh=pbwqjna84gi0AK7qvHz+/eSNTnfjjVdF43j95BsBsn4=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=t5Hg8Ejitm/97n747wY0idZZqwznSVAC9eDP8dghD1XoIYHQQGs0W04GztUlW9K9Pc7EKuuPiXsBHc95jelg5ZtUpJHCeU02UNSTw6Vh6X+lHMCD9d6BrOfBZLQxiJBX1F5W3ufxzpo53T2GpZ6rtapXZtaSHFWmnGE4M0nunGk= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1714679373; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=G2RFR82jvfw4g4qi5b+vySxgk5i4JMPqyMwxNyX9f0g=; b=d4ExrYFWdJENelQelQcTzOrQYcJgTe6xRDU+ugz86SC+wYmU2VjMKM2DBTNEEY9VBf9iRp JC3/3QUZ18P2RGQ1RP6JszPxCP3xDM6eNspUIxi3gaovRA9T2JLhqhexi04ZPNHuCjuKGx /CXTCnx/vlp5clX/zHIJvQQG8ZGmzkI= Received: from mail-qv1-f71.google.com (mail-qv1-f71.google.com [209.85.219.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-484-jw1mesXTNUW1bxAvTIOrAA-1; Thu, 02 May 2024 15:49:31 -0400 X-MC-Unique: jw1mesXTNUW1bxAvTIOrAA-1 Received: by mail-qv1-f71.google.com with SMTP id 6a1803df08f44-6a0fd863897so16917376d6.0 for ; Thu, 02 May 2024 12:49:31 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1714679371; x=1715284171; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=G2RFR82jvfw4g4qi5b+vySxgk5i4JMPqyMwxNyX9f0g=; b=NqapRmISapAjGtBwGHCEjOYIb0MJTBLFi0AVgHG6Qnv1eDhJkeTATt+DCvADxnm3Yr XHeNmUZUimrWSdBxRBMgKTZKO1JhoICzT103BF7tprKPjsPIBeTdEz4f38fGe6fndVJs S14rc5SsRn8LiNH4QlddFmcOWPAJI59SbKZUK5Kt17rRuuianxtjG2XFBUlRlrbpmAMQ XlAinCnNn3P9t632EPPZuj5YAzpIN3dVZhewQS2qSgik3qOTFUPI/QlOIppUgcQTqH1l wmzJQo6lek4kwOWzubkhWSZAPc0DrnRjFJy95drm//IwdDLQkxemnO4cAN4Y4/jpBrIc nW3A== X-Gm-Message-State: AOJu0YwUwJKEobglAas1ZtjVXdS6E+dTyy0itGYxiiOYZnzCoJb6SPjy 1wESoYzpACctMBTctDqJO6qX2DxMEEOdVEi3zs4xKz88omwtjFOlfUok3TRxut/ikKSkcwT1EOw CIG43jsvijrJoVrpdJ3LSNDgySGc8z2grcqvOFzwG86WcEa8kwNWfLPCklk85 X-Received: by 2002:a05:6214:2304:b0:6a0:b3de:e3ad with SMTP id gc4-20020a056214230400b006a0b3dee3admr601364qvb.55.1714679371088; Thu, 02 May 2024 12:49:31 -0700 (PDT) X-Google-Smtp-Source: AGHT+IETPXXF+V8631tt0bbfTUs6zvBckQel5BpXi9QtaPfdpx7yV4oQ52MpFhG8h6kYaHzAEc4yAg== X-Received: by 2002:a05:6214:2304:b0:6a0:b3de:e3ad with SMTP id gc4-20020a056214230400b006a0b3dee3admr601349qvb.55.1714679370757; Thu, 02 May 2024 12:49:30 -0700 (PDT) Received: from [192.168.1.130] (130-44-146-16.s12558.c3-0.arl-cbr1.sbo-arl.ma.cable.rcncustomer.com. [130.44.146.16]) by smtp.gmail.com with ESMTPSA id n10-20020a0cec4a000000b006a0e9eda182sm591633qvq.124.2024.05.02.12.49.29 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 02 May 2024 12:49:30 -0700 (PDT) Message-ID: <6c33db5b-77a6-41fd-8931-2c9be81a2bde@redhat.com> Date: Thu, 2 May 2024 15:49:29 -0400 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v17 01/26] c++: Implement __is_const built-in trait To: Ken Matsui , gcc-patches@gcc.gnu.org Cc: libstdc++@gcc.gnu.org References: <20240502161614.3705912-1-kmatsui@gcc.gnu.org> <20240502184529.97337-1-kmatsui@gcc.gnu.org> <20240502184529.97337-2-kmatsui@gcc.gnu.org> From: Jason Merrill In-Reply-To: <20240502184529.97337-2-kmatsui@gcc.gnu.org> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-13.7 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H4,RCVD_IN_MSPIKE_WL,RCVD_IN_SORBS_WEB,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 5/2/24 14:42, Ken Matsui wrote: > This patch implements built-in trait for std::is_const. OK. > gcc/cp/ChangeLog: > > * cp-trait.def: Define __is_const. > * constraint.cc (diagnose_trait_expr): Handle CPTK_IS_CONST. > * semantics.cc (trait_expr_value): Likewise. > (finish_trait_expr): Likewise. > > gcc/testsuite/ChangeLog: > > * g++.dg/ext/has-builtin-1.C: Test existence of __is_const. > * g++.dg/ext/is_const.C: New test. > > Signed-off-by: Ken Matsui > --- > gcc/cp/constraint.cc | 3 +++ > gcc/cp/cp-trait.def | 1 + > gcc/cp/semantics.cc | 4 ++++ > gcc/testsuite/g++.dg/ext/has-builtin-1.C | 3 +++ > gcc/testsuite/g++.dg/ext/is_const.C | 20 ++++++++++++++++++++ > 5 files changed, 31 insertions(+) > create mode 100644 gcc/testsuite/g++.dg/ext/is_const.C > > diff --git a/gcc/cp/constraint.cc b/gcc/cp/constraint.cc > index 8a3b5d80ba7..eaf17a50877 100644 > --- a/gcc/cp/constraint.cc > +++ b/gcc/cp/constraint.cc > @@ -3768,6 +3768,9 @@ diagnose_trait_expr (tree expr, tree args) > case CPTK_IS_CLASS: > inform (loc, " %qT is not a class", t1); > break; > + case CPTK_IS_CONST: > + inform (loc, " %qT is not a const type", t1); > + break; > case CPTK_IS_CONSTRUCTIBLE: > if (!t2) > inform (loc, " %qT is not default constructible", t1); > diff --git a/gcc/cp/cp-trait.def b/gcc/cp/cp-trait.def > index 394f006f20f..36faed9c0b3 100644 > --- a/gcc/cp/cp-trait.def > +++ b/gcc/cp/cp-trait.def > @@ -64,6 +64,7 @@ DEFTRAIT_EXPR (IS_ASSIGNABLE, "__is_assignable", 2) > DEFTRAIT_EXPR (IS_BASE_OF, "__is_base_of", 2) > DEFTRAIT_EXPR (IS_BOUNDED_ARRAY, "__is_bounded_array", 1) > DEFTRAIT_EXPR (IS_CLASS, "__is_class", 1) > +DEFTRAIT_EXPR (IS_CONST, "__is_const", 1) > DEFTRAIT_EXPR (IS_CONSTRUCTIBLE, "__is_constructible", -1) > DEFTRAIT_EXPR (IS_CONVERTIBLE, "__is_convertible", 2) > DEFTRAIT_EXPR (IS_EMPTY, "__is_empty", 1) > diff --git a/gcc/cp/semantics.cc b/gcc/cp/semantics.cc > index 2dde65a970b..fa7ba6a9edc 100644 > --- a/gcc/cp/semantics.cc > +++ b/gcc/cp/semantics.cc > @@ -12530,6 +12530,9 @@ trait_expr_value (cp_trait_kind kind, tree type1, tree type2) > case CPTK_IS_CLASS: > return NON_UNION_CLASS_TYPE_P (type1); > > + case CPTK_IS_CONST: > + return CP_TYPE_CONST_P (type1); > + > case CPTK_IS_CONSTRUCTIBLE: > return is_xible (INIT_EXPR, type1, type2); > > @@ -12812,6 +12815,7 @@ finish_trait_expr (location_t loc, cp_trait_kind kind, tree type1, tree type2) > case CPTK_IS_ARRAY: > case CPTK_IS_BOUNDED_ARRAY: > case CPTK_IS_CLASS: > + case CPTK_IS_CONST: > case CPTK_IS_ENUM: > case CPTK_IS_FUNCTION: > case CPTK_IS_MEMBER_FUNCTION_POINTER: > diff --git a/gcc/testsuite/g++.dg/ext/has-builtin-1.C b/gcc/testsuite/g++.dg/ext/has-builtin-1.C > index 02b4b4d745d..e3640faeb96 100644 > --- a/gcc/testsuite/g++.dg/ext/has-builtin-1.C > +++ b/gcc/testsuite/g++.dg/ext/has-builtin-1.C > @@ -71,6 +71,9 @@ > #if !__has_builtin (__is_class) > # error "__has_builtin (__is_class) failed" > #endif > +#if !__has_builtin (__is_const) > +# error "__has_builtin (__is_const) failed" > +#endif > #if !__has_builtin (__is_constructible) > # error "__has_builtin (__is_constructible) failed" > #endif > diff --git a/gcc/testsuite/g++.dg/ext/is_const.C b/gcc/testsuite/g++.dg/ext/is_const.C > new file mode 100644 > index 00000000000..8a0e8df72a9 > --- /dev/null > +++ b/gcc/testsuite/g++.dg/ext/is_const.C > @@ -0,0 +1,20 @@ > +// { dg-do compile { target c++11 } } > + > +#define SA(X) static_assert((X),#X) > + > +class ClassType { }; > +using cClassType = const ClassType; > +using vClassType = volatile ClassType; > +using cvClassType = const volatile ClassType; > + > +// Positive tests. > +SA(__is_const(const int)); > +SA(__is_const(const volatile int)); > +SA(__is_const(cClassType)); > +SA(__is_const(cvClassType)); > + > +// Negative tests. > +SA(!__is_const(int)); > +SA(!__is_const(volatile int)); > +SA(!__is_const(ClassType)); > +SA(!__is_const(vClassType));