From: "François Dumont" <frs.dumont@gmail.com>
To: Jonathan Wakely <jwakely@redhat.com>
Cc: libstdc++@gcc.gnu.org, gcc-patches@gcc.gnu.org
Subject: Re: libstdc++: Fix deadlock in debug iterator increment [PR108288]
Date: Thu, 12 Jan 2023 19:25:02 +0100 [thread overview]
Message-ID: <6f88e8e7-6771-d344-beb4-1ca37d79dd5c@gmail.com> (raw)
In-Reply-To: <CACb0b4mD_X7OMv1drnHbNU9t9=jtw25s9N+GH_9g4_YCA7yvtw@mail.gmail.com>
On 12/01/23 13:00, Jonathan Wakely wrote:
> On Thu, 12 Jan 2023 at 05:52, François Dumont wrote:
>> Small update for an obvious compilation issue and to review new test
>> case that could have lead to an infinite loop if the increment issue was
>> not detected.
>>
>> I also forgot to ask if there is more chance for the instantiation to be
>> elided when it is implemented like in the _Safe_local_iterator:
>> return { __cur, this->_M_sequence };
> No, that doesn't make any difference.
>
>> than in the _Safe_iterator:
>> return _Safe_iterator(__cur, this->_M_sequence);
>>
>> In the case where the user code do not use it ?
>>
>> Fully tested now, ok to commit ?
>>
>> François
>>
>> On 11/01/23 07:03, François Dumont wrote:
>>> Thanks for fixing this.
>>>
>>> Here is the extension of the fix to all post-increment/decrement
>>> operators we have on _GLIBCXX_DEBUG iterator.
> Thanks, I completely forgot we have other partial specializations, I
> just fixed the one that showed a deadlock in the user's example!
>
>>> I prefer to restore somehow previous implementation to continue to
>>> have _GLIBCXX_DEBUG post operators implemented in terms of normal post
>>> operators.
> Why?
>
> Implementing post-increment as:
>
> auto tmp = *this;
> ++*this;
> return tmp;
>
> is the idiomatic way to write it, and it works fine in this case. I
> don't think it performs any more work than your version, does it?
> Why not use the idiomatic form?
>
> Is it just so that post-inc of a debug iterator uses post-inc of the
> underlying iterator? Why does that matter?
>
A little yes, but that's a minor reason that is just making me happy.
Main reason is that this form could produce a __msg_init_copy_singular
before the __msg_bad_inc.
And moreover I plan to propose a patch later to skip any check in the
call to _Safe_iterator(__cur, _M_sequence) as we already know that __cur
is ok here like anywhere else in the lib.
There will still be one in the constructor normally elided unless
--no-elide-constructors but there is not much I can do about it.
next prev parent reply other threads:[~2023-01-12 18:25 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-06 11:54 [committed] " Jonathan Wakely
2023-01-11 6:03 ` François Dumont
2023-01-12 5:52 ` François Dumont
2023-01-12 12:00 ` Jonathan Wakely
2023-01-12 18:25 ` François Dumont [this message]
2023-01-12 21:35 ` Jonathan Wakely
2023-01-15 16:08 ` François Dumont
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6f88e8e7-6771-d344-beb4-1ca37d79dd5c@gmail.com \
--to=frs.dumont@gmail.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=jwakely@redhat.com \
--cc=libstdc++@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).