From: "François Dumont" <frs.dumont@gmail.com>
To: Jonathan Wakely <jwakely@redhat.com>
Cc: libstdc++ <libstdc++@gcc.gnu.org>, gcc-patches <gcc-patches@gcc.gnu.org>
Subject: Re: [PATH][_GLIBCXX_DEBUG] Fix unordered container merge
Date: Thu, 11 Nov 2021 22:33:27 +0100 [thread overview]
Message-ID: <74588721-da55-6caa-d578-336410bd0112@gmail.com> (raw)
In-Reply-To: <CACb0b4kRFecQM1Sd20zXWf8vGkG3y6f3SFtDDbXSM+zeS+OQCQ@mail.gmail.com>
On 11/11/21 9:41 pm, Jonathan Wakely wrote:
>
>
> On Wed, 10 Nov 2021 at 11:55, Jonathan Wakely <jwakely@redhat.com
> <mailto:jwakely@redhat.com>> wrote:
>
>
>
> On Tue, 9 Nov 2021 at 16:25, Jonathan Wakely <jwakely@redhat.com
> <mailto:jwakely@redhat.com>> wrote:
>
>
>
> On Mon, 8 Nov 2021 at 21:36, François Dumont
> <frs.dumont@gmail.com <mailto:frs.dumont@gmail.com>> wrote:
>
> Yet another version this time with only 1 guard
> implementation. The predicate to invalidate the safe
> iterators has been externalized.
>
> Ok to commit ?
>
>
> I like this version a lot - thanks for persisting with it.
>
>
>
> I'm seeing new failures with this:
>
> make check
> RUNTESTFLAGS="conformance.exp=23_containers/*/invalidation/*
> --target_board=unix/-D_GLIBCXX_DEBUG/-std=gnu++98"
>
> FAIL: 23_containers/deque/debug/invalidation/1.cc (test for excess
> errors)
> FAIL: 23_containers/list/debug/invalidation/1.cc (test for excess
> errors)
> FAIL: 23_containers/map/debug/invalidation/1.cc (test for excess
> errors)
> FAIL: 23_containers/multimap/debug/invalidation/1.cc (test for
> excess errors)
> FAIL: 23_containers/multiset/debug/invalidation/1.cc (test for
> excess errors)
> FAIL: 23_containers/set/debug/invalidation/1.cc (test for excess
> errors)
> FAIL: 23_containers/vector/debug/invalidation/1.cc (test for
> excess errors)
>
>
> It's caused by:
>
> --- a/libstdc++-v3/include/debug/safe_container.h
> +++ b/libstdc++-v3/include/debug/safe_container.h
> @@ -78,7 +78,6 @@namespace __gnu_debug
> { }
> #endif
>
> - public:
> // Copy assignment invalidate all iterators.
> _Safe_container&
> operator=(const _Safe_container&) _GLIBCXX_NOEXCEPT
>
>
> For C++98 mode that gets called explicitly by the user-provided copy
> assignment operators in the derived class.
>
> I'm testing the attached fix.
>
I am also testing a patch but yours looks nicer so go ahead. I'll just
complete it with some additional cleanup I did to suppress
_Safe_container::_M_safe() and reduce usages of _M_base().
Thanks
next prev parent reply other threads:[~2021-11-11 21:33 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-13 17:10 François Dumont
2021-10-14 8:23 ` Jonathan Wakely
2021-10-16 13:47 ` François Dumont
2021-10-16 14:52 ` Jonathan Wakely
2021-10-21 16:51 ` François Dumont
2021-10-21 16:55 ` Jonathan Wakely
2021-10-22 5:22 ` François Dumont
2021-10-25 18:08 ` François Dumont
2021-11-06 13:51 ` François Dumont
2021-11-08 21:36 ` François Dumont
2021-11-09 16:25 ` Jonathan Wakely
2021-11-10 5:47 ` François Dumont
2021-11-10 9:38 ` Jonathan Wakely
2021-11-15 18:16 ` François Dumont
2021-11-10 11:55 ` Jonathan Wakely
2021-11-11 20:41 ` Jonathan Wakely
2021-11-11 21:33 ` François Dumont [this message]
2021-11-11 22:01 ` Jonathan Wakely
2021-11-10 0:05 ` H.J. Lu
2021-11-10 5:44 ` François Dumont
2021-11-10 7:26 ` Jonathan Wakely
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=74588721-da55-6caa-d578-336410bd0112@gmail.com \
--to=frs.dumont@gmail.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=jwakely@redhat.com \
--cc=libstdc++@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).