Re: [PATCH] libsupc++: try cxa_thread_atexit_impl at runtime

[Jason Merrill <jason@redhat.com>]

On 12/1/23 15:40, Alexandre Oliva wrote:
> On Nov  9, 2023, Jonathan Wakely <jwakely@redhat.com> wrote:
> 
>> On Thu, 9 Nov 2023 at 01:56, Alexandre Oliva <oliva@adacore.com> wrote:
> 
>>> g++.dg/tls/thread_local-order2.C fails when the toolchain is built for
>>> a platform that lacks __cxa_thread_atexit_impl, even if the program is
>>> built and run using that toolchain on a (later) platform that offers
>>> __cxa_thread_atexit_impl.
>>>
>>> This patch adds runtime testing for __cxa_thread_atexit_impl on
>>> platforms that support weak symbols.
>>>
>>> Regstrapped on x86_64-linux-gnu, also tested with gcc-13 on i686- and
>>> x86_64-, and with ac_cv_func___cxa_thread_atexit_impl=no, that, on a
>>> distro that lacks __cxa_thread_atexit in libc, forces the newly-added
>>> code to be exercised, and that enabled thread_local-order2.C to pass
>>> where the runtime libc has __cxa_thread_atexit_impl.  Ok to install?
> 
>> Seems fine to me. Any objections, Jason?
> 
> Jason, ping?
> https://gcc.gnu.org/pipermail/gcc-patches/2023-November/635750.html

OK by me.

Jason