From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id 31E59385C6EE for ; Fri, 1 Dec 2023 20:41:52 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 31E59385C6EE Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 31E59385C6EE Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=170.10.129.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1701463313; cv=none; b=NKP/fBnbWkiycsLQans6K4Gdd7NTQ9uaZKwA0F3m4NaT/TKSB9hTsJd+SRaUk8S6zfGlDLcV3KsJ0pjUDqIQAmRSocHdORZOKmjizVEJo/k5HKiLxJ3oevU+NkAAwOPkXUP4FzhU82GTr5oOEU2Sv6GoR45Mle9mBySv0A0Sy68= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1701463313; c=relaxed/simple; bh=WoWBIxAp3ECj/UI67ffY1myfbJII+aclpTPm0Fp6le4=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=UmvAbsf/5ykXlFiWZ9hn1sDCQVzxnMCHCt6RaG/LF8D4Z/Wv1x214xIpw4DeptoaPzGVO/pAKQunQT4MFAgeqRG/PKZbdbC8C37spRZxniDzBaZRNOV7kCAMG7jsDX/O3l1Tb1ixVNTDgDmQ+sRvP4VQ0SU6uPvV49AMG2rFQqE= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1701463311; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=X4NQzQXOHHsr8ZIfnu1DFzFkVAOAzmtqdS7wxRTgtGQ=; b=cOHYuMwDpVV6+xCZkiswqgD9NtBq7MVguj+XbchmQeLn88ZbGZZ4+vatS4UhjmzVGCeIDF gc+rEn4Z7lJiKH9QFqyuBbJQoSqr/JpF+KYtYcFECWbY1CWbifMDPmJ2v3EV3c/92E1y5u DY3abPQz7KDSL8EpLuLFIFBHUV9pb14= Received: from mail-vs1-f70.google.com (mail-vs1-f70.google.com [209.85.217.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-655-sKoYG7RqOO-DMttBiZLarA-1; Fri, 01 Dec 2023 15:41:50 -0500 X-MC-Unique: sKoYG7RqOO-DMttBiZLarA-1 Received: by mail-vs1-f70.google.com with SMTP id ada2fe7eead31-46454bf00daso919114137.2 for ; Fri, 01 Dec 2023 12:41:50 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1701463309; x=1702068109; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=X4NQzQXOHHsr8ZIfnu1DFzFkVAOAzmtqdS7wxRTgtGQ=; b=EolZs7JmzajF+R9pj/m7J5ERX25yGoKGwvSj7zO1I4uO/fkOctqAnHxWEKix6/xRKY jT0wIeqDBoczOFQpjm7KnWNKnsBzJFurYC8rYeRIkmCGnHkmvNnQ7K0W85s7yJQ5GVvz r8o5Wjg3giTSllYd/l6+fF5Isr44FIB9FN6qWCbF8vmNvUKrzxzsQbJQ+qweQlZbse/j 2Lj4msdgu19IQuIqapsrC1lBZ7PQYGvPp+gF2yjzmlicplmWVG2eHflYBaWwRBXF2wEU byUoCpTewGLn+/pRxYYz10AqzX+iVTCQgc4BLYcAFFalzU0LsS28BJrQF6/RhdPO/14e PEYg== X-Gm-Message-State: AOJu0YxtDU/x+siRA1Il8+xpFePa/oJTsztTlIs6gtoRdMoo/SBDhw7K byBhT+9pfVSyfV6hbkZ+2LyelnsI3lMelyk8YvngU46XqDZda0E3nGa0YndEzEoiMF6+8uJ1pY/ a9Bin/RVhpzzYxvk= X-Received: by 2002:a67:e205:0:b0:464:6881:6061 with SMTP id g5-20020a67e205000000b0046468816061mr149425vsa.21.1701463309651; Fri, 01 Dec 2023 12:41:49 -0800 (PST) X-Google-Smtp-Source: AGHT+IEAroznzpse5Dhs6JTxtnLbr69C5Oa2s+/B6zHDjfJMvOpqLjzfjj9TxXMzWOYo08O49Sb7lg== X-Received: by 2002:a67:e205:0:b0:464:6881:6061 with SMTP id g5-20020a67e205000000b0046468816061mr149412vsa.21.1701463308808; Fri, 01 Dec 2023 12:41:48 -0800 (PST) Received: from [192.168.1.145] (130-44-146-16.s12558.c3-0.arl-cbr1.sbo-arl.ma.cable.rcncustomer.com. [130.44.146.16]) by smtp.gmail.com with ESMTPSA id jc15-20020a056102128f00b00464540c1303sm559260vsb.3.2023.12.01.12.41.48 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 01 Dec 2023 12:41:48 -0800 (PST) Message-ID: <7783cf42-7e2f-4792-a863-2038a573b655@redhat.com> Date: Fri, 1 Dec 2023 15:41:46 -0500 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] libsupc++: try cxa_thread_atexit_impl at runtime To: Alexandre Oliva , Jonathan Wakely Cc: gcc-patches@gcc.gnu.org, libstdc++@gcc.gnu.org References: From: Jason Merrill In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-3.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,KAM_SHORT,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H4,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,TXREP,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 12/1/23 15:40, Alexandre Oliva wrote: > On Nov 9, 2023, Jonathan Wakely wrote: > >> On Thu, 9 Nov 2023 at 01:56, Alexandre Oliva wrote: > >>> g++.dg/tls/thread_local-order2.C fails when the toolchain is built for >>> a platform that lacks __cxa_thread_atexit_impl, even if the program is >>> built and run using that toolchain on a (later) platform that offers >>> __cxa_thread_atexit_impl. >>> >>> This patch adds runtime testing for __cxa_thread_atexit_impl on >>> platforms that support weak symbols. >>> >>> Regstrapped on x86_64-linux-gnu, also tested with gcc-13 on i686- and >>> x86_64-, and with ac_cv_func___cxa_thread_atexit_impl=no, that, on a >>> distro that lacks __cxa_thread_atexit in libc, forces the newly-added >>> code to be exercised, and that enabled thread_local-order2.C to pass >>> where the runtime libc has __cxa_thread_atexit_impl. Ok to install? > >> Seems fine to me. Any objections, Jason? > > Jason, ping? > https://gcc.gnu.org/pipermail/gcc-patches/2023-November/635750.html OK by me. Jason