From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ed1-x530.google.com (mail-ed1-x530.google.com [IPv6:2a00:1450:4864:20::530]) by sourceware.org (Postfix) with ESMTPS id A78B43858D1E; Thu, 7 Sep 2023 16:59:56 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org A78B43858D1E Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-ed1-x530.google.com with SMTP id 4fb4d7f45d1cf-52c9f1bd05dso1608118a12.3; Thu, 07 Sep 2023 09:59:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1694105995; x=1694710795; darn=gcc.gnu.org; h=content-transfer-encoding:in-reply-to:references:cc:to:from :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=6oPLmmsj565HxUYaYjMmsUIsrFrfcygN7T+JfLFz4Y8=; b=rA9Ap1IOUcOumzClr04aGIzq5zX2JBlpK219xIQ7AmBV6FRsdi/8ry4YP+9a+ifMEy H9tMAR0wP6A7oiefJuvawuZLCQdEUo92gE+Us9NePz+5KgMHLycsfWEq71nvHZkmHJtd wcWPOVDtp4SeM1BUlw9ngfpVFOtxJUA9hJajFVULvHqh80YypTTquUcNPBQRWw+l5ceQ OxOhndCcc+vD4GuaPDYBdm+cAc0vFrpm9owkOfsdu9kMIQkHmHx9U5mRJXPBOFvfXfVx Y42pJ2JTSe0gp+NrsN5gj3jG3RH/oqZhCBNm6PTLP2BPJdWmCT0asgOGGqccLUFp5u6A K5sQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1694105995; x=1694710795; h=content-transfer-encoding:in-reply-to:references:cc:to:from :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=6oPLmmsj565HxUYaYjMmsUIsrFrfcygN7T+JfLFz4Y8=; b=WmkmtA/MszwPNN/L9004eYVVItm8egvkB7iCDVvHchnpxK7tr2DaYDXqWmOs2SvR38 FhyeolddzK0Xyjdu/7EVFfwrJOc4TczA0NE35U0K7JW5/ER9zS+PaTCKV5aQHtU3NPzZ n9ng19tsdTH5EELrjfDUNKbvjz5Ee5wPA9L5HvOqSbQwxpRaMZz7Ah79GaFEVAKofMh5 Hs30ckDHsS3+x2pTdjZJC2bRQU5PyVRNvoyKRlPIQPluCQgWwvjhuPQ3OSak9kaY/4z2 W9NUQ21iMTDVirNhRmt3155i6ew+YZzOEfVlf+llpKpn8xYjxTnyqe24BHo+50BefXVU dAaQ== X-Gm-Message-State: AOJu0YwIkPyItLFnaV2eLrw79spG/n2ok+AxLRK29PwKsSoHCzbA6iaY 04vKfuJpWhjMVBEV/Ac+hVq9sDbSzRw= X-Google-Smtp-Source: AGHT+IE6YDtxA5uusD6E7pUxA3dUENkfvlh3CbTuoyEiAQKXAbWoVAPh/PlNNK6eS9GU5+bKD7xk7A== X-Received: by 2002:a17:906:297:b0:9a5:c5fe:af85 with SMTP id 23-20020a170906029700b009a5c5feaf85mr5755243ejf.3.1694105994761; Thu, 07 Sep 2023 09:59:54 -0700 (PDT) Received: from [10.25.1.214] ([89.207.171.100]) by smtp.gmail.com with ESMTPSA id le19-20020a170906ae1300b009930042510csm10705680ejb.222.2023.09.07.09.59.49 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 07 Sep 2023 09:59:54 -0700 (PDT) Message-ID: <7a3f6f31-d0a6-3043-95c4-c495c1e26cfc@gmail.com> Date: Thu, 7 Sep 2023 18:59:45 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Subject: Re: [PATCH][_GLIBCXX_INLINE_VERSION] Fix friend declarations Content-Language: en-US From: =?UTF-8?Q?Fran=c3=a7ois_Dumont?= To: libstdc++ Cc: gcc-patches References: In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-3.2 required=5.0 tests=BAYES_00,BODY_8BITS,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Hi Any news regarding this problem ? François On 23/08/2023 19:35, François Dumont wrote: > Hi > > The few tests that are failing in versioned namespace mode are due to > those friend declarations. > > This is a fix proposal even if I considered 2 other options: > > 1. Make __format::_Arg_store a struct and so do not bother with friend > declarations. > > 2. Consider it as a compiler bug and do nothing. In this case I think > we might still need this patch to avoid a non-working format library > in versioned namespace mode in gcc 14 if compiler bug is not fixed. > > I can also define _GLIBCXX_STD_V at level to limit impact. > >     libstdc++: [_GLIBCXX_INLINE_VERSION] Fix friend declarations > >     GCC do not consider the inline namespace in friend declarations. > We need >     to explicit this namespace. > >     libstdc++-v3/ChangeLog: > >             * include/bits/c++config (_GLIBCXX_STD_V): New macro > giving current >             std namespace with optionally the version namespace. >             * include/std/format (std::__format::_Arg_store): Use > latter on friend >             declarations. > > Tested under versioned mode. > > Ok to commit ? > > François