From: Patrick Palka <ppalka@redhat.com>
To: "Václav Haisman" <vhaisman@gmail.com>
Cc: libstdc++@gcc.gnu.org
Subject: Re: [PATCH 1/4] libstdc++: Import parts of the Ryu library
Date: Sun, 26 Jul 2020 09:09:32 -0400 (EDT) [thread overview]
Message-ID: <7ba2e45c-5bac-1da5-8051-658e5dbb4f8@idea> (raw)
In-Reply-To: <e9c28c74-f019-36fe-ca8e-bcccd5d358f2@gmail.com>
On Sat, 25 Jul 2020, Václav Haisman via Libstdc++ wrote:
> On 14. 07. 20 21:41, Patrick Palka via Libstdc++ wrote:
> > This imports the source files from the Ryu library that define
> > d2s_buffered_n, f2s_buffered_n, d2fixed_buffered_n and d2exp_buffered_n
> > and generic_binary_to_decimal, which we're going to need as part of our
> > std::to_chars implementation.
> >
> >[...]
> > diff --git a/libstdc++-v3/src/c++17/ryu/common.h b/libstdc++-v3/src/c++17/ryu/common.h
> > new file mode 100644
> > index 00000000000..7dc130947ac
> > --- /dev/null
> > +++ b/libstdc++-v3/src/c++17/ryu/common.h
> > @@ -0,0 +1,114 @@
> > +// Copyright 2018 Ulf Adams
> > +//
> > +// The contents of this file may be used under the terms of the Apache License,
> > +// Version 2.0.
> > +//
> > +// (See accompanying file LICENSE-Apache or copy at
> > +// http://www.apache.org/licenses/LICENSE-2.0)
> > +//
> > +// Alternatively, the contents of this file may be used under the terms of
> > +// the Boost Software License, Version 1.0.
> > +// (See accompanying file LICENSE-Boost or copy at
> > +// https://www.boost.org/LICENSE_1_0.txt)
> > +//
> > +// Unless required by applicable law or agreed to in writing, this software
> > +// is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
> > +// KIND, either express or implied.
> > +#ifndef RYU_COMMON_H
> > +#define RYU_COMMON_H
>
> Shouldn't these be renamed to not infringe on user's macros namespaces?
It's not necessary because these Ryu bits will be used only by
floating_to_chars.cc, which is where we define these to_chars overloads
completely out-of-line. So users won't ever see the Ryu bits.
>
> > +
> > +#include <assert.h>
> > +#include <stdint.h>
> > +#include <string.h>
> > +
> > +#if defined(_M_IX86) || defined(_M_ARM)
> > +#define RYU_32_BIT_PLATFORM
>
> Ditto?
>
> > +#endif
> >[...]
>
> --
> VH
>
>
next prev parent reply other threads:[~2020-07-26 13:09 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-14 19:41 Patrick Palka
2020-07-14 19:41 ` [PATCH 2/4] libstdc++: Apply modifications to our local copy of Ryu Patrick Palka
2020-07-15 18:12 ` Patrick Palka
2020-12-17 14:35 ` Jonathan Wakely
2020-07-14 19:41 ` [PATCH 3/4] libstdc++: Add floating-point std::to_chars implementation Patrick Palka
2020-07-15 18:21 ` Patrick Palka
2020-07-17 4:23 ` Patrick Palka
2020-07-17 16:24 ` Patrick Palka
2020-07-20 3:37 ` Patrick Palka
2020-07-20 12:31 ` Jonathan Wakely
2020-07-20 12:53 ` Patrick Palka
2020-07-20 14:13 ` Jonathan Wakely
2020-07-20 14:46 ` Patrick Palka
2020-07-22 15:56 ` Patrick Palka
2020-08-19 21:57 ` Patrick Palka
2020-12-17 14:32 ` Jonathan Wakely
2020-12-18 4:13 ` Patrick Palka
2020-12-18 13:24 ` Christophe Lyon
2020-12-18 14:58 ` Jonathan Wakely
2020-12-18 15:00 ` Patrick Palka
2020-12-18 16:52 ` Christophe Lyon
2020-12-18 17:03 ` Patrick Palka
2020-12-18 18:28 ` Christophe Lyon
2020-12-20 21:44 ` Maciej W. Rozycki
2020-12-21 17:06 ` Patrick Palka
2020-12-21 23:09 ` Maciej W. Rozycki
2020-07-14 19:41 ` [PATCH 4/4] libstdc++: Import MSVC floating-point std::to_chars testcases Patrick Palka
2020-07-14 19:49 ` Patrick Palka
2020-12-17 14:37 ` Jonathan Wakely
2020-07-14 19:46 ` [PATCH 1/4] libstdc++: Import parts of the Ryu library Patrick Palka
2020-07-25 11:44 ` Václav Haisman
2020-07-26 13:09 ` Patrick Palka [this message]
2020-12-17 14:34 ` Jonathan Wakely
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7ba2e45c-5bac-1da5-8051-658e5dbb4f8@idea \
--to=ppalka@redhat.com \
--cc=libstdc++@gcc.gnu.org \
--cc=vhaisman@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).