From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id 3F0773858D1E for ; Thu, 22 Dec 2022 22:21:47 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 3F0773858D1E Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1671747706; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=V4es3DmpU05UvwaRQ7APed6b9/FUZzCqHNeQgAUrIKI=; b=BU3nfSZ5xaTx1PSpZaTkCCG4tLmdSa4xtHViOaVb3JlxIrcMC0mvMHKzJ1WPwKAgYYDmxT tnHGBSxfrrYkJE28otBvn5POWfm4hU7ozpt65Ox1En+W8f1Nx9kZRi+MjvcRCJA0Aktif5 BqGHJR6wJWJF3ukuOSIYz5coHMvRXBE= Received: from mail-qv1-f72.google.com (mail-qv1-f72.google.com [209.85.219.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-184-md75TXZPNau7zRlzpqfQ7w-1; Thu, 22 Dec 2022 17:21:45 -0500 X-MC-Unique: md75TXZPNau7zRlzpqfQ7w-1 Received: by mail-qv1-f72.google.com with SMTP id jh2-20020a0562141fc200b004c74bbb0affso1601228qvb.21 for ; Thu, 22 Dec 2022 14:21:45 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=V4es3DmpU05UvwaRQ7APed6b9/FUZzCqHNeQgAUrIKI=; b=E41NwbkzInK/pqgHVV6WOYb9xLMZxZwE1qK6yi6ZgtRCX/V8JL6o1hgskEobcn+FQW w1VWLqFVCzDClurkhwwFWhkoXUDH1v3+zpmVmmaiv19xGS1oQB/8FRIm+nYv6wz7Cpqm lGh4aGIsE3mgt0vCw8bfQRHkeBCmMEOKWqRhwy48bNkku7+9tHizMtQilbq6j5xZbGD0 uPjGo+hQT0RSbnInUazh7cEm7QDSFGoCxjlHI3BGHuT/RC4Tb5C9PHrovT4ubcuN/GIn w763k43brupB94h2yy2GJEUjxhBXqnaeMMgRuIW4XKwSjsq/vHXO91o0zXd1IqAQKE8Q rMUg== X-Gm-Message-State: AFqh2kpi1l5ULMkqAJSW3vjLfxzBHLA5fEXBWd9RScT+jwiUrVmtzhba PjJTJnZ/HfVRagSH7sPa6IqmzPpg247ykguqFJbr0Z/1bbt/Qx/2iBlr96FeaUGPaqO4W7BT7DR 1C6SjusDRrlMcKDE= X-Received: by 2002:a05:622a:4810:b0:3a5:4e34:fafe with SMTP id fb16-20020a05622a481000b003a54e34fafemr10303232qtb.68.1671747705085; Thu, 22 Dec 2022 14:21:45 -0800 (PST) X-Google-Smtp-Source: AMrXdXuLea3i1lWrFoSCx3Nh6VfcULC+0P93hzyfa5T2BV4jgRvTZfvzbozpGE7GcN90czNgyhPbWQ== X-Received: by 2002:a05:622a:4810:b0:3a5:4e34:fafe with SMTP id fb16-20020a05622a481000b003a54e34fafemr10303214qtb.68.1671747704845; Thu, 22 Dec 2022 14:21:44 -0800 (PST) Received: from [192.168.1.108] (130-44-159-43.s15913.c3-0.arl-cbr1.sbo-arl.ma.cable.rcncustomer.com. [130.44.159.43]) by smtp.gmail.com with ESMTPSA id he9-20020a05622a600900b003a816011d51sm993338qtb.38.2022.12.22.14.21.43 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 22 Dec 2022 14:21:44 -0800 (PST) Message-ID: <84ca6a85-a353-878c-fec6-de2f0abcfcee@redhat.com> Date: Thu, 22 Dec 2022 17:21:43 -0500 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.5.1 Subject: Re: [PATCH 3/3] contrib: Add dg-out-generator.pl To: =?UTF-8?Q?Arsen_Arsenovi=c4=87?= Cc: gcc-patches@gcc.gnu.org, jwakely@redhat.com, libstdc++@gcc.gnu.org References: <20221222110306.3869396-3-arsen@aarsen.me> <86pmcbgkq4.fsf@aarsen.me> From: Jason Merrill In-Reply-To: <86pmcbgkq4.fsf@aarsen.me> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-7.0 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 12/22/22 16:56, Arsen Arsenović wrote: > Hi, > > Jason Merrill writes: >>> + # Newlines should be more tolerant. >>> + s/\n$/(\\n|\\r\\n|\\r)*/; >> >> Isn't specifically handling \\r\\n redundant with the * operator? > > To the extent of my knowledge, yes; I left that in since the original > tests I was replacing with this script also used this terminator: > > -// { dg-output "default std::handle_contract_violation called: .*.C 21 test::fun .*(\n|\r\n|\r)*" } Aha, I wonder why the original tests have the terminal *? Testcases elsewhere in the testsuite that check for (\n|\r\n|\r) don't use *. I think I'll drop the * from both the tests and the script. Jason