From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm1-x332.google.com (mail-wm1-x332.google.com [IPv6:2a00:1450:4864:20::332]) by sourceware.org (Postfix) with ESMTPS id 5C5BF3858C52; Fri, 9 Sep 2022 18:46:04 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 5C5BF3858C52 Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=googlemail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=googlemail.com Received: by mail-wm1-x332.google.com with SMTP id i203-20020a1c3bd4000000b003b3df9a5ecbso484694wma.1; Fri, 09 Sep 2022 11:46:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlemail.com; s=20210112; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:from:to:cc:subject:date; bh=4hQogmpdtglVLy4M52PNgWqZgocnHh2RWhFumuGyaxo=; b=IzO9Br9aOtNOTIgOklXL+Cz79MfkMn24dFhegn09Cu4yn62DSN/ASLOWA6LMFRwkEx JhzsY0DR5sS8fAcDeOivu0ldLdwc57F7AGIbDUowKC+K+sltlY0x61Xp/CQEeM3byFd3 qIpqe5M4+enTVjLiR0aJxPYOhA6kqaWy8bdFdiuH3WZkkh0zhRZ3SGyXZulo3ET03F0s tDnm4L4oU20udFXQdD7ZOkHpIwyPnKdLzlb+zxygIIsR0Snvh7jir+U/QusDXSuofVQO llRLh66i6S4f7UZKB4JIEVHs8DmLr4Zy4LPD32S6+zsnT7XkTa144+YIRdZO2vvh0zIh AraA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:x-gm-message-state:from:to:cc :subject:date; bh=4hQogmpdtglVLy4M52PNgWqZgocnHh2RWhFumuGyaxo=; b=oPYTA9FQ78I9S//gPjTYr8rv6+wFwwjEyrSfsA27wl1uDuBmBMFmnUpWC2MgkrMQ4h OoX0BaPSym/HoJBoa/XEMidfyC6S1FfRRrJbl5v3uMOyosfad0S8pFs6/gzwGTwQz2Zc hx6WLb2e4dx+Vn5MPMA2bNp+lTDXXMaqkBDr/MSwm6e0OxSXPd+YlZUQY6kp/izNFqSs QLlHNnkGSpXi9lzmHXMMUaAUiBPXnKH1f5bKLLGtuilkhHnwpQ4Wqh+o7DwAEwJzfHba d5Vumt5d0EEA9ockhdytat77n6vvTRvkOAxl48jQny0X6YvjC36uMpYMi0/Gk2tK4Mpy mckg== X-Gm-Message-State: ACgBeo3cdq/1yW11iK7KM26pvVAosUZN8b03Ju7S2d+ZcJjzVHmuFWTd FGvy6QAOCUEVmTJ/2AvTrWM= X-Google-Smtp-Source: AA6agR5/peYOlIthuvNxQ1O8gYwkaQn/eaCz649RTX0K875tpTCER+i7YScy2Jf9tNN7cxocjEqTBg== X-Received: by 2002:a05:600c:3d88:b0:3a6:a5:19eb with SMTP id bi8-20020a05600c3d8800b003a600a519ebmr6432703wmb.163.1662749163045; Fri, 09 Sep 2022 11:46:03 -0700 (PDT) Received: from [192.168.1.95] (host81-138-1-83.in-addr.btopenworld.com. [81.138.1.83]) by smtp.googlemail.com with ESMTPSA id bo23-20020a056000069700b0022a3517d3besm1341971wrb.5.2022.09.09.11.46.02 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Fri, 09 Sep 2022 11:46:02 -0700 (PDT) Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 13.4 \(3608.120.23.2.7\)) Subject: Re: Patch ping (was Re: [PATCH] libstdc++: Clear padding bits in atomic compare_exchange) From: Iain Sandoe In-Reply-To: Date: Fri, 9 Sep 2022 19:46:01 +0100 Cc: GCC Patches , Jakub Jelinek , libstdc++ , Thomas Rodgers Content-Transfer-Encoding: quoted-printable Message-Id: <8657FF75-BB98-4C92-9985-B953D0CA6061@googlemail.com> References: <20210923180837.633173-1-rodgert@appliantology.com> <20210927141031.651313-1-rodgert@appliantology.com> To: Rainer Orth , Jonathan Wakely X-Mailer: Apple Mail (2.3608.120.23.2.7) X-Spam-Status: No, score=-2.7 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: > On 9 Sep 2022, at 19:36, Rainer Orth = wrote: >=20 >> Here's a complete patch that combines the various incremental patches >> that have been going around. I'm testing this now. >>=20 >> Please take a look. >=20 > unfortunately, this patch broke macOS bootstrap (seen on > x86_64-apple-darwin11.4.2): >=20 > In file included from = /var/gcc/regression/master/10.7-gcc/build/x86_64-apple-darwin11.4.2/libstd= c++-v3/include/bits/shared_ptr_atomic.h:33, > from = /var/gcc/regression/master/10.7-gcc/build/x86_64-apple-darwin11.4.2/libstd= c++-v3/include/memory:78, > from = /vol/gcc/src/hg/master/darwin/libstdc++-v3/include/precompiled/stdc++.h:82= : > = /var/gcc/regression/master/10.7-gcc/build/x86_64-apple-darwin11.4.2/libstd= c++-v3/include/bits/atomic_base.h: In function 'bool = std::__atomic_impl::__compare_exchange(_Tp&, _Val<_Tp>&, _Val<_Tp>&, = bool, std::memory_order, std::memory_order)': > = /var/gcc/regression/master/10.7-gcc/build/x86_64-apple-darwin11.4.2/libstd= c++-v3/include/bits/atomic_base.h:1008:49: error: expected = primary-expression before ',' token > 1008 | __weak, int(__s), = int(__f))) > | ^ > = /var/gcc/regression/master/10.7-gcc/build/x86_64-apple-darwin11.4.2/libstd= c++-v3/include/bits/atomic_base.h:1017:50: error: expected = primary-expression before ',' token > 1017 | __weak, int(__s), = int(__f)); > | ^ >=20 > Darwin gcc predefines __weak=3D in gcc/config/darwin-c.cc = (darwin_cpp_builtins). yes, __weak and __strong are Objective C things (in principle, = applicable to non-Darwin targets using NeXT runtime - there is at least one such target). Iain