public inbox for libstdc++@gcc.gnu.org
 help / color / mirror / Atom feed
From: "Arsen Arsenović" <arsen@aarsen.me>
To: "Arsen Arsenović" <arsen@aarsen.me>
Cc: Jonathan Wakely <jwakely@redhat.com>,
	gcc-patches@gcc.gnu.org, libstdc++@gcc.gnu.org
Subject: Re: [PATCH 2/4] libstdc++: Add a test for <version> FTM redefinitions
Date: Wed, 05 Apr 2023 13:38:06 +0200	[thread overview]
Message-ID: <865yaaa789.fsf@aarsen.me> (raw)
In-Reply-To: <86v8iaa7ir.fsf@aarsen.me>

[-- Attachment #1: Type: text/plain, Size: 1239 bytes --]


Arsen Arsenović via Libstdc++ <libstdc++@gcc.gnu.org> writes:

> Good idea.  Both the positive and negative cases work when implemented
> like this:
>
> From 98d302bab9a87d3f2daecf9d54d62f33ba216673 Mon Sep 17 00:00:00 2001
> From: =?UTF-8?q?Arsen=20Arsenovi=C4=87?= <arsen@aarsen.me>
> Date: Wed, 8 Mar 2023 17:01:24 +0100
> Subject: [PATCH 2/4] libstdc++: Add a test for <version> FTM redefinitions
>
> This test detects redefinitions by compiling stdc++.h with
> -Wsystem-headers.  Thanks Patrick Palka for the suggestion.
>
> libstdc++-v3/ChangeLog:
>
> 	* testsuite/17_intro/versionconflict.cc: New test.

I've forgotten to reword this after changing the logic.  New message:

commit dcd7bed33cc274e8f3565ad02fb1fbc04bc845fb
Author: Arsen Arsenović <arsen@aarsen.me>
Date:   Wed Mar 8 17:01:24 2023 +0100

    libstdc++: Add a test for <version> FTM redefinitions
    
    This test detects redefinitions by compiling stdc++.h and <version>,
    by disabling the system_header pragma on the latter, to allow
    warnings in it.  Thanks Patrick Palka for the suggestion.
    
    libstdc++-v3/ChangeLog:
    
            * testsuite/17_intro/versionconflict.cc: New test.


-- 
Arsen Arsenović

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 381 bytes --]

  reply	other threads:[~2023-04-05 11:39 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-04-04 23:09 [PATCH 1/4] libstdc++: Harmonize <version> and other headers Arsen Arsenović
2023-04-04 23:09 ` [PATCH 2/4] libstdc++: Add a test for <version> FTM redefinitions Arsen Arsenović
2023-04-05 10:59   ` Jonathan Wakely
2023-04-05 11:31     ` Arsen Arsenović
2023-04-05 11:38       ` Arsen Arsenović [this message]
2023-04-05 12:07         ` Jonathan Wakely
2023-04-04 23:09 ` [PATCH 3/4] libstdc++: Downgrade DEBUG to ASSERTIONS when !HOSTED Arsen Arsenović
2023-04-05 11:00   ` Jonathan Wakely
2023-04-04 23:09 ` [PATCH 4/4] libstdc++: Fix some freestanding test failures Arsen Arsenović
2023-04-05 11:08   ` Jonathan Wakely
2023-04-05 11:28     ` Arsen Arsenović
2023-04-05 10:52 ` [PATCH 1/4] libstdc++: Harmonize <version> and other headers Jonathan Wakely
2023-04-05 11:33   ` Arsen Arsenović
2023-04-05 12:09     ` Jonathan Wakely
2023-04-05 12:10       ` Jonathan Wakely

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=865yaaa789.fsf@aarsen.me \
    --to=arsen@aarsen.me \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=jwakely@redhat.com \
    --cc=libstdc++@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).