From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id 170E23858D39 for ; Tue, 19 Sep 2023 16:58:59 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 170E23858D39 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1695142738; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Le1aK+gCDAssr8oTudvwtmbKfMtoeCzdZTwj7N1TVYk=; b=SWApcmxM7EaIwAVWvbtw9kWsea6nhwyuZqOg36junoMT9YP9IyHscx4XfQQyv6v2OpP1al cNbVvjJyLD4kgcQZuXqgrvmHozMAIDjLU74g5POf8QPRDrfZI8KDg/WnHWIPdWHCz6N/KK XZQOta5B3dfm62i044PFBoJQ2yXrkRg= Received: from mail-vs1-f69.google.com (mail-vs1-f69.google.com [209.85.217.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-673-lHvhAgeIMkOiG7rjCwY0hQ-1; Tue, 19 Sep 2023 12:58:57 -0400 X-MC-Unique: lHvhAgeIMkOiG7rjCwY0hQ-1 Received: by mail-vs1-f69.google.com with SMTP id ada2fe7eead31-45262bd2d5fso982014137.1 for ; Tue, 19 Sep 2023 09:58:57 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1695142737; x=1695747537; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=Le1aK+gCDAssr8oTudvwtmbKfMtoeCzdZTwj7N1TVYk=; b=O+8RSzfToRsCPBNRQ3I0aSWDbFSzJYMcvjWKZxB3XZtVlkMK9XaugVkatmiPHdbDzX QiIuyvS4Ueib37TA48PAOyjxflWD0ZydCiAZ7x5Nnumvq/IHyrjoaZTTp+qI+fTpNAPJ sbhvcEvKMJQImQOsMCf+i0M+C+UzEjNkVCWbYriXd5IjMElvFT7VNtVU1AFtJPccIKbO Y63g2gujHV+GkPx/DHqsG/d0Jc8utmhvCS8Mz8REnlESV2/2n9OXcC9NNo/5ELAMXDU3 TeHTFE2HiAqzxrzAd6h0bgTRvCFFnY/uEJSTN6sim8bItOjQ3n4IhaO7ErWaSFCV4jlW JHdQ== X-Gm-Message-State: AOJu0Yy7UNKVy7Z6v1ZylKAd7kN/8YhJYib+Gr+glzU5KEp8pj/mi4vi ZS788FWyeH+Yf24ORrDXR7D0ahqXMZGhO0cosPwpiSgRK7HSGxtBQ4rg55MHU0Od14k5Sg5w39q 9m0HljiRKZ9ZwlXg= X-Received: by 2002:a05:6102:34d5:b0:44d:3d29:4940 with SMTP id a21-20020a05610234d500b0044d3d294940mr264550vst.35.1695142736838; Tue, 19 Sep 2023 09:58:56 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHEKG+XsU7okKo9vFKi1jeiaVN2hQ86Vj5bP7+7WkdxfgHADi1IJK3eyAc4mBR+OLjvFNZoOw== X-Received: by 2002:a05:6102:34d5:b0:44d:3d29:4940 with SMTP id a21-20020a05610234d500b0044d3d294940mr264539vst.35.1695142736527; Tue, 19 Sep 2023 09:58:56 -0700 (PDT) Received: from [192.168.1.108] (130-44-146-16.s12558.c3-0.arl-cbr1.sbo-arl.ma.cable.rcncustomer.com. [130.44.146.16]) by smtp.gmail.com with ESMTPSA id j11-20020a0ce00b000000b006563dd4097dsm3306705qvk.15.2023.09.19.09.58.55 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 19 Sep 2023 09:58:55 -0700 (PDT) Message-ID: <86d37ba9-e651-93a9-eb55-18a2221a4c44@redhat.com> Date: Tue, 19 Sep 2023 12:58:54 -0400 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.15.1 Subject: Re: [PATCH v14 16/40] c, c++: Use 16 bits for all use of enum rid for more keyword space To: Ken Matsui , gcc-patches@gcc.gnu.org Cc: libstdc++@gcc.gnu.org, Patrick Palka , "Joseph S. Myers" References: <20230915023640.75216-17-kmatsui@gcc.gnu.org> <20230915235353.19378-1-kmatsui@gcc.gnu.org> <20230915235353.19378-17-kmatsui@gcc.gnu.org> From: Jason Merrill In-Reply-To: <20230915235353.19378-17-kmatsui@gcc.gnu.org> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-7.2 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H4,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 9/15/23 19:51, Ken Matsui via Gcc-patches wrote: > Now that RID_MAX has reached 255, we need to update the bit sizes of every > use of the enum rid from 8 to 16 to support more keywords. Sorry to bring this up so late, but this does raise the question of whether we actually want to use keyword space for all these traits that will probably be used approximately once in a C++ translation unit. I wonder if it would make sense to instead use e.g. RID_TRAIT for all of them and use gperf to look up the specific trait from the identifier? Jason