From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <SRS0=dyjG=4N=aarsen.me=arsen@sourceware.org>
Received: from mout-p-101.mailbox.org (mout-p-101.mailbox.org [IPv6:2001:67c:2050:0:465::101])
	by sourceware.org (Postfix) with ESMTPS id F0A3B38475B4;
	Thu, 15 Dec 2022 17:44:08 +0000 (GMT)
DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org F0A3B38475B4
Authentication-Results: sourceware.org; dmarc=pass (p=reject dis=none) header.from=aarsen.me
Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=aarsen.me
Received: from smtp1.mailbox.org (smtp1.mailbox.org [IPv6:2001:67c:2050:b231:465::1])
	(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
	 key-exchange ECDHE (P-384) server-signature RSA-PSS (4096 bits) server-digest SHA256)
	(No client certificate requested)
	by mout-p-101.mailbox.org (Postfix) with ESMTPS id 4NY0374vGdz9sSb;
	Thu, 15 Dec 2022 18:44:03 +0100 (CET)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=aarsen.me; s=MBO0001;
	t=1671126243;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 in-reply-to:in-reply-to:references:references;
	bh=BEi2vUfH/wxG7o94bip5d4fYWcptRof7O9eANYfHmo4=;
	b=arBDil+Go+ATW0L1WO2oTm2hC+YMvJ8DI19UrzExaY8A5jhthT+h4/PUQQcG8fkUEWDd7X
	9VW7B5e2NlVe6LBb+cAIEDyDglFKiyerwD4DVe32Zb0xjv+I7yUwem7WFVVRuv30+hmk88
	g5IYX9CuRuN7gu9+VXcr606l07x94pmBT2odfcdaPL5cYp3RrzAI3PZvMAW7Tk914UOTG8
	NedN06AsDDUjIjNQwva2uLGMjhQbYFb24z1yhKOAW466VAXuVTh2kexfxsq5akjM4XFpXX
	UjyAcpBIj9rbXALf/2dXyh1kJlhOscoYYRBQTpf7IK61BKQLv8WebTV3YBP8gQ==
References: <20221210094303.2180127-1-arsen@aarsen.me>
 <20221210094303.2180127-3-arsen@aarsen.me>
 <7b129144-65a9-7f1a-c093-f85722979d38@redhat.com>
From: Arsen =?utf-8?Q?Arsenovi=C4=87?= <arsen@aarsen.me>
To: Jason Merrill <jason@redhat.com>
Cc: gcc-patches@gcc.gnu.org, jwakely@redhat.com, libstdc++@gcc.gnu.org
Subject: Re: [PATCH 2/4] libstdc++: Improve output of default contract
 violation handler [PR107792]
Date: Thu, 15 Dec 2022 18:43:18 +0100
In-reply-to: <7b129144-65a9-7f1a-c093-f85722979d38@redhat.com>
Message-ID: <86ilictvdt.fsf@aarsen.me>
MIME-Version: 1.0
Content-Type: multipart/signed; boundary="=-=-=";
	micalg=pgp-sha512; protocol="application/pgp-signature"
X-Rspamd-Queue-Id: 4NY0374vGdz9sSb
X-Spam-Status: No, score=-5.2 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,KAM_INFOUSMEBIZ,RCVD_IN_DNSWL_LOW,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org
List-Id: <libstdc++.gcc.gnu.org>

--=-=-=
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable

Hi,

Jason Merrill <jason@redhat.com> writes:

>
> I'd actually suggest "off" and "on" since it's really a boolean since
> "always_continue" was dropped.
>
>> +  std::cerr << "contract violation in function " << violation.function_=
name()
>> +    << " at " << violation.file_name() << ':' << violation.line_number()
>> +    << ": " << violation.comment()
>> +    << "\n[level:" << violation.assertion_level()
>
> Maybe omit level/role if "default"?

ACK on both, sounds good.

Have a great day.
=2D-=20
Arsen Arsenovi=C4=87

--=-=-=
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iOYEARYKAI4WIQT+4rPRE/wAoxYtYGFSwpQwHqLEkwUCY5tc3l8UgAAAAAAuAChp
c3N1ZXItZnByQG5vdGF0aW9ucy5vcGVucGdwLmZpZnRoaG9yc2VtYW4ubmV0RkVF
MkIzRDExM0ZDMDBBMzE2MkQ2MDYxNTJDMjk0MzAxRUEyQzQ5MxAcYXJzZW5AYWFy
c2VuLm1lAAoJEFLClDAeosSTbK0BAMrtrNDQ2KZbhGmMtu2ROT9EIrT/7zMe70q/
Iq5lM5clAP0dD3GtAJltqHbTjcq6GRExnKnjigsgDl5mrQhJAXYQDg==
=A046
-----END PGP SIGNATURE-----
--=-=-=--