From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mout-p-202.mailbox.org (mout-p-202.mailbox.org [IPv6:2001:67c:2050:0:465::202]) by sourceware.org (Postfix) with ESMTPS id 5ACAB3858C52; Mon, 14 Nov 2022 13:20:41 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 5ACAB3858C52 Authentication-Results: sourceware.org; dmarc=pass (p=reject dis=none) header.from=aarsen.me Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=aarsen.me Received: from smtp102.mailbox.org (smtp102.mailbox.org [10.196.197.102]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-384) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mout-p-202.mailbox.org (Postfix) with ESMTPS id 4N9qgT3VD2z9sS2; Mon, 14 Nov 2022 14:20:37 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=aarsen.me; s=MBO0001; t=1668432037; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=UyY7r/Z4zJbIqYTLJxaWbXhD2luD/eWmDQy6kf9e5SE=; b=PjnFPrtXxpV/90JFIHRujrWd3m2Qv5S//uRXokdG7P+sQiwaSIzHo+vjd5xzAcYAFTkgB1 g00Tk13tkZTCBgVyNvJPP2CLLK3/YNhKWm4jN1zN6uC8XIJf8KLWK5hN75aq20NinD3zWJ H0qDT1BLtqxHJGTuj4MUz9CYcic7d955PLrFurHVLqzxGXm3awzz9kPlC3Sa5eiDFQjUvc F0XD9HbjHiST4y+gWNU7tqFRMFpIlD9UPQkpH1xmMCvXB09eE4LT5854VZqS49Z6XGEF9C ftUSKLfLDAlkDbzEPClRKqZZesmLgGNs6h+sBNo3soUhyQ24RglcgvA6lGK0Bw== References: <20221113180527.2907744-1-arsen@aarsen.me> From: Arsen =?utf-8?Q?Arsenovi=C4=87?= To: Jonathan Wakely Cc: libstdc++@gcc.gnu.org, gcc-patches@gcc.gnu.org Subject: Re: [PATCH] libstdc++: Fix python/ not making install directories Date: Mon, 14 Nov 2022 14:15:03 +0100 In-reply-to: Message-ID: <86wn7xvfj1.fsf@aarsen.me> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-Spam-Status: No, score=-4.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,KAM_INFOUSMEBIZ,RCVD_IN_DNSWL_LOW,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Hi, Jonathan Wakely writes: >> This looks simple, and more consistent with what we already do. Does >> it solve your issue? It does work; though, if I was more daring I'd have said that it's fine without checking, too, since it does the same operation on the same directory ;) Was the omission of the mkdir $(DESTDIR)$(toolexeclibdir) intentional? I only see TELD/debug in your revision of the patch. Chances are, it gets created elsewhere (my test was just install-target-libstdc++-v3, so not even the full install), but it might be worth being conservative about it. Thanks, =2D-=20 Arsen Arsenovi=C4=87 --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iOYEARYKAI4WIQT+4rPRE/wAoxYtYGFSwpQwHqLEkwUCY3JAo18UgAAAAAAuAChp c3N1ZXItZnByQG5vdGF0aW9ucy5vcGVucGdwLmZpZnRoaG9yc2VtYW4ubmV0RkVF MkIzRDExM0ZDMDBBMzE2MkQ2MDYxNTJDMjk0MzAxRUEyQzQ5MxAcYXJzZW5AYWFy c2VuLm1lAAoJEFLClDAeosSTlAEA/14iwim5/yLGeWnEQWVBX9/P0WmyKPJwkexA h99yU9nrAP98KDkvPFdfhmp8TXbrQgEgVyhcINkSP/s1dx6KyLgcDA== =t5d6 -----END PGP SIGNATURE----- --=-=-=--