From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-io1-xd29.google.com (mail-io1-xd29.google.com [IPv6:2607:f8b0:4864:20::d29]) by sourceware.org (Postfix) with ESMTPS id 42E303856DD6 for ; Wed, 27 Sep 2023 15:37:34 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 42E303856DD6 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=adacore.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=adacore.com Received: by mail-io1-xd29.google.com with SMTP id ca18e2360f4ac-76c64da0e46so406032139f.0 for ; Wed, 27 Sep 2023 08:37:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=adacore.com; s=google; t=1695829053; x=1696433853; darn=gcc.gnu.org; h=mime-version:user-agent:message-id:in-reply-to:date:references :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=vn0HExQQUdjEAFIpA1o8bbLF7TALSp1zrlBnE0Df6MU=; b=ZOkC5jKzIh543sX9IectiwGtd97kt9SrelpBtnMOBKPiBgnds11kpMhzzVAMUq9fnl YN1h803swPrHb6WL+RxmP9h0uu5FbNZugqF3VWFWbKvXX1Uo3uJFx3gEn2o+4GCPm2mW OyidJ7M3+0EOhvw1IgC7/mogZBFJuG+gdGeNwhiwws4otPSzGU4GwXyveBahBUAnwRql hYcJJ6AZFFfESO4jT82WrooYPZyD1rty79WYNquSD+c73YXpSHnwQ8+wpQ4XLiJS++Lf oAyhsEtixs6dhb1YjU8odE0JEFVJNvj1c1kl2/Z0Nxx4AOjIap11gqEFzK40BJ7BWTw0 GaPw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1695829053; x=1696433853; h=mime-version:user-agent:message-id:in-reply-to:date:references :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=vn0HExQQUdjEAFIpA1o8bbLF7TALSp1zrlBnE0Df6MU=; b=lsiGJyceb/Kb9uDKBNNhaRSGmmMzBw2W92pMFnLxVerKXQunsNLAGnqATFhYp686+F W55fReI8yBnlFt7mp+3joaORis8ssGCK8zB/GWu124WKzq+ePVn7uYsWLU6+9SC6pQE4 5MCad8RAvmQSI/mMckxdZDhPoPAVHCIz/Wj0RU7qwAFkHxxwVY74ZXYKZj4tDzKkTfT5 l6xxAYSS6z0VKUcR1YiFXzvYtN6vwuSb0IEd1+Uz4E205UJcC5mrpRZGFFsZwvuKAIU1 AGhmwFr2l4nJMedjqIbe1kCXAx4lsdmS9RkFc0TtVmkvOadbOFT/tamttsE/1Yy4hLL/ LL0g== X-Gm-Message-State: AOJu0YwJhx3dcbkpCsxurM4/pIyZZtxhZhiDWV4XCOspefokiAmeiCW8 MUDka9HIrIZl2jQEjFvip9VvoI5/PJblqpqRfAupYQ== X-Google-Smtp-Source: AGHT+IG7jdlis4h0ZA+0i2YrZgDXgQ1t6RB2rYPZQFUA0lPSkWu8e02cB42g/ipclsJXFEdCr1c48w== X-Received: by 2002:a6b:590c:0:b0:792:9a1a:228b with SMTP id n12-20020a6b590c000000b007929a1a228bmr2415434iob.2.1695829053375; Wed, 27 Sep 2023 08:37:33 -0700 (PDT) Received: from murgatroyd (71-211-130-31.hlrn.qwest.net. [71.211.130.31]) by smtp.gmail.com with ESMTPSA id r16-20020a6b4410000000b0078702f4894asm4066630ioa.9.2023.09.27.08.37.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 27 Sep 2023 08:37:32 -0700 (PDT) From: Tom Tromey To: Jonathan Wakely via Gcc-patches Cc: libstdc++@gcc.gnu.org, Jonathan Wakely Subject: Re: [committed] libstdc++: Add GDB printers for types References: <20221222233804.772229-1-jwakely@redhat.com> X-Attribution: Tom Date: Wed, 27 Sep 2023 09:37:31 -0600 In-Reply-To: <20221222233804.772229-1-jwakely@redhat.com> (Jonathan Wakely via Gcc-patches's message of "Thu, 22 Dec 2022 23:38:04 +0000") Message-ID: <878r8r4og4.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Status: No, score=-5.5 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: >>>>> Jonathan Wakely via Gcc-patches writes: Replying to a quite old email... I ran a Python linter on the libstdc++ pretty-printers. I have fixes for most of the issues that are worth fixing (I didn't bother with line lengths -- FWIW in gdb we just run 'black' and don't worry about these details), but the patch I'm replying to had a problem that I didn't know how to fix: > +class StdChronoTimeZoneRulePrinter: [...] > + if kind == 0: # DayOfMonth > + start = '{} {}{}'.format(month, ordinal_day) flake8 points out that this call to format has three placeholders but only two arguments. Tom