From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ed1-x52e.google.com (mail-ed1-x52e.google.com [IPv6:2a00:1450:4864:20::52e]) by sourceware.org (Postfix) with ESMTPS id C731A3858C2C; Mon, 21 Feb 2022 17:59:16 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org C731A3858C2C Received: by mail-ed1-x52e.google.com with SMTP id m3so25041283eda.10; Mon, 21 Feb 2022 09:59:16 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:from:to:cc:references:in-reply-to :content-transfer-encoding; bh=Ki3mMP/D4fUn3wmtAeUWDDkcyHn8s4iLPI4gJ96mcFk=; b=54iPYsD+L5t6dDhw10IEbsvyfDmGrdCabV9p9BHeZujiTigjsvUUVa/LGW/e5hylFS Is9wnzmS3lV3cITyQjJYWYnjK7UFYN2/u5sF0DhvVSjierElUYPrlCSkIeaqSaR+/VAm 5R4J+uLJW6TJbZuIJIluQ8iROZEYpuuIZT2iWW+3RWhQW94mPpxgDTiEKHVkBquw+5QA 5PRxUkrAOtIgMX8BlMNX1vIBsb2Z1CtaMGlHrLbQq2ZJuQ/tNlFULgwq+eviG7XibQLY rN+15m73gRz+VhMg+Z/aiaetRCAs/CTNnuEtl1ia5m8bsB3fA6fsLKWgBi2yEWkQ4q1E zGNw== X-Gm-Message-State: AOAM531H1Y7cmjlpbyyP0diNIkWBsHYQjO6wqnajMaIl4cQGXlbOBXeZ F79iLukFtG8sy8WnvRDzxo5vctiI8cw= X-Google-Smtp-Source: ABdhPJxKGQ8p27TPhtgbnj9j1jDbEN/V6WtV/ERVItFSWmUIKdHHk6PO/0INAkoVFe2hS+7fcOJuRQ== X-Received: by 2002:a05:6402:528f:b0:410:e24f:91fd with SMTP id en15-20020a056402528f00b00410e24f91fdmr23093445edb.99.1645466355631; Mon, 21 Feb 2022 09:59:15 -0800 (PST) Received: from [10.31.7.101] ([109.190.253.11]) by smtp.googlemail.com with ESMTPSA id oz23sm5431829ejb.174.2022.02.21.09.59.13 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 21 Feb 2022 09:59:15 -0800 (PST) Message-ID: <87a6c4e2-9ba6-0c04-274a-5f204efe5d17@gmail.com> Date: Mon, 21 Feb 2022 18:59:11 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.5.0 Subject: Re: [PATCH][_Hashtable] Fix insertion of range of type convertible to value_type PR 56112 Content-Language: en-US From: =?UTF-8?Q?Fran=c3=a7ois_Dumont?= To: "libstdc++@gcc.gnu.org" Cc: gcc-patches References: <2fe3937d-1b9a-a547-bb41-225d3d5426a2@gmail.com> In-Reply-To: <2fe3937d-1b9a-a547-bb41-225d3d5426a2@gmail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=2.1 required=5.0 tests=BAYES_00, BODY_8BITS, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, KAM_NUMSUBJECT, NICE_REPLY_A, RCVD_IN_BARRACUDACENTRAL, RCVD_IN_DNSWL_NONE, RCVD_IN_SBL_CSS, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.4 X-Spam-Level: ** X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: libstdc++@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libstdc++ mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 21 Feb 2022 17:59:18 -0000 Gentle reminder, it is important to have this for gcc 12. On 15/02/22 10:05, François Dumont wrote: > We have a regression regarding management of types convertible to > value_type. It is an occurrence of PR 56112 but for the insert method. > >     libstdc++: [_Hashtable] Insert range of types convertible to > value_type PR 56112 > >     Fix insertion of range of types convertible to value_type. > >     libstdc++-v3/ChangeLog: > >             PR libstdc++/56112 >             * include/bits/hashtable.h >             (_Hashtable<>::_M_insert_unique_aux): New. >             (_Hashtable<>::_S_to_value): New. >             (_Hashtable<>::_M_insert(_Arg&&, const _NodeGenerator&, > true_type)): Use latters. >             * testsuite/23_containers/unordered_map/cons/56112.cc: Use > dg-do compile. >             * testsuite/23_containers/unordered_set/cons/56112.cc: New > test. > > Tested under Linux x86_64. > > Ok to commit ? > > François