From: Florian Weimer <fweimer@redhat.com>
To: Patrick Palka via Libstdc++ <libstdc++@gcc.gnu.org>
Cc: gcc-patches@gcc.gnu.org, Patrick Palka <ppalka@redhat.com>
Subject: Re: [PATCH 1/5] libstdc++: Import the fast_float library
Date: Tue, 16 Nov 2021 08:59:43 +0100 [thread overview]
Message-ID: <87ee7gedjk.fsf@oldenburg.str.redhat.com> (raw)
In-Reply-To: <20211116002505.2324582-1-ppalka@redhat.com> (Patrick Palka via Libstdc's message of "Mon, 15 Nov 2021 19:25:01 -0500")
* Patrick Palka via Libstdc:
> This copies the fast_float library[1] into the compiled-in library
> sources. We're going to use this library in our floating-point
> std::from_chars implementation for faster and more portable parsing of
> binary32/64 decimal strings.
>
> [1]: https://github.com/fastfloat/fast_float
>
> Series tested on x86_64, i686, ppc64, ppc64le and aarch64, does it
> look OK for trunk?
Missing Signed-off-by:?
> diff --git a/libstdc++-v3/src/c++17/fast_float/LICENSE-APACHE b/libstdc++-v3/src/c++17/fast_float/LICENSE-APACHE
> new file mode 100644
> index 00000000000..26f4398f249
> --- /dev/null
> +++ b/libstdc++-v3/src/c++17/fast_float/LICENSE-APACHE
> @@ -0,0 +1,190 @@
> + Apache License
> + Version 2.0, January 2004
> + http://www.apache.org/licenses/
> diff --git a/libstdc++-v3/src/c++17/fast_float/LICENSE-MIT b/libstdc++-v3/src/c++17/fast_float/LICENSE-MIT
> new file mode 100644
> index 00000000000..2fb2a37ad7f
> --- /dev/null
> +++ b/libstdc++-v3/src/c++17/fast_float/LICENSE-MIT
> @@ -0,0 +1,27 @@
> +MIT License
> +
> +Copyright (c) 2021 The fast_float authors
You also need to include the README file, which makes it clear that
recipients can choose between Apache and MIT. GCC needs to use the MIT
option, I think.
Thanks,
Florian
next prev parent reply other threads:[~2021-11-16 7:59 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-16 0:25 Patrick Palka
2021-11-16 0:25 ` [PATCH 2/5] libstdc++: Apply modifications to our local copy of fast_float Patrick Palka
2021-11-19 21:47 ` Patrick Palka
2021-11-16 0:25 ` [PATCH 3/5] libstdc++: Adjust fast_float's over/underflow behavior for conformnace Patrick Palka
2021-11-19 21:49 ` Patrick Palka
2021-11-16 0:25 ` [PATCH 4/5] libstdc++: Use fast_float in std::from_chars for binary32/64 Patrick Palka
2021-11-16 0:25 ` [PATCH 5/5] libstdc++: Import MSVC floating-point std::from_chars testcases Patrick Palka
2021-11-16 7:59 ` Florian Weimer [this message]
2021-11-16 9:32 ` [PATCH 1/5] libstdc++: Import the fast_float library Jonathan Wakely
2021-11-16 9:46 ` Florian Weimer
2021-11-16 11:34 ` Jonathan Wakely
2021-11-16 15:30 ` Patrick Palka
2021-11-16 16:18 ` Daniel Krügler
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87ee7gedjk.fsf@oldenburg.str.redhat.com \
--to=fweimer@redhat.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=libstdc++@gcc.gnu.org \
--cc=ppalka@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).