From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id 7A56E3858003 for ; Tue, 16 Nov 2021 07:59:56 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 7A56E3858003 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-243-31QlZYYQMyOi9mtbXXUMYA-1; Tue, 16 Nov 2021 02:59:48 -0500 X-MC-Unique: 31QlZYYQMyOi9mtbXXUMYA-1 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id A7AFA1006AAF; Tue, 16 Nov 2021 07:59:47 +0000 (UTC) Received: from oldenburg.str.redhat.com (unknown [10.39.194.81]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 39CAB5DF56; Tue, 16 Nov 2021 07:59:45 +0000 (UTC) From: Florian Weimer To: Patrick Palka via Libstdc++ Cc: gcc-patches@gcc.gnu.org, Patrick Palka Subject: Re: [PATCH 1/5] libstdc++: Import the fast_float library References: <20211116002505.2324582-1-ppalka@redhat.com> Date: Tue, 16 Nov 2021 08:59:43 +0100 In-Reply-To: <20211116002505.2324582-1-ppalka@redhat.com> (Patrick Palka via Libstdc's message of "Mon, 15 Nov 2021 19:25:01 -0500") Message-ID: <87ee7gedjk.fsf@oldenburg.str.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain X-Spam-Status: No, score=-12.6 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H4, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_NONE, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: libstdc++@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libstdc++ mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 16 Nov 2021 07:59:58 -0000 * Patrick Palka via Libstdc: > This copies the fast_float library[1] into the compiled-in library > sources. We're going to use this library in our floating-point > std::from_chars implementation for faster and more portable parsing of > binary32/64 decimal strings. > > [1]: https://github.com/fastfloat/fast_float > > Series tested on x86_64, i686, ppc64, ppc64le and aarch64, does it > look OK for trunk? Missing Signed-off-by:? > diff --git a/libstdc++-v3/src/c++17/fast_float/LICENSE-APACHE b/libstdc++-v3/src/c++17/fast_float/LICENSE-APACHE > new file mode 100644 > index 00000000000..26f4398f249 > --- /dev/null > +++ b/libstdc++-v3/src/c++17/fast_float/LICENSE-APACHE > @@ -0,0 +1,190 @@ > + Apache License > + Version 2.0, January 2004 > + http://www.apache.org/licenses/ > diff --git a/libstdc++-v3/src/c++17/fast_float/LICENSE-MIT b/libstdc++-v3/src/c++17/fast_float/LICENSE-MIT > new file mode 100644 > index 00000000000..2fb2a37ad7f > --- /dev/null > +++ b/libstdc++-v3/src/c++17/fast_float/LICENSE-MIT > @@ -0,0 +1,27 @@ > +MIT License > + > +Copyright (c) 2021 The fast_float authors You also need to include the README file, which makes it clear that recipients can choose between Apache and MIT. GCC needs to use the MIT option, I think. Thanks, Florian