From: Keith Packard <keithp@keithp.com>
To: Vladimir V <vv.os.swe@gmail.com>, Jonathan Wakely <jwakely@redhat.com>
Cc: libstdc++@gcc.gnu.org
Subject: Re: Problem building libstdc++ for the avr target
Date: Sun, 07 Feb 2021 10:23:04 -0800 [thread overview]
Message-ID: <87eehrbuuv.fsf@keithp.com> (raw)
In-Reply-To: <CA+=iAirEbHa95-QTJtqBFA4m8ZsmYYMHpHhwtox7Hp3Avv7fAg@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 1377 bytes --]
Vladimir V <vv.os.swe@gmail.com> writes:
> Hello,
>
> I finally managed to test building for AVR with Keith's patch and
> unistd.h removed (to enforce usage of stabs in filesystem).
>
> I identified a couple of minor build issues that are obvious from the
> attached patch, Could you please have a look? They work with AVR target
> and doesn't seem to cause regressions for x64 build.
Hrm. Removing unistd.h from an installed file might affect applications
using that file, so that doesn't seem ideal.
Picolibc has a unistd.h to define the relevant interfaces, even though
it doesn't require them. Perhaps avrlibc could do the same? Or even an
empty file that would satisfy this requirement?
> --- a/libstdc++-v3/src/c++17/fs_ops.cc
> +++ b/libstdc++-v3/src/c++17/fs_ops.cc
> @@ -1130,7 +1130,7 @@ fs::permissions(const path& p, perms prms, perm_options opts,
> #else
> if (nofollow && is_symlink(st))
> ec = std::make_error_code(std::errc::not_supported);
> - else if (posix::chmod(p.c_str(), static_cast<mode_t>(prms)))
> + else if (posix::chmod(p.c_str(), static_cast<posix::mode_t>(prms)))
> err = errno;
> #endif
I'm afraid I don't understand what this piece does without studying the
underlying code a bunch. But, if it's just namespace stuff in an
internal implementation file, that seems fine to me.
--
-keith
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 832 bytes --]
next prev parent reply other threads:[~2021-02-07 18:23 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-07 17:32 Vladimir V
2020-12-07 20:30 ` Jonathan Wakely
2020-12-07 20:32 ` Jonathan Wakely
2020-12-09 0:28 ` Vladimir V
2020-12-09 12:32 ` Vladimir V
2020-12-09 12:49 ` Jonathan Wakely
2020-12-09 17:01 ` Jonathan Wakely
2020-12-09 23:00 ` Vladimir V
2020-12-10 17:39 ` Vladimir V
2020-12-10 20:15 ` Jonathan Wakely
2020-12-10 20:31 ` Vladimir V
2020-12-15 11:48 ` Jonathan Wakely
2020-12-16 7:33 ` Vladimir V
2020-12-07 20:41 ` Keith Packard
2020-12-07 21:06 ` Jonathan Wakely
2021-01-04 11:28 ` Vladimir V
2021-01-08 18:21 ` Jonathan Wakely
2021-01-22 14:46 ` Vladimir V
2021-02-07 13:55 ` Vladimir V
2021-02-07 18:22 ` Vladimir V
2021-02-07 18:23 ` Keith Packard [this message]
2021-02-07 22:33 ` Vladimir V
2021-02-07 23:06 ` Keith Packard
2021-02-08 12:58 ` Vladimir V
2021-02-08 17:38 ` Jonathan Wakely
2021-02-08 17:45 ` Jonathan Wakely
2021-02-08 17:47 ` Jonathan Wakely
2021-02-08 22:25 ` Vladimir V
2021-02-09 10:47 ` Jonathan Wakely
2021-02-09 10:54 ` Vladimir V
2021-03-25 9:27 ` Vladimir V
2021-03-25 12:36 ` Jonathan Wakely
2021-03-25 18:27 ` Jonathan Wakely
2021-03-25 21:37 ` Vladimir V
2021-03-25 23:02 ` Jonathan Wakely
2021-03-26 8:25 ` Vladimir V
2020-12-07 21:51 ` Vladimir V
2020-12-07 23:00 ` Keith Packard
2020-12-08 8:12 ` Vladimir V
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87eehrbuuv.fsf@keithp.com \
--to=keithp@keithp.com \
--cc=jwakely@redhat.com \
--cc=libstdc++@gcc.gnu.org \
--cc=vv.os.swe@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).