From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from elaine.keithp.com (home.keithp.com [63.227.221.253]) by sourceware.org (Postfix) with ESMTPS id BB49C384A023 for ; Sun, 7 Feb 2021 18:23:07 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org BB49C384A023 Received: from localhost (localhost [127.0.0.1]) by elaine.keithp.com (Postfix) with ESMTP id EB6243F2DCEC; Sun, 7 Feb 2021 10:23:05 -0800 (PST) X-Virus-Scanned: Debian amavisd-new at keithp.com Received: from elaine.keithp.com ([127.0.0.1]) by localhost (elaine.keithp.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id 4Zwui8jDv1w5; Sun, 7 Feb 2021 10:23:05 -0800 (PST) Received: from keithp.com (koto.keithp.com [10.0.0.2]) by elaine.keithp.com (Postfix) with ESMTPSA id 646A43F2DCDA; Sun, 7 Feb 2021 10:23:05 -0800 (PST) Received: by keithp.com (Postfix, from userid 1000) id EE99B158216E; Sun, 7 Feb 2021 10:23:04 -0800 (PST) From: Keith Packard To: Vladimir V , Jonathan Wakely Cc: libstdc++@gcc.gnu.org Subject: Re: Problem building libstdc++ for the avr target In-Reply-To: References: <20201207203033.GI2309743@redhat.com> <87sg8h8i2e.fsf@keithp.com> <20201207210659.GK2309743@redhat.com> <20210108182111.GE9471@redhat.com> Date: Sun, 07 Feb 2021 10:23:04 -0800 Message-ID: <87eehrbuuv.fsf@keithp.com> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha256; protocol="application/pgp-signature" X-Spam-Status: No, score=-4.8 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: libstdc++@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libstdc++ mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 07 Feb 2021 18:23:09 -0000 --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable Vladimir V writes: > Hello, > > I finally managed to test building for AVR with Keith's patch and > unistd.h removed (to enforce usage of stabs in filesystem). > > I identified a couple of minor build issues that are obvious from the > attached patch, Could you please have a look? They work with AVR target > and doesn't seem to cause regressions for x64 build. Hrm. Removing unistd.h from an installed file might affect applications using that file, so that doesn't seem ideal. Picolibc has a unistd.h to define the relevant interfaces, even though it doesn't require them. Perhaps avrlibc could do the same? Or even an empty file that would satisfy this requirement? > --- a/libstdc++-v3/src/c++17/fs_ops.cc > +++ b/libstdc++-v3/src/c++17/fs_ops.cc > @@ -1130,7 +1130,7 @@ fs::permissions(const path& p, perms prms, perm_opt= ions opts, > #else > if (nofollow && is_symlink(st)) > ec =3D std::make_error_code(std::errc::not_supported); > - else if (posix::chmod(p.c_str(), static_cast(prms))) > + else if (posix::chmod(p.c_str(), static_cast(prms))) > err =3D errno; > #endif I'm afraid I don't understand what this piece does without studying the underlying code a bunch. But, if it's just namespace stuff in an internal implementation file, that seems fine to me. =2D-=20 =2Dkeith --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEEw4O3eCVWE9/bQJ2R2yIaaQAAABEFAmAgMAgACgkQ2yIaaQAA ABE7LA/+KdlQO9eHrwx+KMz+skccqharLAG5d4Baf1oB1NCIvaAqddYGUZ3VY6Ys Cl96FT5qayWX3otzpjQEePYZNZ9WiKCcMZi3MFgDX9iHRdSLvQttffB3KBS2OhkK 1D7J2MPuya/hI3inFXT5RC4BdUx8xmtZlwSgTv98COfGcT72O2Hjgsblg76BHl62 L9tw4EIxepgqoRqE9fvaOLAiAI8tBq26PlSfuM8ZdFO2m7igiHbfjAuUpIw2hhdM 0pXOgkAKFsAnc6FP6aRd6BgtVH+IVJs+yerdQZ79Qhw7APHiaMn+sslmSCQTd7NL lbOuOnexJ3dl43NXDWAGuOmJQ8Kwx3gKqySNYABicAzfip1rtimX7IDAb6YFK1Aj ilvwAYxgZZwONf6wWViW5HQcqwZ9x6ur6VNjqszLeD6eJU9sdlm3KuzWoH0H/OLu 4bV+OaKb51JIuBcmYLvX6yie+MbVSgVKmuiceZes4jsT2oMwQ0MrwLMjclD6mBMr uEhgYHm3hGDzJvMYJyArWNv/vzvi5AUmbpAVrG4hksVwK29CCOnphrG24qi7XE0+ /qnwDBuR7pN6RmEPiboX8LbE1uH+j5vgPeIckkYEI5f6AiJhIvPdsb6agPdCqOFV Sr3JheL1BH28lhQAargOCjUUZrubtIDg4BDaVsbBAsnTQTfAn/k= =wsEf -----END PGP SIGNATURE----- --=-=-=--